From 0acdb81ca62f1523eae310fc87f4011b3e161288 Mon Sep 17 00:00:00 2001 From: Sava Jakovljev Date: Mon, 18 Mar 2024 14:52:06 +0100 Subject: bitbake: bitbake-worker: Fix bug where umask 0 was not being applied to a task * In the current implementation, "umask" variable is initially set to None and overwritten with user-specified value. However, in the worker implementation, a faulty if clause would only check whether the variable contains a value that evaluates to True, and not whether the variable is defined, so the value of 0 would lead to umask not being changed. This bug makes it impossible to have a task set its umask to value 0, for any possible reason it may want to. Fix this bug by extending the condition checked in the worker implementation. (Bitbake rev: 19f9df6c750c592316a0fa18165b68636281fe3e) Signed-off-by: Sava Jakovljev Signed-off-by: Richard Purdie --- bitbake/bin/bitbake-worker | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bitbake/bin/bitbake-worker b/bitbake/bin/bitbake-worker index eba9c562c7..04d7570140 100755 --- a/bitbake/bin/bitbake-worker +++ b/bitbake/bin/bitbake-worker @@ -241,7 +241,7 @@ def fork_off_task(cfg, data, databuilder, workerdata, extraconfigdata, runtask): newsi = os.open(os.devnull, os.O_RDWR) os.dup2(newsi, sys.stdin.fileno()) - if umask: + if umask is not None: os.umask(umask) try: -- cgit v1.2.3-54-g00ecf