From 02f36dc832ae786dd0f790d86820611a71f0b960 Mon Sep 17 00:00:00 2001 From: Richard Purdie Date: Thu, 4 Nov 2021 13:37:30 +0000 Subject: bitbake: parse/ast: Show warnings for append/prepend/remove operators combined with +=/.= Operations like XXX:append += "YYY" are almost always wrong and this is a common mistake made in the metadata. Show warnings for these usages with a view to making it a fatal error eventually. (Bitbake rev: 8c31e75557dc6a8d8f407b5d24d6327889a3e3b1) Signed-off-by: Richard Purdie --- bitbake/lib/bb/parse/ast.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/bitbake/lib/bb/parse/ast.py b/bitbake/lib/bb/parse/ast.py index 743ea0dfc0..31bcc8e7ac 100644 --- a/bitbake/lib/bb/parse/ast.py +++ b/bitbake/lib/bb/parse/ast.py @@ -130,6 +130,10 @@ class DataNode(AstNode): else: val = groupd["value"] + if ":append" in key or ":remove" in key or ":prepend" in key: + if op in ["append", "prepend", "postdot", "predot", "ques"]: + bb.warn(key + " " + groupd[op] + " is not a recommended operator combination, please replace it.") + flag = None if 'flag' in groupd and groupd['flag'] is not None: flag = groupd['flag'] -- cgit v1.2.3-54-g00ecf