summaryrefslogtreecommitdiffstats
path: root/meta/recipes-multimedia
Commit message (Collapse)AuthorAgeFilesLines
* flac: Fix license warningRichard Purdie2012-03-161-1/+1
| | | | | | | | WARNING: flac: No generic license file exists for: FDLv1.2 in any provider (From OE-Core rev: 5a05d1ab0f01105551cacb15d46a4a77aedf9777) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* PR bump for all recipes that DEPEND on ncursesScott Garman2012-03-151-1/+1
| | | | | | | | | | The packaging changes to ncurses could break package feeds, so bump the PR on everythong that DEPENDS on ncurses. (From OE-Core rev: be92256917c157284ef8370bb93bbf443849b2e1) Signed-off-by: Scott Garman <scott.a.garman@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Revert "alsa-tools: update to 1.0.25"Richard Purdie2012-03-142-3/+3
| | | | | | This reverts commit b2d9f00a4e50180d96b3d201cc425349cc4dd530 since the checksums are incorrect and even when fixed, it doesn't actually build.
* alsa-utils: Add rename accidently dropped during patch mergeRichard Purdie2012-03-143-0/+0
| | | | | | (From OE-Core rev: 96b7e1780c3a25bc19022b66a9d92a9ccf22dc59) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* alsa-tools: update to 1.0.25Kang Kai2012-03-142-3/+3
| | | | | | | | | Update to version 1.0.25 (From OE-Core rev: b2d9f00a4e50180d96b3d201cc425349cc4dd530) Signed-off-by: Kang Kai <kai.kang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* alsa-utils: update to 1.0.25Kang Kai2012-03-142-6/+6
| | | | | | | | | | | Update to version 1.0.25, and update patch 0001-alsactl-don-t-let-systemd-unit-restore-the-volume-wh.patch because rejected when apply it. (From OE-Core rev: 23694c3dd5ce3c997f616804e7b01a784c46ff0b) Signed-off-by: Kang Kai <kai.kang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* alsa-lib: update to 1.0.25Kang Kai2012-03-143-3/+3
| | | | | | | | | Update to version 1.0.25, rename the patch directory at same time. (From OE-Core rev: 555bd3102fcd83d728091e074977b5a4228a2b1b) Signed-off-by: Kang Kai <kai.kang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* gst-plugins-bad: disable directfb in configurePaul Eggleton2012-03-141-2/+2
| | | | | | | | | | Disable directfb output (as we do with SDL) so that it does not get auto-detected resulting in a race condition. (From OE-Core rev: a05070eb3b867f35dd8ce7e41246057589d2a26d) Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pulseaudio: add X library dependenciesPaul Eggleton2012-03-142-2/+3
| | | | | | | | | | | PulseAudio requires libxtst, libice, libsm and libxcb when X11 is enabled (in our case, when x11 is in DISTRO_FEATURES), so conditionally add those to DEPENDS. (From OE-Core rev: a758df3d72942f985fe46455aa075e52100a1156) Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* alsa-utils: Ensure state directory is packagedRichard Purdie2012-03-131-2/+2
| | | | | | | | | | | | | This adds the localstatedir to the alsactl package to avoid the warnings: WARNING: For recipe alsa-utils, the following files/directories were installed but not shipped in any package: WARNING: /var WARNING: /var/lib WARNING: /var/lib/alsa (From OE-Core rev: 90ea03cd92bbc2c756a5fef6dcb4f797a6dd3fab) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* meta: Replace bb.data.expand(xxx, d) -> d.expand(xxx)Richard Purdie2012-03-052-5/+5
| | | | | | | | sed \ -e 's:bb.data.\(expand([^,()]*\), *\([^) ]*\) *):\2.\1):g' \ -i `grep -ril bb.data.expand *` Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* meta: Convert getVar/getVarFlag(xxx, 1) -> (xxx, True)Richard Purdie2012-03-052-3/+3
| | | | | | | | | | | | Using "1" with getVar is bad coding style and "True" is preferred. This patch is a sed over the meta directory of the form: sed \ -e 's:\(\.getVar([^,()]*, \)1 *):\1True):g' \ -e 's:\(\.getVarFlag([^,()]*, [^,()]*, \)1 *):\1True):g' \ -i `grep -ril getVar *` Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* tiff: Update to version 3.9.5Saul Wold2012-02-281-3/+5
| | | | | | | | | | Ensure that OpenGL and friends are disable with the setting of ax_cv_check_gl_libgl = no. (From OE-Core rev: 69e67ac74bda6de1243e35643ee4af8a25a5f32f) Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* More quoting fixesMartin Jansa2012-02-261-1/+2
| | | | | | | | | | * We have various variables which are either not quoted at all or are half quoted. This patch fixes the bad exmaples so everything is consistent. (From OE-Core rev: 960ee8076e860353a05eb2eb7f825a455c54698d) Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pulseaudio: Really disable orc supportEric Bénard2012-02-262-1/+2
| | | | | | | | | | | | If orc is detected the compilation fails with missing headers which should have been generated by orc (using meta-angstrom + meta-openembedded and and armv7 target) [RP: add RP bump, fix typos] (From OE-Core rev: 8f72d9e4ecf495646af3c5cebe7f08ca01bbbb99) Signed-off-by: Eric Bénard <eric@eukrea.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* mpeg2dec: depend on libx11 conditionallyAndreas Oberritter2012-02-231-1/+1
| | | | | | | | | | | * mpeg2dec currently doesn't build if x11 is unavailable, due to an unconditional dependency on libx11. However, libx11 is not required to build mpeg2dec. (From OE-Core rev: 6ebbeeb0bcd29aec25e2c437d0bc95dd78d62f82) Signed-off-by: Andreas Oberritter <obi@opendreambox.org> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* gst-plugins-base: depend on libx11 and libxv conditionallyAndreas Oberritter2012-02-231-1/+2
| | | | | | | | | | | | * gst-plugins-base currently doesn't build if x11 is unavailable, due to unconditional dependencies on libx11 and libxv. However, they are not required to build gst-plugins-base. (From OE-Core rev: 668ebf38a5b9b0dbd0f6f1a0ebfafb04afbcbf07) Signed-off-by: Andreas Oberritter <obi@opendreambox.org> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* recipes: bump PR to rebuild .la files without libz.laMartin Jansa2012-02-218-8/+8
| | | | | | | (From OE-Core rev: 1da6a2dbd5e7aeea6cd45ca05590bdd50b67bf89) Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* zlib: Upgrade 1.2.5 -> 1.2.6Khem Raj2012-02-105-4/+6
| | | | | | | | | | | | | | | | | | | | | | | | | Dont use autotools, it really not so autoconf like. the configure script gets updated with every release of zlib and we overwrite that. Instead use the upstream provided configure copyright year was changed in zlib.h which caused change in LIC_FILE_CHECKSUM fix.inverted.LFS.logic.patch is already applied upstream so drop it Drop the configure.ac and Makefile.am scripts since we do not autoreconf anymore and do not inherit autotools anymore Bump PR for depending recipes so a rebuild it ensues so that they dont depend on .la anymore and add missing dependencies discovered during incremental build (From OE-Core rev: 50ad5230ea9e0982cdfda23fb9fcfccf89d28f29) Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* alsa-utils: make alsa-utils-alsactl recommend alsa-statesKoen Kooi2012-02-011-1/+3
| | | | | | | | | This will drag in the asound.state from the BSP that alsactl uses. (From OE-Core rev: 6a1c75971d35b6a8272741a4f3e25ef46f7ce305) Signed-off-by: Koen Kooi <koen@dominion.thruhere.net> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* tremor: upgrade to 18163 (20120122)Shane Wang2012-01-241-1/+1
| | | | | | | (From OE-Core rev: 67ae9bbbab31b69f37e3ee0c1c969e43da034699) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* gstreamer: refactor packages for staticdevSaul Wold2012-01-243-7/+9
| | | | | | | (From OE-Core rev: 66c348403d2289ad9a4d95ee3f3aaf8088593e82) Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* tiff: refactor packages for staticdevSaul Wold2012-01-241-3/+4
| | | | | | | (From OE-Core rev: 93135c19b9574d952aaf8a4b97425640b847847a) Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* mpeg2dec: refactor packages for staticdevSaul Wold2012-01-241-4/+6
| | | | | | | (From OE-Core rev: 6d59ffeb45062b46fbfecf898f76183d73798331) Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Fix Upstream-Status entriesSaul Wold2012-01-241-1/+1
| | | | | | | (From OE-Core rev: 0cd9314ef95168ba5452a01ed8d923585c8d54ae) Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Add LICENSE_FLAGS to packages mentioned in COMMERCIAL_LICENSETom Zanussi2012-01-247-0/+8
| | | | | | | | | | | | | | | | | | | Per-recipe LICENSE_FLAGS replace the global COMMERCIAL_LICENSE list; add LICENSE_FLAGS varables to each the recipes mentioned in that list: - lame - gst-fluendo-mp3 - gst-openmax - gst-plugins-ugly - libmad - libomxil - mpeg2dec - qmmp (From OE-Core rev: 43410523a07d9eb52a7d57ae3dc1cc320cbbc6f9) Signed-off-by: Tom Zanussi <tom.zanussi@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* liba52: refactor packages for staticdevSaul Wold2012-01-191-3/+1
| | | | | | | (From OE-Core rev: 4390e0c6e6c9390f75410daaa4497826b7638ee5) Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* gst-openmax: refactor packages for staticdevSaul Wold2012-01-191-2/+3
| | | | | | | (From OE-Core rev: 6e1daa495a8ff16114d26e554d5e4a7e82c6dea6) Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* alsa-utils: depend on libsamplerate0Denis 'GNUtoo' Carikli2012-01-171-2/+2
| | | | | | | | | | | | | We need to depend on libsamplerate0 because it's detected automatically and if we configure without it we get that issue at runtime trying to run the alsaloop program: No libsamplerate support. (From OE-Core rev: 545a7407361a7e144a0f868e1a095bf7b10fffd8) Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* libomxil: upgrade to 0.9.3Shane Wang2012-01-035-23/+128
| | | | | | | | | | This patch is to upgrade libomxil from 0.3.3 to 0.9.3. The following is the licence change: 2c2 < @file src/omxcore.h Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* misc patches: fix patch headersNitin A Kamble2012-01-031-1/+1
| | | | | | | | | | These patches were marked by "UpstreamStatus:" line, fix it to use "Upstream-Status:" instead. (From OE-Core rev: b33b373c9a33fe0ff51104c96d1e5b105efc63ed) Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Add Upstream-Status to patchesSaul Wold2012-01-031-0/+2
| | | | | | | (From OE-Core rev: 169e55d802883df763dbff4a4737e05e96358fa3) Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* libsamplerate0: upgrade to 0.1.8Shane Wang2012-01-032-27/+4
| | | | | | | | | | | This patch is to upgrade libsamplerate0 to 0.1.8 and remove the patch for 0.1.7. In the new code, the fix is there in M4/endian.m4 (which is part of acinclude.m4 in 0.1.7) The license is changed from "Copyright (C) 2002-2008 Erik de Castro Lopo <erikd@mega-nerd.com>" to "Copyright (C) 2002-2011 Erik de Castro Lopo <erikd@mega-nerd.com>". (From OE-Core rev: 86ead283629303c835316974d5682e0f29bb9655) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* gst-ffmpeg: upgrade to 0.10.13Shane Wang2012-01-033-7/+32
| | | | | | | | | | | | This patch is to upgrade gst-ffmpeg to 0.10.13. Some license files are changed because the folder "ffmpeg" disappears, and those license files under "libav" are the same. LICENSE is different because the word "ffmpeg" is changed into "libav" under the libav folder. Again, gst-ffmpeg tar ball contains library libav itself. So the configure needs to disable yasm for x86. (From OE-Core rev: 5c86f5506a060e2005fcdad0b46ca650598a94af) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* gst-fluendo-mpegdemux: upgrade to 0.10.69Shane Wang2012-01-031-2/+2
| | | | | | | (From OE-Core rev: c532a8cf75e8a078c7e0bdf365f90deeb795d6ab) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* gst-fluendo-mp3: upgrade to 0.10.16Shane Wang2012-01-031-2/+2
| | | | | | | (From OE-Core rev: 9f0211958e9789ffbb1b1fe6f801626f62f448ff) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* gst-plugins-bad: upgrade to 0.10.22Shane Wang2012-01-031-4/+3
| | | | | | | | | | This patch is to upgrade gst-plugins-bad to 0.10.22. One of the license files is removed because the file doesn't exist any more. (From OE-Core rev: 7cfab069b0d5f87057c7a25f6d936471eecc6c19) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* gst-plugins-ugly: upgrade to 0.10.18Shane Wang2012-01-031-3/+3
| | | | | | | (From OE-Core rev: 3cc45809292a1123f7cc67f96e180f146b3ed1c7) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* libatomics-ops: move docs to correct directoryDmitry Eremin-Solenikov2011-12-191-2/+4
| | | | | | | (From OE-Core rev: 8023128a2af8e21ed94af90605a3b326cc801eed) Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pulseaudio: fix compilation with x32 toolchainNitin A Kamble2011-12-122-1/+240
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit makes assembly syntax compatible with x32 toolchain to avoid these x32 gcc errors: | pulsecore/svolume_mmx.c: Assembler messages: | pulsecore/svolume_mmx.c:107: Error: `(%esi,%rdi,4)' is not a valid base/index expression | pulsecore/svolume_mmx.c:135: Error: `(%esi,%rdi,4)' is not a valid base/index expression | pulsecore/svolume_mmx.c:161: Error: `(%esi,%rdi,4)' is not a valid base/index expression | pulsecore/svolume_mmx.c:162: Error: `8(%esi,%rdi,4)' is not a valid base/index expression | pulsecore/svolume_mmx.c:180: Error: `(%esi,%rdi,4)' is not a valid base/index expression | pulsecore/svolume_mmx.c:210: Error: `(%esi,%rdi,4)' is not a valid base/index expression | pulsecore/svolume_mmx.c:244: Error: `(%esi,%rdi,4)' is not a valid base/index expression | pulsecore/svolume_mmx.c:245: Error: `8(%esi,%rdi,4)' is not a valid base/index expression | make[3]: *** [libpulsecore_1.1_la-svolume_mmx.lo] Error 1 Orignally these assembly lines are written for x86_64 ABI, now they are also compatible with X32 ABI. (From OE-Core rev: ccf01c858218ae67d609ced3a05d9a93a6ffc5d4) Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* gst-fluendo.inc: remove unneccessary hackNitin A Kamble2011-12-121-4/+0
| | | | | | | | | | | | | This fixes bug: [YOCTO #1403] the custom definition of CC was causing build isuses with x32 toolchain. And also I found out that the hack is not neccessary anymore. the affected gst-fluendo-mpegdemux recipe builds fine without the CC hack. (From OE-Core rev: 81cbedaaddd589e03fe2f6cb789907b1e555a9d6) Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* OECore license fixes: meta/*Elizabeth Flanagan2011-12-081-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a quick audit of only the most obviously wrong licenses found within OECore. These fixes fall into four areas: - LICENSE field had incorrect format so that the parser choked - LICENSE field has a license with no version - LICENSE field was actually incorrect - LICENSE field has an imaginary license that didn't exist This fixes most of the LICENSE warnings thrown, along with my prior commit adding additional licenses to common-licenses and additional SPDXLICENSEMAP entries. HOWEVER..... there is much to be done on the license front. For a list of recipes with licenses that need obvious fixing see: https://wiki.yoctoproject.org/wiki/License_Audit That said, I would suggest another license audit as I've found enough inconsistencies. A good suggestion is when in doubt, look at how openSuse or Gentoo or Debian license the package. (From OE-Core rev: 3083dd70b3a9fa01fcc3cf00373b05502505996e) Signed-off-by: Elizabeth Flanagan <elizabeth.flanagan@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* libatomics-ops: patch source code for x32Nitin A Kamble2011-12-052-2/+44
| | | | | | | | | | | | | | | | | This Fixes bug: [YOCTO #1418] Remove the `q' suffix on x86-64 atomic instructions. We don't need the `q' suffix on x86_64 atomic instructions for AO_t, which is defined as "unsigned long". "unsigned long" is 32bit for x32 and 64bit for x86-64. The register operand in x86-64 atomic instructions is sufficient to properly determine the register size. (From OE-Core rev: daaaeb1bd1467a2bed75722ce3ff35be970402e0) Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com> Signed-off-by: H.J. Lu <hjl.tools@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pulseaudio 1.1: add filter-apply and filter-heuristics to pulseaudio-server ↵Koen Kooi2011-12-012-1/+3
| | | | | | | | | RDEPENDS, it won't start without (From OE-Core rev: 6ef79ede361c42e11e78d4afcff11295a3144055) Signed-off-by: Koen Kooi <koen@dominion.thruhere.net> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pulseaudio 1.1: convert to useradd.bbclassKoen Kooi2011-12-011-10/+8
| | | | | | | | | | | | | | The only thing that got lost in the conversion is the "Pulse Audio daemon" description: root@beagleboard:~# grep pulse /etc/passwd /etc/group /etc/passwd:pulse:x:999:1000::/var/run/pulse:/bin/false /etc/group:audio:x:29:pulse /etc/group:pulse:x:1000:pulse (From OE-Core rev: 2e5c7566a4b76bf3e783844cc69fd1313c6d97a4) Signed-off-by: Koen Kooi <koen@dominion.thruhere.net> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* gst-plugins-good: bump PR for gdbm SOVERSION changeMartin Jansa2011-12-011-1/+1
| | | | | | | (From OE-Core rev: 2c7006d4b8018f169cc60b428eb83c2f8004ec06) Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pulseaudio: bump PR for gdbm SOVERSION changeKoen Kooi2011-11-301-1/+1
| | | | | | | (From OE-Core rev: f334a041e7318cac2bb43643e154cafa9faeb374) Signed-off-by: Koen Kooi <koen@dominion.thruhere.net> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* gst-plugins-ugly: bump PR to rebuild after libid3tag fixMartin Jansa2011-11-301-1/+1
| | | | | | | (From OE-Core rev: bd5d7cd903f762b8d7260365018839969fa0ebf1) Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* libid3tag: add gperf to DEPENDSMartin Jansa2011-11-301-2/+2
| | | | | | | | | * see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=270449 (From OE-Core rev: 9a2f49c97116dfd718a6a055b296fc68ad668d5f) Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pulseaudio 1.1: replace hardcoded /etc with ${sysconfdir}Koen Kooi2011-11-302-5/+5
| | | | | | | (From OE-Core rev: 82414933a98b30f48507858e7fc22b349a4f8dab) Signed-off-by: Koen Kooi <koen@dominion.thruhere.net> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>