summaryrefslogtreecommitdiffstats
path: root/meta/recipes-graphics/pango
Commit message (Collapse)AuthorAgeFilesLines
* pango: fix postinstMartin Jansa2015-05-151-4/+6
| | | | | | | | | | | | | | | * merge postinst_prologue with the append in the do_split_packages call Now we can call correct pango-querymodules binary and respect D variable, otherwise we're trying to regenerate it on host which fails: pango-module-basic-fc.postinst: line 17: /usr/bin/pango-querymodules: No such file or directory (From OE-Core master rev: f5d189b80a1fd7187f47678935f9a584ccff8d0a) (From OE-Core rev: 3bbdb42c17222e78e3a4d043f26c9b2dce6d6891) Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango: upgrade to 1.36.8Ross Burton2014-12-311-2/+2
| | | | | | | (From OE-Core rev: dbfe7d6eb2a292efe25f43ca2f5b3bb476a6210d) Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango: update to 1.36.6Marko Lindqvist2014-09-101-2/+2
| | | | | | | | (From OE-Core rev: 715f62c5960263ecb0b181cab16ed28345f05189) Signed-off-by: Marko Lindqvist <cazfi74@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango / ptest: clean CFLAGS for host binaryWenzong Fan2014-09-031-1/+1
| | | | | | | | | | | The binary gen-all-unicode needs to be compiled for the host architecture, the CFLAGS passed to target system could cause build issues for it. (From OE-Core rev: b797cfbe605ab250a5eb714a7d5175861690ae6e) Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango: upgrade to 1.36.5Ross Burton2014-07-232-4/+4
| | | | | | | | | Update pango-ptest to reflect moved test suite. (From OE-Core rev: 360b4e750d4eb7d4cbf832a61d8b1a20280b1bed) Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango: enable ptestRoss Burton2014-05-204-18/+23
| | | | | | | | | | | Install the test suite for ptest. The test suite needs some fonts to be present to depend on liberation-fonts. (From OE-Core rev: af387e788ed73130331536c7b22c6237e7c23c71) Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Globally replace 'base_contains' calls with 'bb.utils.contains'Otavio Salvador2014-04-251-1/+1
| | | | | | | | | | | The base_contains is kept as a compatibility method and we ought to not use it in OE-Core so we can remove it from base metadata in future. (From OE-Core rev: d83b16dbf0862be387f84228710cb165c6d2b03b) Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango: upgrade to 1.36.3Cristiana Voicu2014-04-231-2/+2
| | | | | | | (From OE-Core rev: e61afbdf0227b8905092571c84ffd6fdeccc34be) Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango: Fix postinst by adding missing qemu-native dependencyMartin Jansa2014-03-071-1/+1
| | | | | | | | | | | | * postinst_prologue calls qemu_run_binary but there is no dependency on qemu-native which causes postinst to sometimes fail which is fatal for building read-only rootfs (From OE-Core rev: fc14983ae62dc4eb9f08e8f172ac51faaa6bcae2) Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango: upgrade to 1.36.2Cristiana Voicu2014-02-251-2/+2
| | | | | | | (From OE-Core rev: 0f16ca1aae1aacd30bde31dd89e9f4fc1d042f36) Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango: upgrade to 1.36.1Ross Burton2013-12-051-2/+2
| | | | | | | (From OE-Core rev: 99e934712e4244bc4c9db4a2d735deb5cff8228a) Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango: upgrade to 1.32.6Ross Burton2013-11-295-32/+12
| | | | | | | | | Drop automake macro patch, merged upstream. (From OE-Core rev: 22f1eb5165592b47baa35e28c5cb3d4faff36bae) Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango: fix x11 DISTRO_FEATURE checkRoss Burton2013-10-141-3/+2
| | | | | | | | | | | | --without-x was removed in 1.32.0, so the correct option is now --without-xft. Also remove --disable-glibtest, as configure.ac doesn't invoke that test. (From OE-Core rev: e806f4ff404515f38318b6fed7d2b614c2138da6) Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango: remove pango-module-basic-x RRECOMMENDSRoy.Li2013-07-131-1/+1
| | | | | | | | | | | | | | | | | pango-module-basic-x has been removed from pango-1.31.0 and we're using pango-1.32.5, so we should not refer pango-module-basic-x. Commit 194b6ee552318ec6c494f34ed9f0979d0460fe4f Author: Behdad Esfahbod <behdad@behdad.org> Date: Thu Aug 16 21:48:50 2012 -0400 Remove PangoX Been overdue... (From OE-Core rev: a609771a7dc8a102f080d31526e795705154e514) Signed-off-by: Roy.Li <rongqing.li@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango: drop unexplainable elfutils dependencyRoss Burton2013-07-101-1/+1
| | | | | | | | | | | | In dafefa7bd4de518adb63ec19390b77a56cb65d8e elfutils was added as a build-dependency of Pango. However there is no such linkage inside Pango, and it builds fine without elfutils. (From OE-Core rev: 48051f19a1df55ffdf72f90e331e31d9ccc76b3e) Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango: fix postinstall when using multilibLaurentiu Palcu2013-04-291-1/+1
| | | | | | | | | | | The pango-query-modules binary gets a multilib prefix and the postinstall has to call the appropriate binary. (From OE-Core rev: 21ae18ca5e3be0b3e5cb0fdcf19b1476dbd38b0c) Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com> Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango: use qemu_run_binary instead of pango-nativeConstantin Musca2013-01-182-19/+9
| | | | | | | | | | | | | | - use qemu_run_binary from qemu.bbclass to run pango-querymodules - remove pango-native from DEPENDS in order to do not create unbuildable dependency chains (e.g. ['gtk+', 'pango', 'pango-native', 'cairo-native', 'directfb-native']) [YOCTO #3642] (From OE-Core rev: c34bb3554112cbaeb4e125ff5ed190c0d3bbcf36) Signed-off-by: Constantin Musca <constantinx.musca@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango: replace obsolete automake macros with working onesMarko Lindqvist2013-01-162-2/+19
| | | | | | | | | | | Add obsolete_automake_macros.patch that replaces automake macros no longer supported by automake-1.13 with modern constructs. (From OE-Core rev: 16df16408719b93f595412a4c10df793d847dd19) Signed-off-by: Marko Lindqvist <cazfi74@gmail.com> Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango: update to upstream version 1.32.5Marko Lindqvist2013-01-105-47/+80
| | | | | | | | | | | multilib-fix-clean.patch adjusted to apply cleanly, and to handle new modules.cache file. (From OE-Core rev: bcc5773199b46811f913d06e960d34ed9833f714) Signed-off-by: Marko Lindqvist <cazfi74@gmail.com> Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango: have postinstalls run at do_rootfs timeLaurentiu Palcu2013-01-071-4/+22
| | | | | | | | | | | | | | | Since pango-native is built anyway and all the modules are in the native sysroot, create the cache file by scanning those files instead of the target files. The latter will fail because the shared objects wouldn't be from the same ELF class. [YOCTO #3600] (From OE-Core rev: 75334cbee1f064b38f167269917e333989802e7d) Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com> Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango: update to upstream version 1.30.1Marko Lindqvist2012-12-033-3/+3
| | | | | | | (From OE-Core rev: 82720dd1aa2594cc308130da4db4ff600263ac74) Signed-off-by: Marko Lindqvist <cazfi74@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* recipes-graphics: replace virtclass-native(sdk) with class-native(sdk)Robert Yang2012-11-021-1/+1
| | | | | | | | | | | | | The overrides virtclass-native and virtclass-nativesdk are deprecated, which should be replaced by class-native and class-nativesdk. [YOCTO #3297] (From OE-Core rev: db1a03da3a6a6e7adb68e28883204adfaa8b3f47) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* PACKAGES_DYNAMIC: use += instead of = in most casesMartin Jansa2012-10-191-1/+1
| | | | | | | | | | * to keep ${PN}-locale from bitbake.conf:PACKAGES_DYNAMIC = "^${PN}-locale-.*" (From OE-Core rev: 73252b16b501c0986b0ca0895e4534895a9ba3db) Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* PACKAGES_DYNAMIC: use regexp not globMartin Jansa2012-10-191-1/+1
| | | | | | | | | | | * bitbake uses PACKAGES_DYNAMIC as regexp ^ could make matching faster (and it will be more clear that we're expecting regexp not glob) * made all those last '-' optional, use .* (or nothing) (From OE-Core rev: 2f3ebdfa5f42dae51063b043cc4b0fbe20b40064) Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* recipes: bump PR to rebuild after libffi5 -> libffi6Martin Jansa2012-09-191-1/+1
| | | | | | | | (From OE-Core rev: 211200fb98a72ba815e7c411fbebfd781879064c) Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango: Add missing sign-off-by and upstream-statusRadu Moisan2012-09-041-0/+3
| | | | | | | (From OE-Core rev: 7cc3976dd558b2e4cb07adf2d8875eaed5b8d7ba) Signed-off-by: Radu Moisan <radu.moisan@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango: upgrade to upstream stable 1.30.0Radu Moisan2012-08-156-438/+27
| | | | | | | | (From OE-Core rev: dec33ee2c8badb64b90ce8230f218c6898f3703c) Signed-off-by: Radu Moisan <radu.moisan@intel.com> Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango: cleanup thanks to new gtk-doc.bbclassRoss Burton2012-07-222-3/+3
| | | | | | | (From OE-Core rev: 1c5fbfe7f284c8e8f6d850593192b8350c3ce7d5) Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Convert tab indentation in python functions into four-spaceRichard Purdie2012-07-191-3/+3
| | | | | | (From OE-Core rev: 604d46c686d06d62d5a07b9c7f4fa170f99307d8) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango: fix dependencies to avoid build issueNitin A Kamble2012-07-171-1/+1
| | | | | | | | | | | | | | | | | this commit avoids this build issue: | /srv/home/nitin/builds/build-gcc47/tmp/sysroots/x86_64-linux/usr/libexec/i586-poky-linux/gcc/i586-poky-linux/4.7.1/ld: cannot find -lelf | collect2: error: ld returned 1 exit status ... | make: *** [all] Error 2 | ERROR: oe_runmake failed NOTE: package pango-1.28.4-r7: task do_compile: Failed (From OE-Core rev: dafefa7bd4de518adb63ec19390b77a56cb65d8e) Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com> Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango: added upstream-status status.Lianhao Lu2012-06-151-0/+2
| | | | | | | | | Added missing upstream status. (From OE-Core rev: 5938eb43b3d7de65e58610f9d5044fadd42cc225) Signed-off-by: Edwin Zhai <edwin.zhai@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango: Fix modules load failure in multilib environmentZhai Edwin2012-05-083-5/+54
| | | | | | | | | | | | | Multi-libs of Pango need different modules, thus different config files and utils. This patch separate config file and utils with different MLPREFIX to avoid conflict. [YOCTO #2356] got fixed. (From OE-Core rev: 80c431989eef64d2c34a9cddb7fb95b7b9768706) Signed-off-by: Zhai Edwin <edwin.zhai@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango: import native support and --disable-introspection from meta-oeMartin Jansa2012-04-261-0/+3
| | | | | | | | | | * see http://git.openembedded.org/meta-openembedded/commit/?id=3f4c8edc60b3426dd96f76504169d742a04c1ce1 for details about --disable-introspection (From OE-Core rev: f3ff6f0d0ae3cef6f30a80fc64c251aec9dd1a01) Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* meta: Replace bb.data.expand(xxx, d) -> d.expand(xxx)Richard Purdie2012-03-051-1/+1
| | | | | | | | sed \ -e 's:bb.data.\(expand([^,()]*\), *\([^) ]*\) *):\2.\1):g' \ -i `grep -ril bb.data.expand *` Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* meta: Convert getVar/getVarFlag(xxx, 1) -> (xxx, True)Richard Purdie2012-03-051-1/+1
| | | | | | | | | | | | Using "1" with getVar is bad coding style and "True" is preferred. This patch is a sed over the meta directory of the form: sed \ -e 's:\(\.getVar([^,()]*, \)1 *):\1True):g' \ -e 's:\(\.getVarFlag([^,()]*, [^,()]*, \)1 *):\1True):g' \ -i `grep -ril getVar *` Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* zlib: Upgrade 1.2.5 -> 1.2.6Khem Raj2012-02-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | Dont use autotools, it really not so autoconf like. the configure script gets updated with every release of zlib and we overwrite that. Instead use the upstream provided configure copyright year was changed in zlib.h which caused change in LIC_FILE_CHECKSUM fix.inverted.LFS.logic.patch is already applied upstream so drop it Drop the configure.ac and Makefile.am scripts since we do not autoreconf anymore and do not inherit autotools anymore Bump PR for depending recipes so a rebuild it ensues so that they dont depend on .la anymore and add missing dependencies discovered during incremental build (From OE-Core rev: 50ad5230ea9e0982cdfda23fb9fcfccf89d28f29) Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango.inc: fix /etc/pango -> /${sysconfdir}/pango/*Saul Wold2012-01-191-1/+1
| | | | | | | (From OE-Core rev: ea660263d20066f35a47e60a9d48832ff3959ac3) Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango: create /etc/pango in module postinsts if it's missingKoen Kooi2012-01-172-1/+4
| | | | | | | (From OE-Core rev: 1b24f76bae9612bc69fb0afeaccb06c5e5746ce6) Signed-off-by: Koen Kooi <koen@dominion.thruhere.net> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Revert "pango.inc: add directory "/etc/pango""Koen Kooi2012-01-171-5/+1
| | | | | | | | | This reverts commit 65186bd86170d8c375931a18487c2fdf3bd1b3b0. (From OE-Core rev: 25c2d1a825a5d028b99f956be2918ceed4a93ac3) Signed-off-by: Koen Kooi <koen@dominion.thruhere.net> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango: Use gnomebase class, not gnomeRichard Purdie2012-01-162-2/+2
| | | | | | | | | | | | | There was a circular dependency introduced by the recent gconf changes to depend on gtk+. The issue is that gtk+ depends on pango and pango depends on gconf. This patch changes to use the gnonebase class since pango has no need of gconf/mime/gtk-icon-cache and hence removes the circular dependency. (From OE-Core rev: 91e17c0c0ac2330f826b95e762542cd0d0c82385) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango.inc: add directory "/etc/pango"Xiaofeng Yan2012-01-162-2/+6
| | | | | | | | | | | | | | Command "pango-querymodules > /etc/pango/pango.modules" can't work when \ starting up yocto because of no directory "/etc/pango". It will cause \ messy code when gtk-demo running. [YOCTO #1900] [RP: PR bump] (From OE-Core rev: 65186bd86170d8c375931a18487c2fdf3bd1b3b0) Signed-off-by: Xiaofeng Yan <xiaofeng.yan@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango: clarify LICENSE is LGPLv2.0+Joshua Lock2011-12-211-1/+1
| | | | | | | (From OE-Core rev: c801891878afcb75091315f4455db35009eaa246) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango: Disable x11 when pango doesn't run over x11Xiaofeng Yan2011-12-131-4/+12
| | | | | | | | | | | | pango run over x11 at current OE-core. If pango want to run over non-x11, then \ the configuration related to x11 should be disabled. [YOCTO #1674] (From OE-Core rev: e20bb10573dd67fd60b5b7f944eb0cbec2332a04) Signed-off-by: Xiaofeng Yan <xiaofeng.yan@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Convert to use direct access to the data store (instead of bb.data.*Var*())Richard Purdie2011-11-101-1/+1
| | | | | | | | | | | | | | | | | This is the result of running the following over the metadata: sed \ -e 's:bb.data.\(setVar([^,()]*,[^,()]*\), *\([^ )]*\) *):\2.\1):g' \ -e 's:bb.data.\(setVarFlag([^,()]*,[^,()]*,[^,()]*\), *\([^) ]*\) *):\2.\1):g' \ -e 's:bb.data.\(getVar([^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \ -e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \ -e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^() ]*\) *):\2.\1):g' \ -e 's:bb.data.\(getVar([^,()]*\), *\([^) ]*\) *):\2.\1):g' \ -i `grep -ril bb.data *` (From OE-Core rev: b22831fd63164c4db9c0b72934d7d734a6585251) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* recipes: bump PR after python upgradeMartin Jansa2011-10-311-1/+1
| | | | | | | (From OE-Core rev: 669b20b5af9c663f8f8bc4017511d60638f86088) Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango: Update to work with glib-2.0Richard Purdie2011-10-142-1/+410
| | | | | | (From OE-Core rev: e1d888cd20aafafdab60ec2a857f4ee19d1f9342) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Revert "pango: use qemu to generate pango.modules during rootfs construction"Richard Purdie2011-09-132-8/+5
| | | | | | | | | This reverts commit 62381fd3a135318794f14dc3740b04facd32446e. This commit has issues with the rpm rootfs generation which need resolving before it can be accepted. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango: use qemu to generate pango.modules during rootfs constructionPhil Blundell2011-09-072-5/+8
| | | | | | | | | This allows pango to be installed in an image with read-only-rootfs. (From OE-Core rev: 62381fd3a135318794f14dc3740b04facd32446e) Signed-off-by: Phil Blundell <philb@gnu.org> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango: make x11 support conditional on DISTRO_FEATURESPhil Blundell2011-08-292-5/+7
| | | | | | | | | | This allows pango to build on DISTROs which don't enable x11. Also adjust the SECTION since pango isn't really an X library. (From OE-Core rev: ac92a573dd38270a28967c76472435cfd7f9bdfe) Signed-off-by: Phil Blundell <philb@gnu.org> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pango: upgrade from 1.28.3 to 1.28.4Yu Ke2011-04-182-2/+6
| | | | | | | (From OE-Core rev: 76b86764b0346d8cac6aa915f4907f4b0ffe9a8d) Signed-off-by: Yu Ke <ke.yu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>