summaryrefslogtreecommitdiffstats
path: root/bitbake
Commit message (Collapse)AuthorAgeFilesLines
* siggen.py: Fix diffsigs output for filename comparisionsRichard Purdie2012-01-301-3/+15
| | | | | | | | | | | | | | | When comparing sig files, if the recipe locations had changed, the dependent tasks list would show as changed even if the actual hash had not changed. This updates the code to only compare the base part of the pathnames. It also tweaks some of the output to add newlines to aid comparing two lists of variables as it makes the location of the difference clearer. (Bitbake rev: 165a22ddcc647b945707fb5c483146bb336d5f66) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* codeparser: make var_expands actually hold useful informationChristopher Larson2012-01-301-1/+1
| | | | | | | | | | | Previously, it was calling var_expands.update() rather than add(), with a string argument, resulting in adding each character of that string to the var_expands set, rather than the string itself. (Bitbake rev: 8e4e75383e43d6da2c16ec5286186a0d0569b0f8) Signed-off-by: Christopher Larson <kergoth@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* lib/bb/runqueue: avoid marking runtime dependencies as coveredPaul Eggleton2012-01-301-1/+6
| | | | | | | | | | | | | | | | | | | | | | The code which populates setscene_covered list was adding a task to the covered list if all of the tasks that depend upon it were also covered; however, this means that tasks that would have installed "runtime" dependencies were being marked as covered also, e.g. gmp-native and mpfr-native are needed by gcc-cross at runtime since they are shared libraries that gcc links to, but their do_populate_sysroot tasks were being marked as covered, resulting in failures later on if gcc-cross was available from sstate but mpfr-native and gmp-native weren't. Since we currently have no real way to handle runtime dependencies for native packages, add a workaround which avoids marking tasks as covered if one or more of their revdeps are from a different recipe. Fixes [YOCTO #1536]. (Bitbake rev: e492eb4dc9016cd0bed194377c6f2b85cf0ad113) Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* utils.py: Fix lockfile retry handlingRichard Purdie2012-01-301-1/+1
| | | | | | | | | | The lockfile retry parameter is expected to return immediately after attempting to take the lock. There was a bug in the logic which this patch fixed to ensure it does that. (Bitbake rev: f421ef819f00ac659504d9af41bcc8323422ff8c) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* hob: fix backtrace when dismissing open dialogJoshua Lock2012-01-301-2/+2
| | | | | | | | | | | | Clearly a logic/indentation error - we should only try and load the recipe should the file-chooser return OK. Fixes [YOCTO #1668] (Bitbake rev: db59297aa1861614ffaea4295b9b054baa8a12b9) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* fetch2: Export additional variables to the fetchersMatthew McClintock2012-01-301-1/+2
| | | | | | | | | | git could need these environment variables when working behind a proxy (Bitbake rev: dca46cc2e1c75b6add2c4801e2994a4812745f5b) Signed-off-by: Matthew McClintock <msm@freescale.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* fetch2/git: Make git fetch run with -f so rebased branches don't failMatthew McClintock2012-01-301-1/+1
| | | | | | | | | | | | | | git fetches can fail (or at least return failed) when trying to fetch and prune rebased branches. This patch simply adds a -f to the git fetch command so these failure are ignore Generally, if some SHA was rebased away it's not coming back so there is no point in not doing this force (Bitbake rev: a7b75e4db52445b30ec0fc0053dcf454f5f7d2db) Signed-off-by: Matthew McClintock <msm@freescale.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* bitbake/lib/bb/msg.py: fix setting debug and verbosity levelsPaul Eggleton2011-09-262-4/+4
| | | | | | | | | | | | | | The debug and verbosity levels (as set by the -D and -v command line options respectively) were not being passed through within msg.py since bitbake revision 45aad2f9647df14bcfa5e755b57e1ddab377939a due to incorrect variable names. Fixes [YOCTO #1513]. (Bitbake rev: c6e88b7c0e61f9586a275df53f48b90687c5f92f) Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* hob: store recipe path at load timeJoshua Lock2011-09-261-1/+3
| | | | | | | | | | | This fixes the internal dirtiness tracking such that if the Save menu item is selected after loading a recipe the existing file is updated rather than the user being prompted for the path to create a recipe at. (Bitbake rev: 00fc1d7249b5e217cc7c36ac71b63ddad1c5b769) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* hob: fix building with current selections after reparseJoshua Lock2011-09-261-2/+0
| | | | | | | | | | | | After the reparse we were setting the model to reflect the values before the reparse was triggered but clearing the internal variables used to test whether these values are set, leading to the UI erroneously reporting that selections had not been made. (Bitbake rev: 656eafe0f2c9ec7730d33e15705b8c720f787c49) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/crumbs/hobeventhandler: fix variable name typoJoshua Lock2011-09-261-1/+1
| | | | | | | (Bitbake rev: f7d0560307707fe10bf80820f1e6ae300864f915) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/crumbs/hobeventhandler: move remaining getVariable calls to initJoshua Lock2011-09-261-4/+5
| | | | | | | | | | | | | Instead of calling getVariable commands each time the BBPATH and BBFILES entries need testing cache the results as a member variable at object instantiation. Fixes [YOCTO #1521] (Bitbake rev: 109e1597671dfb7222672e268190aabc727960ca) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Fix mercurial fetcher in fetch21.1_M4.rc3Julian Pidancet2011-09-211-1/+1
| | | | | | | | | | | The _build_revision method in Hg class gets called with the wrong number of arguments. This tiny patch adds a 5th argument to the method declaration to prevent python from throwing an exception. (Bitbake rev: 623e9c7f7a9cf12b8c81c26cc608990682a601dd) Signed-off-by: Julian Pidancet <julian.pidancet@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* hob: fix opening of image output dir on image build completionJoshua Lock2011-09-212-4/+7
| | | | | | | | | | | | | Firstly, rather than polling the DEPLOY_DIR_IMAGE directory each time an image is built store the variable as a member of the hobeventhandler. Secondly emit the generic "build-complete" signal *after* the specialised "build-failed" or "build-succeeded" signals such that the appropriate state variables are set before we try and use them. (Bitbake rev: 043914a8b478fd4a7799acd1b44bdb3b0af2165a) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/crumbs/runningbuild: fix log messages right-click menuJoshua Lock2011-09-211-1/+1
| | | | | | | | | Pass the correct callback name to the connect method. (Bitbake rev: d2b9167a7b0eb3fcb31d64f915beef41aac659a5) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* hob: enable package only builds even if an image has been builtJoshua Lock2011-09-201-0/+1
| | | | | | | | | | | | Once an image build has been performed the selected_image variable would prevent the package only build choice being triggered - by setting the variable to None on reset we are able to perform package only builds after an image build. (Bitbake rev: 705156e2812afb288632f01416fcbbf9add26bee) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* hob: fix build again when building packages onlyJoshua Lock2011-09-202-12/+12
| | | | | | | | | | | | | | | | The different code paths for package vs image builds have lead to some bit rot in the package only build and an incompatability between package only builds and the build again mechanism. This patch unifies the code paths and fixes build again for package only builds. Fixes [YOCTO #1480] (Bitbake rev: ab6c63f35739c30df0e8a9d0f1ae982b96e538ed) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/crumbs/hobprefs: re-enable reloading of data after prefs changesJoshua Lock2011-09-201-1/+1
| | | | | | | | | | | | | | When disabling the toolchain w/ headers checkbox in an early commit I accidentally disabled too much code. This re-enables adding the custom response handler to the Preferences dialog which triggeres a reparse of the metadata when appropriate preference changes are made. Fixes [YOCTO #1479] (Bitbake rev: bdbd724e806c9ca69cc1508bac7ec0a2dce95543) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* fetch2/git: fix subpath destination directoryPaul Eggleton2011-09-201-1/+3
| | | | | | | | | | | | | | Make the git fetcher's subpath (path within the git repo to fetch) option set the destsuffix (destination directory) option by default. This reverts the behaviour of subpath to the same as when it was introduced. Based on a patch by Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> (Bitbake rev: 3e7f8afeacf7c8c8de3e87778a3907e33d4a06b3) Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* fetch2/git: be more carefull in _contains_ref when checking git log outputMartin Jansa2011-09-201-1/+4
| | | | | | | | | | | * in some cases there could be output like this ERROR: ld.so: object 'libpseudo.so' from LD_PRELOAD cannot be preloaded: ignored. before wc -l output and returned 'output.split()[0] != 0' is always True (Bitbake rev: 3a54dcc09a12406ec6cf22b4b1a2cc4fc203822c) Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* fetch2/git: fix logger.debugMartin Jansa2011-09-201-1/+1
| | | | | | | | | | * logging/logger typo was fixed in 38a598731b49c8a0ba0ede570adc33eb1e848235 but debug level is still missing (Bitbake rev: 9de432fe2348cdbc93037bb49abb508d1fd38336) Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* fetch2/wget: make checkstatus() quieterJoshua Lock2011-09-201-3/+4
| | | | | | | | | | Change the wget fetcher to not emit the commands output when calling checkstatus, this matches the behaviour of the git fetchers checkstatus() method. (Bitbake rev: 5896d8ff7bcf85b3bab20fc27c4c15e87f86b4d9) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* taskdata: fix string formatting of an error messageChristopher Larson2011-09-201-1/+1
| | | | | | | (Bitbake rev: 224db31c46f5e91ced0e509c5fc564baaffa7b27) Signed-off-by: Christopher Larson <kergoth@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* cooker.py: Fix key expansion issues in showVersionsRichard Purdie2011-09-191-1/+6
| | | | | | | | | | | | | | | | bitbake -s was not displaying correct version information when the PREFERRED_VERSION string contains other variables. The actual built versions would differ since the providers.py functions were called with expanded keys at this point. This patch expands keys for showVersions bringing everything into sync correctly. [YOCTO #1493] (Bitbake rev: 3a0f2dda3c6de993f08ed50e9d513add9407339c) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* git.py: Fix logging vs logger typoRichard Purdie2011-09-171-1/+1
| | | | | | (Bitbake rev: 1043bbcd095314e717b372ed69ea6ee5b8a06573) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* hob: correctly set the selected image when loading a recipeJoshua Lock2011-09-131-0/+1
| | | | | | | | | | | | | When the user saves their recipe based on an existing image type, loads it in a newly run hob instance and clicks bake they should not be asked about building packages vs an empty image up. Partially addresses [YOCTO #1468] (Bitbake rev: f4be83aae77a713e2b5a2d094651639b6e641031) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* hob: correctly handle an exceptionJoshua Lock2011-09-131-1/+5
| | | | | | | | | | | | It doesn't matter if we can't remove the temprorary file, for some reason, so catch the exception and ignore it. Partially addresses [YOCTO #1468] (Bitbake rev: 4394e38b038e1bc9845adf01d73363157d98c96d) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/crumbs/hobeventhandler: don't check BBPATH and BBFILES each buildJoshua Lock2011-09-131-19/+20
| | | | | | | | | | | | There's no need to check the BBPATH and BBFILES are set correctly each build when running multiple builds for one launch of the UI. Partially addresses [YOCTO #1468] (Bitbake rev: 39ed18e70e9f3a13b522b4ea02bf6f4bdb7de89c) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/crumbs/hobeventhandler: fix test for BBFILESJoshua Lock2011-09-131-2/+1
| | | | | | | | | | | | | It seems we have a race whereby the image_dir variable may not be set before it's tested for, since the variable is always the same set it in the initialiser. Partially addresses [YOCTO #1468] (Bitbake rev: 09f5aed2edb0b8f4a6570e1041b5db66cf2d17cc) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* runqueue.py: Ensure fakeroot variables are reflected in the datastoreRichard Purdie2011-09-091-0/+1
| | | | | | | | | | Without this, variables can be set to one thing in one part of the environment and something different in another part. This change ensures the datastore and the environment are consistent. (Bitbake rev: 459addf13721a6847406f215650fa1882fb83ea9) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* runqueue: Ensure task environment is correctRichard Purdie2011-09-091-1/+10
| | | | | | | | | | | | | | | | | | This fixes two problems: a) Variables which were in the parent environment but not set as "export" variables in the datastore could end up in the task environment b) oe.environ.update() can't cope with the generator returned by bb.data.exported_vars() Whilst the updated code isn't as neat, it does do the expected thing, sets the environment correctly and stops unwanted values leaking into the task environment. (Bitbake rev: 67e5e23034c5ec2b9efcca935242830306c0048d) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* lib/bb/siggen.py: return a string from noop get_taskhashDmitry Eremin-Solenikov2011-09-051-1/+1
| | | | | | | | | | OpenEmbedded is expecting to get a string from get_taskhash, but noop siggen returns just 0 (number), so OE classes/sstate.bbclass barfs badly. Fix that. (Bitbake rev: 24272dae15ccf641ece11ef5a6e2bfa3ebb6f5f9) Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* hob: fix segfault on second buildPaul Eggleton2011-09-052-1/+6
| | | | | | | | | | | | | | Some internal lists were not being cleared, resulting in incorrect program flow on the second build, causing a structure to be accessed incorrectly which resulted in a segfault. Fixes [YOCTO #1332] (Bitbake rev: 71ac7fda51ed80e9ef6d1a3bca653683893e4770) Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* hob: clear out temporary file list after deletingPaul Eggleton2011-09-051-0/+1
| | | | | | | | | | | | If you don't clear out files_to_clean after the files get deleted and then you run a second build, it will try to delete the files from the first build and you will get a "No such file or directory" error. (Bitbake rev: 069d85cde01d14f8da31ad5cbd843a4d99628d42) Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* hob: disable removal of packagesJoshua Lock2011-09-051-18/+24
| | | | | | | | | | | | | | It's felt that the stability of package deselection is not sufficient for the upcoming release and thus package removal should be disabled. I'd actually like to see this patch, or its effects, reverted as soon as the release bits have been frozen so that this issue can continue to be worked on. (Bitbake rev: 73b6ff4654d10baae59d83e8568d58d989e99dd7) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/crumbs/runningbuild: mask run_buildstats failureJoshua Lock2011-09-051-0/+6
| | | | | | | | | | | | | | | The buildstats handler causes an exception with: "'NoneType' object has no attribute 'startswith'" early a build via hob, leaving a glaring red row which means nothing to the user. Mask this error until such a time as we have opportunity to correctly diagnose and fix the root problem. Workaround fix for [YOCTO #1433] (Bitbake rev: b0cce5b52a20c0dad5ec0c4053f437cae89b6137) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/crumbs/hobprefs: disable 'build toolchain with headers'Joshua Lock2011-09-051-6/+6
| | | | | | | | | | | | | | | The generic meta-toolchain-sdk we are currently building when this option is enabled is likely unsuitable for the majority of images built with hob. Remove this option from the Preferences UI until such a time as we can correctly implement this feature to include the library headers for the selected packages. Addresses [YOCTO #1302] (Bitbake rev: 3157967d08266b8d1ac563ba609ac3027b60d040) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* hob: add a test to ensure hob is run with the required pre and post filesJoshua Lock2011-09-051-0/+21
| | | | | | | | | | | | | hob requires pre and post configuration files to store configuration values in, whilst this should (and will) be fixed long-term for so long as we require these files we should alert the user should they run without them. Fixes [YOCTO #1383] (Bitbake rev: bb3e9113074ea1254aa03a247a1a1070682df9c8) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* hob: reflect defaultsetup being default distroJoshua Lock2011-09-051-0/+2
| | | | | | | | | | | If no value is set for DISTRO the defaultsetup policy is used, reflect this in the UI by having defaultsetup selected in the Distribution combo when no other DISTRO is set. (Bitbake rev: 126267c545ede65042959d134ea75c0345577747) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* hob: use both pre and post files for hob configurationJoshua Lock2011-09-054-48/+83
| | | | | | | | | | | | | | | | | | | | | We need to set various variables *before* parse begins, the simplest way to ensure this is to use a pre configuration file for the relevant configuration entries. This series adapts hob to use both pre and post files to store its configuration. Any variables which affect initial parse are set in the pre file and all others in the post file. Unfortunately this requires hob related code to have even more hard-coded data as to what is relevant but this is the simplest way to solve issues with variables and parse order at this time. Addresses [YOCTO #1281] (Bitbake rev: 02ab0e11d8dd42f5ca440b3d8d2073e23f55113a) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* bitbake/event: Allow event handlers to quietly raise SkipPackage eventsRichard Purdie2011-09-021-0/+2
| | | | | | (Bitbake rev: 2a7c92bdadf9a86d9ea2ea0c128108e38e0e97e5) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* fetch2/git: Allow to specify the name of the checkout directoryHolger Hans Peter Freyther2011-09-021-1/+2
| | | | | | | (Bitbake rev: 639db8c766cada7180f9447f51303f9b30d7e817) Signed-off-by: Holger Hans Peter Freyther <holger@moiji-mobile.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* bitbake/fetch2/git: Ensure .gitconfig file is ignoredRichard Purdie2011-08-311-5/+6
| | | | | | | | | | | | | | | If a user has a ~/.gitconfig file, git fetch --all will reference it. To avoid this we should run git fetch with an explicit url telling it to fetch all references (which includes tags). I'm assured this means git won't reference the file, see the discussion on the git mailing list (subject Overriding ~/.gitconfig using GIT_CONFIG). [YOCTO #1134] (Bitbake rev: 8540c09d4e509e3277940464c71174d8a0aca6ab) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* bitbake: Correctly handle multiline comments including whitespaceRichard Purdie2011-08-311-6/+6
| | | | | | | | | | | | | | | | | | | | | | | If metadata contains: """ FOO = "bar" """ The variable FOO should get set to "bar" but doesn't due to the empty lines be swallowed by the parser and FOO becomming part of the multiline comment. This patch corrects that behaviour so FOO is set as expected. [YOCTO #1377] This patch fixes parsing of multiline comments so lines ending with \ behave consistently and we warn users where there is something happening they likely don't expect. (Bitbake rev: 30eaef7f50fff855cf8830772a7088dd83a4240e) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/crumbs/tasklistmodel: don't add empty entries to COL_BINBJoshua Lock2011-08-301-1/+1
| | | | | | | (Bitbake rev: 85c5b8b3b9c805883537900a46eddb2301ee93f9) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/crumbs/tasklistmodel: loop optimisation in include_item()Joshua Lock2011-08-301-13/+7
| | | | | | | | | | | | Rather than trying to iterate the model to find whether the item is already included and then iterate the model again to find the items path attempt to find the path first and if the path is found test whether the COL_INC of the row is set. (Bitbake rev: 82845569c37591f6b097b9db071484f8171a39ea) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/crumbs/tasklistmodel: remove unnecessary checkJoshua Lock2011-08-301-3/+2
| | | | | | | | | Cheaper to set COL_INC to True regardless of whether it's already set. (Bitbake rev: 12c6f98ba7a68baeeaee00594d910e1be8d55d87) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/crumbs/tasklistmodel: optimise find_path_for_item()Joshua Lock2011-08-301-4/+2
| | | | | | | | | | | | | Rather than calling get_path() for each iterated value use the get_value() method to lookup the COL_NAME value and only call get_path() for a match. This should save some time by potentially removing N-1 calls to get_path() from the loop. (Bitbake rev: d2450536269996147a22d6eafbdf72aa62afa4f6) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/crumbs/tasklistmodel: prevent packages depending on each otherJoshua Lock2011-08-301-20/+22
| | | | | | | | | | | | | | | Don't add y to x's COL_BINB if x is in y's COL_BINB - prevent circular dependencies. Further this patch improves the variable naming to make this code easier to follow. Fixes [YOCTO #1423] (Bitbake rev: 01ef2ab0d201f3cb3666462558c9cf485592e04f) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/crumbs/tasklistmodel: don't add same item to binb column more than onceJoshua Lock2011-08-301-2/+3
| | | | | | | | | | | | In the same vein as a similar, earlier, patch where I missed the second loop which modifies the binb column. Fixes [YOCTO #1420] (Bitbake rev: 6ad1103b5fd592afa9ea03ef5a0d706604cc0e0f) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-11-14 12:30:09 +0000