summaryrefslogtreecommitdiffstats
path: root/bitbake/lib/bb
Commit message (Collapse)AuthorAgeFilesLines
* hob: fix save/restore of toolchain preferencesJoshua Lock2011-08-013-2/+25
| | | | | | | | | | Add some (namespaced) custom variables to the configuration file for sake of this UI. (Bitbake rev: c9dd2592434338bdddb3cc6f42e760c86fa9e6bb) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* hob: more reliable disabling of GPLv3 packagesJoshua Lock2011-08-014-18/+41
| | | | | | | | | | | | | | | | | | | | 1. reflect GPLv3's presence in INCOMPATIBLE_LICENSE value in the UI The hob UI currently only supports GPLv3 as a value for INCOMPATIBLE_LICENSE but doesn't properly reflect whether the value is already set. This patch rectifies this. 2. don't stomp over other INCOMPATIBLE_LICENSE values when disabling GPLv3 In case the user has other values set for INCOMPATIBLE_LICENSE we don't want to overwrite the value, we want to modify it. Fixes [#1286] (Bitbake rev: 68b992922bc7148d657a1c706c6acc67812a87c0) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* bitbake/providers: list PREFERRED_VERSION candidates when unavailablePaul Eggleton2011-07-271-0/+12
| | | | | | | | | | If the specified PREFERRED_VERSION is not available then list the available versions in the output. (PR is omitted.) (Bitbake rev: eea5ff9f34bb9b2e29f5fa43deb80d4aa6ef7ddc) Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* bitbake/taskdata: fix incorrect usage of rdependees instead of dependeesPaul Eggleton2011-07-271-1/+1
| | | | | | | | | | This looked like a copy-paste error - the code around is dealing with depends and not rdepends. (Bitbake rev: bb688635c2050da3cbbaa5aa5b00e882887695de) Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* bitbake: show more information for NoProvider errorsPaul Eggleton2011-07-275-9/+34
| | | | | | | | | | | | | | | | | | "Nothing PROVIDES" errors often come up when a recipe has been skipped for some reason, and therefore it is useful to print out that reason information when showing the error so that the user understands why the error has occurred. Given that we already feed the reason information into the skiplist for various situations (COMMERCIAL_LICENSE, COMPATIBLE_MACHINE etc.) this should now output a useful error message for skipped recipes. Fixes [YOCTO #846], [YOCTO #1127] (Bitbake rev: 6765218430e31c165888f26fbc75023c89a6eab2) Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/crumbs/hobprefs: trigger reparse when package format changedJessica Zhang2011-07-271-0/+1
| | | | | | | | | | | | | reload_data after package format change to make the change take effects in next build. Fixes [YOCTO #1287]. (Bitbake rev: fb47c7452455f3f8d943b21dd61300ec55eea141) Signed-off-by: Jessica Zhang <jessica.zhang@intel.com> Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* cooker: populate rdepends-pkg in generatePkgDepTreeDataJoshua Lock2011-07-271-0/+3
| | | | | | | | | | | The rdepends-pkg field of the generated depend_tree model was not populated in the original implementation of this method, this series adds in the loop to populate the rdepends-pkg column of the model. (Bitbake rev: 4f9a6f6f43cf2ef38115285897fbbde01964e892) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* hob: fix loading customised image recipeJoshua Lock2011-07-272-1/+7
| | | | | | | | | | | | | | The signal handler of the 'Base image' combo was still connected during load such that updating the UI to reflect the loaded base image triggered a change of the model. Fix this by disconnecting the signal handler when updating the displayed 'Base image'. Fixes [YOCTO #1282] (Bitbake rev: 58036a79cb79d1dff307e2cfed0e684493178507) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/crumbs/tasklistmodel: work around overly aggressive package removalJoshua Lock2011-07-271-3/+22
| | | | | | | | | | | | | | | | | | | | | The mark() method, which removes dependent and rdependent items, is overly aggressive removing items which are actually required by user selected items and then causing a removal of those items. Because the data structures used are not fine grained enough to do more intelligent dependency tracking the simplest "fix" is to track removals which are marked as "User Selected" and re-add those (and therefore their dependencies) once the aggressive removal is completed. Because the aggressive removal already ignores images and tasks this should make the removal behave as expected though certainly leaves area for improvement in future. Fixes [YOCTO #1280]. (Bitbake rev: 1e1055262450de994202fc3e5943b8b19f628681) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/crumbs/tasklistmodel: fix loading a saved recipeJessica Zhang2011-07-261-1/+1
| | | | | | | | | | | | | use the correct variable userpkgs instead of packages during reload saved bb file that contains user customization. Fixes [YOCTO #1289] (Bitbake rev: 2650be190afc05f9472aca8b11af99205a342838) Signed-off-by: Jessica Zhang <jessica.zhang@intel.com> Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/crumbs/tasklistmodel: don't iterate whole model in find_alt_dependency()Joshua Lock2011-07-261-10/+9
| | | | | | | | | | | The method needs to find an included item anyway so rather than iterating the entire model and checking the included status of each entry iterate over the contents gtk.TreeFilter. (Bitbake rev: 79bdd501075ff5164a8ee673a6a2a0e402978ae5) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/crumbs/tasklistmodel: handle items added in by base image being removedJoshua Lock2011-07-261-1/+15
| | | | | | | | | | | | | | When building an image based on an existing image we need to correctly handle removals from that images package set. Do so by testing if any of the items brought in by the base image are removed and, if so, building an image from scratch with all of the selected packages included. Fixes [YOCTO #1232] (Bitbake rev: 812ead4900714545850698d8ce29194f4ee8db0e) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/hob: enable building an image with minimal contentsJoshua Lock2011-07-262-7/+30
| | | | | | | | | | | | This patch enables a user to build a rootfs containing only the selected packages without having to have first selected a 'Base image'. Fixes [YOCTO #1239] (Bitbake rev: 05c82da31a69c910e72b58b07afcd9fca8c55479) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/hob: Force the 'Base image combo' to be drawn correctlyJoshua Lock2011-07-261-0/+4
| | | | | | | | | | | | | As the combo is created before its backing model it's common for the combo to be drawn at its minimum size and then grow the first time the user activates it. This slight ugly patch forces the combo to be resized as soon as the model is associated so that by the time the user interacts with the widget it is less likely to change size. (Bitbake rev: 65819447ccc96ae2af8d42cf3a31769ef3d2d26e) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/hob: change wording in build complete dialogJoshua Lock2011-07-261-2/+2
| | | | | | | | | | | | | The 'View Log' button is potentially confusing to existing users of the system who may be expecting to be shown the on disk logs of the build. Instead use 'View Messages'. Addresses [YOCTO #1222] (Bitbake rev: 105bfe3562235fb586be4b4179bb34b2e94ef234) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/hob: don't offer to show built output if build failsJoshua Lock2011-07-261-3/+7
| | | | | | | | | | The link to open the deploy directory should only be shown if the build completed succesfully. (Bitbake rev: d947f9880c2205be66fbd61cf7d3728275979a56) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/hob: switch from buildFile to buildTargets for custom image buildsJoshua Lock2011-07-263-32/+77
| | | | | | | | | | | | | | | We need to use the buildTargets command to ensure dependencies, such as native tools to build the rootfs, are correctly included. This patch achieves this by modifying BBPATH and BBFILES to include matches for the location of the generated recipe file and reparsing the metadata before calling buildTargets. Fixes [YOCTO #1228] (Bitbake rev: 5840d59098141e773c12bea8ed8d9f4f1a706132) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/crumbs/hobeventhandler: reparse files before running other commandsJoshua Lock2011-07-261-3/+5
| | | | | | | | | | Integrate reparseFiles into the run_next_command() method rather than calling reparseFiles on the server and immediately calling other methods. (Bitbake rev: 20f7218992cfe18f1d3dcea53f2e5a7bf96346db) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/hob: replace the ugly static command mapJoshua Lock2011-07-262-27/+35
| | | | | | | | | | | | | | The command_map was never a good idea, what's implemented here is a fraction less ugly but a significant factor more readable and therefore easy to maintain. The method implemented in this patch also has the advantage of not being static meaning we can determine the desired runCommand arguments dynamically at call time. (Bitbake rev: 8b11c68ffcda355d0ba49cfc27790d245192ae24) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* cooker: only append files onceJoshua Lock2011-07-261-1/+2
| | | | | | | | | | A list can contain the same value twice, therefore only append to the appendlist for a recipe if the append file is not already in the list. (Bitbake rev: d11f9dd33cdcc97a4a937e8bf7e97558d813cadd) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* command|cooker: Add reparseFiles commandJoshua Lock2011-07-262-19/+40
| | | | | | | | | | | Add command reparseFiles to reparse bb files in a running cooker instance. Fixes [YOCTO #1249] (Bitbake rev: de035ad99feb7644f99ad54804bf9f98cc776877) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* data|cooker: use saved environment variables when calling inheritFromOSJoshua Lock2011-07-262-5/+5
| | | | | | | | | | Now that we have a pristine copy of the variables available at launch time we can use them when looking to inherit the OS's environment. (Bitbake rev: 21c21fcc5871e81d8d497b6baed605cdd74c4571) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* bitbake/utils: 'Fix' bb.utils.contains() behaviourRichard Purdie2011-07-261-7/+6
| | | | | | | | | | | | | | | | | Currently bb.utils.contains(X, "A", true, false) will return true for substring matches, e.g. if X = "ABC". This is not what most users expect from the function. In the common OE use of this function there is the case of "touchscreen" and "screen" being used as independent variables. Whilst it could be argued there isn't a problem in that specific case (touchscreens are usually on screens), there is no substring usage of this function is OE-Core so this patch changes the behaviour to match only full strings. It also fixes a bug where duplicate entries would confuse multiple matches, e.g. contains(X, ["A", "B"], ...) would match X = "A A" which is clearly wrong. (Bitbake rev: 3d8647b68a8e66c7b240ed5fed7406e1b78fabf6) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Update version to 1.13.3Richard Purdie2011-07-251-1/+1
| | | | | | (Bitbake rev: f0b5d16426b983a67c51c47f3542162108bd4156) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* bitbake|cooker: save a copy of the environment when BitBake is startedJoshua Lock2011-07-251-1/+9
| | | | | | | | | | | | Create a data store in the cooker containing the values of the environment from when BitBake is launched such that child processes can replicate (and/or use values from) the host environment, rather than the cleaned up environment that the main BitBake process uses. (Bitbake rev: 54c7206165c0e7cfe5f7b243c80461baf5e7dfb1) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* bitbake/cooker: show a warning when -b is specifiedPaul Eggleton2011-07-251-0/+4
| | | | | | | | | | | | Too many people are using -b because they think it is the normal way of specifying a target to be built, and then get confused when the build fails due to a missing dependency; so show a warning about dependencies not being handled when this option is used. (Bitbake rev: c470f3f36aef24c46d9722593422286340be296b) Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* hob: rework image output type settingJoshua Lock2011-07-254-26/+56
| | | | | | | | | | | | | | | | | The preferences UI to set the image output type only supported setting a single value whereas it's common practice, particularly for those making use of the ADT, to set multiple values. This is also the default in Poky. This reworked preferences UI dynamically generates check boxes for each available image type and sets an appropriate string representing all image types when checkboxes are toggled. Includes fixes for [YOCTO #1273] (Bitbake rev: f7f68847dd165f2ad0f39011db4ebfef3ae73f42) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/crumbs/hobprefs: tweak the package format tooltipJoshua Lock2011-07-251-1/+2
| | | | | | | (Bitbake rev: 5f774ef02743c09d181395f15fc9262e7a67ef5c) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/crumbs/hobprefs: set higher arbitrary limit on threads & parallelismJoshua Lock2011-07-251-1/+6
| | | | | | | | | | | | | | We don't have a good handle on a sane cap value so just set it to an arbitrary, but reasonably high, number. Once we have some more numbers on values for number of threads and make parallelism we can integrate the algorithm into the GUI. Addresses [YOCTO #1266] (Bitbake rev: 31274e78eab502f5eb9f6079897644b535d31dd1) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* hob: only add new layer's to the UIJoshua Lock2011-07-252-3/+6
| | | | | | | | | | | | | | | If a user added the same layer more than once the underlying bblayers.conf file would not have multiple entries but the UI would show an entry for the layer for each time it was added. This patch changes the Configurator to return None values if the layer wasn't added to bblayers.conf and the LayerEditor to only update the UI if non-None values are returned. Fixes [YOCTO #1275] (Bitbake rev: 9c59baa4da3c863ebc412a56ffd8dbd7a8ffeb60) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/hob: if the user clicks Stop a second time only offer 'Force Stop'Joshua Lock2011-07-251-12/+26
| | | | | | | | | Fixes [YOCTO #1264] (Bitbake rev: 117fb14b93086660ce3f853964536920f916e060) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/hob: clear the search entry when resettingJoshua Lock2011-07-251-6/+7
| | | | | | | | | | | When resetting and clearing all selections the searched for term is no longer the selected row in the packages list, clear the search entry to prevent cognitive disconnect. (Bitbake rev: 4f86f5763ecf7f3a9673a9b18e96042e9387699b) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/crumbs/tasklistmodel: don't show native and cross recipesJoshua Lock2011-07-251-0/+3
| | | | | | | | | Addresses [YOCTO #1224] (Bitbake rev: 80f8d796392cbf3c54149c06347c35f871fc2d79) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* hob: refer to tasks as Package CollectionsJoshua Lock2011-07-251-1/+1
| | | | | | | (Bitbake rev: 453d65df6675f38b57f92d8a1b65aa3f78abe4f0) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* bitbake/cache: allow class names with arguments to be specifiedPaul Eggleton2011-07-251-2/+3
| | | | | | | | | This ensures we understand e.g. "virtual:multilib:lib64:pn" for multilib. (Bitbake rev: 0b9dee799cfe2229ec62c257dda36bd6c15d34a9) Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* bitbake/ast: include class name when arguments given in variantPaul Eggleton2011-07-251-6/+8
| | | | | | | | | | | For multilib this produces variants of e.g. "multilib:lib64" instead of just "lib64"; however we set BBEXTENDVARIANT to "lib64" and the latter will be used when composing filenames for multilib. (Bitbake rev: de7a2b91512bb3ab058f5eb5cd188acd2b8a2220) Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* bitbake/utils: Add contains helper function from lib.oe.utilsRichard Purdie2011-07-221-0/+14
| | | | | | | | | | | This function is needed by some of the early .conf setup we need to improve the machine/tune files in Openembedded. We need to add it here since the location in oe.utils can't be accessed until after base.bbclass parses which is too late for our needs. (Bitbake rev: abc67ed6921c98ed581f101ec1acc589fd9ce7e9) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Remove unused target tree data for HobLiping Ke2011-07-211-21/+68
| | | | | | | | | | | | | Since Hob only needes package dependency information, we can create a new version of package information retrieving methods, remove task dependency information, so that we can greatly reduce data loading time for Hob (Bitbake rev: df55199209ef042e5b1ca04c4df75c7d639b51eb) Signed-off-by: Liping Ke <liping.ke@intel.com> Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* event: fix the event display order when exiting earlyChris Larson2011-07-211-2/+1
| | | | | | | | | | | | It was displaying the log messages in LIFO order, which isn't what we expect to see. Thankfully this only occurred during an early abort (e.g. config file parsing error), but those are the cases where it's very important to see accurate messages, to diagnose. (Bitbake rev: b838e0f3a1b481c295f66f5c9f561fa4d51de673) Signed-off-by: Chris Larson <chris_larson@mentor.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/crumbs/tasklistmodel: ignore tasks and images when marking dependenciesJoshua Lock2011-07-211-4/+17
| | | | | | | | | | | | | | | When calculating what dependencies are affected by the removal of an item we should ignore images and tasks as they are not constructs which make sense in the GUI. E.g: if we don't ignore tasks and remove opkg from an image based on core-image-minimal the fact that opkg was brought in by task-core results in task-core and all of the packages it brought in being removed and, eventually, an empty image. (Bitbake rev: 205b52bfc7f28af0c50fef1f741fae6af16fb0dc) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/hob: don't crash if PARALLEL_MAKE doesn't include a spaceJoshua Lock2011-07-211-1/+1
| | | | | | | | | | | Use string.strip() as a much safer method of turning the -j value into an int Fixes [YOCTO #1244] (Bitbake rev: 03baee9e0a7fc15fc6c226c07c0f50df136ac5b0) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/crumbs/configurator: write new lines after new entriesJoshua Lock2011-07-211-1/+1
| | | | | | | | | | New entries written to a configuration file should be on separate lines, ensure this is the case by appending a newline to each written variable. (Bitbake rev: bac689fc34ea55c062d60ef249b79faa35f546a1) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/hob: add more guidance to the stop dialogJoshua Lock2011-07-211-1/+8
| | | | | | | | | | | | This patch adds explanation of the different options when asking the user to choose between Stop and Force Stop so they can make an informed choice. Fixes [YOCTO #1223] (Bitbake rev: afb87a809962b756f8282c9e9fdf9b15cdb9192b) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/crumbs/tasklistmodel: fix saving recipesJoshua Lock2011-07-211-2/+1
| | | | | | | | | | | | | After switching to dynamically finding the relative path for the recipe file it's no longer to append .bb when inserting the require line into the saved recipe. Fixes [YOCTO #1247] (Bitbake rev: 2d05ce4f527daa905ed64485029ebeb2b349daa6) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/crumbs/hobprefs: add missing importJoshua Lock2011-07-211-0/+1
| | | | | | | | | | | glib.idle_add is used so the glib module must be imported Fixes [YOCTO #1248] (Bitbake rev: 0ab099f6ff4cc4e92484282d2dee442e55471e0c) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* parse/ConfHandler: Fix multiline variable corruptionRichard Purdie2011-07-211-1/+1
| | | | | | | | | | | | | | | When parsing multiline variables in conf files, the last character can be accidentally removed. s2 contains new data read from the file which may or may not end with the continuation character. It makes sense to let the next loop iteration strip this if needed. We don't often use multiline expressions in .conf files which is why I'd imagine we haven't noticed this before. Most variables are quoted and its the closing quotation which often disappears. (Bitbake rev: 09a9146262d58dfe4a2ea4270026b90ae33f6c91) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* cache: fix remnant broken 'info' reference from recent cache changesChristopher Larson2011-07-211-1/+1
| | | | | | | (Bitbake rev: 807fb0b3bbad5163fdab24d379c2deba8f0b4f13) Signed-off-by: Christopher Larson <kergoth@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* cooker: only return *Found events if something was actually foundJoshua Lock2011-07-141-4/+8
| | | | | | | | | | | | | The cooker methods which fire FooBarFound style events should only fire the event when an item was actually found, rather than each time the method is called. Fixes [YOCTO #1219] (Bitbake rev: 5c8eeefc79455f058dda8f04cf4c12dc5418e00f) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/crumbs/tasklistmodel: fix automatic removal of orphaned itemsJoshua Lock2011-07-131-15/+19
| | | | | | | | | | | | | | | | | The sweep_up() method intends to remove all packages with an empty brought in by column, this patch changes the implementation to be more reliable. Each time a removal is triggered we begin interating the contents model again at the beginning, only once the contents model has been iterated from start to finish without any removals can we be certain that there will be no more orphaned items. Fixes [YOCTO #1218] (Bitbake rev: 4803c6d3d1db31105d98a7f71596875333db0dc5) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/crumbs/tasklistmodel: update brought in by column when possibleJoshua Lock2011-07-131-4/+10
| | | | | | | | | | | | | | When a package is orphaned we were not correctly updating the brought-in-by column if a later package additon would have brought that package in as a dependency. This patch ensures that orphan packages are correctly re-parented when appropriate. Partially addresses [YOCTO #1218] (Bitbake rev: 570405f2f5a3976b308ef825ef477fb5cb6ee804) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>