summaryrefslogtreecommitdiffstats
path: root/bitbake/lib/bb/ui
Commit message (Collapse)AuthorAgeFilesLines
* bitbake: command: add error to return of runCommandChristopher Larson2013-01-285-42/+84
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, command.py can return an error message from runCommand, due to being unable to run the command, yet few of our UIs (just hob) can handle it today. This can result in seeing a TypeError with traceback in certain rare circumstances. To resolve this, we need a clean way to get errors back from runCommand, without having to isinstance() the return value. This implements such a thing by making runCommand also return an error (or None if no error occurred). As runCommand now has a method of returning errors, we can also alter the getCmdLineAction bits such that the returned value is just the action, not an additional message. If a sync command wants to return an error, it raises CommandError(message), and the message will be passed to the caller appropriately. Example Usage: result, error = server.runCommand(...) if error: log.error('Unable to run command: %s' % error) return 1 (Bitbake rev: 717831b8315cb3904d9b590e633000bc897e8fb6) Signed-off-by: Christopher Larson <chris_larson@mentor.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Save proxy settingsBogdan Marinescu2012-10-012-33/+43
| | | | | | | | | Proxy settings were not properly saved between Hob runs. This fix is mostly a backport of code in master. [YOCTO #3024] Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
* bitbake: hob: format error messages properlyPaul Eggleton2012-10-011-1/+3
| | | | | | | | | | | | | Error messages that use arguments need to be formatted properly, or we don't get the full message. Use a formatter to do this when an error occurs. Partial fix for [YOCTO #2983]. (Bitbake rev: 6783538884adecd914909a9ab4ca73c27575f3ad) Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* bitbake: hob: ensure error message text is properly escapedPaul Eggleton2012-10-011-2/+3
| | | | | | | | | | | | | Our lack of markup escaping was causing invalid markup, leading to the error dialog being blank. Use the glib markup escaping function provided by PyGTK+ to do this properly and avoid the blank error dialogs. Partial fix for [YOCTO #2983]. (Bitbake rev: 563ea5233a5ab1629c51e802d04280692f96c596) Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* hob: handle sanity check failures as a separate eventPaul Eggleton2012-06-142-1/+12
| | | | | | | | | | | | | | | | In order to show a friendlier error message that does not bury the actual sanity error in our typical preamble about disabling sanity checks, use a separate event to indicate that sanity checks failed. This change is intended to work together with the related change to sanity.bbclass in OE-Core. Fixes [YOCTO #2336]. (Bitbake rev: 24b631acdaa143a4de39c6e1328849660c66f219) Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: Adjust the progress bar and set 100% only when all is done.Shane Wang2012-06-142-2/+18
| | | | | | | | | | | | | | | | After parsing recipes, Hob will populate recipes and packages, which is probably time exhaused. So, this patch is to adjust the progress bar and ensure 100% is set if and only if all populations are done. The patch also fixes "weird 18 second delay when parsing recipes" on build appliance. Because Hob is doing something, but the progress bar shows 100% and wait there. [Yocto #2341] (Bitbake rev: 2c4a21dc8a588c8cf05549ddd9734731a46bea10) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: add original url show function with the tooltip hyperlink for userLiming An2012-06-051-0/+19
| | | | | | | | | | | | | When case about No browser, such as running in 'Build Appliance', user can't open the hyper link, so add this work around for user. (Checking the browser is avaiable or not is hard by different system and browser type) [YOCTO #2340] (Bitbake rev: 02cc701869bceb2d0e11fe3cf51fb0582cda01b0) Signed-off-by: Liming An <limingx.l.an@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: change the refresh icon speed to make it view clearLiming An2012-06-051-1/+1
| | | | | | | | | | | Because the arrow icon refresh so fast as the go backward by illusion, so adjust it slow. [YOCTO #2335] (Bitbake rev: ac4a8885fafdc0d1e79831334ead9a8ddb6e2472) Signed-off-by: Liming An <limingx.l.an@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: Clear the building status if command failedDongxiao Xu2012-06-051-0/+2
| | | | | | | | | | | | We may meet certain command failure during build time, for example, out of memory. In this case, we need to clear the "building" status. This fixes [YOCTO #2371] (Bitbake rev: 283dbbbf5d34adb4c9e3aa87e3925fdebe21ff42) Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: Issue sanity check after parse is completedDongxiao Xu2012-04-242-7/+16
| | | | | | | | | | | | | | | | In original scheme, sanity check is part of the parsing process. If a sanity check fails, it means the parsing is failed and values in Hob GUI may not correct. With this commit, Hob will actively issue sanity_check() after the parsing is completed. This fixes [YOCTO #2361] (Bitbake rev: 36968815dcc91759eeacb308bf4b294af416eee5) Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: Add proxy setting into setting's md5Dongxiao Xu2012-04-241-0/+9
| | | | | | | | | | If user changed the proxy setting, we will reparse configuration because it may need sanity check. (Bitbake rev: 0be54917cd88ea8f110027a7840ac69a411fd589) Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* hob: enable sanity checks after launchJoshua Lock2012-04-232-0/+5
| | | | | | | | | | To ensure the users configuration is sanity tested enable the sanity checks after the GUI has started but before any parsing is done. (Bitbake rev: 244ce2b900ae6cecbeeccfe2056e61c132476261) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* lib/bb/ui/crumbs/recipeselectionpage: fix type availabel->availableJoshua Lock2012-04-171-1/+1
| | | | | | | (Bitbake rev: 1a39698ab8498410d159c665c015f9297f153797) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* hoblistmodel.py: description for selfcreated imageBeth Flanagan2012-04-171-1/+3
| | | | | | | | | | The current description is empty. This adds a default description for hob's dummy_image. (Bitbake rev: 68a65e5eeeb01d78444f1e5b5d1bb7b21c9d0b2c) Signed-off-by: Beth Flanagan <elizabeth.flanagan@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: Set the "stop" button insensitive before hide itDongxiao Xu2012-04-171-0/+1
| | | | | | | | | | | If user stops a build, we need to firstly set the button insensitive and then hide it. This ensures the button's init status is "insensitive" in next build. (Bitbake rev: ea37272ccc28d6e24b48286e5c4c3edbad1d57cd) Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: Enlarge the upper value of image sizeDongxiao Xu2012-04-171-4/+4
| | | | | | | | | | | | Originally the upper value for image size and extra size is 1024M, which is relatively small. Enlarge it to 64GB. Besides, fix tooltip for toolchain build. (Bitbake rev: 99f01305b4c2253567a1a13a33339b1755a86e6d) Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: fixed a little view issue about package selection pageLiming An2012-04-161-1/+2
| | | | | | | | | In package selection page, treeview cell data callback function not cover the 'else' case, so parent item will render the pervious value. (Bitbake rev: 98694c1dbc276cc151f393db67bfd43442da28ba) Signed-off-by: Liming An <limingx.l.an@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: add the parent window to 'binb' popup window for managing itLiming An2012-04-162-2/+6
| | | | | | | | | | The 'binb' popup window should be "set transient for" the main application window which they were spawned from. (Bitbake rev: a6f45b23851e22c7793d9a534fd197316bb5b9b8) Signed-off-by: Liming An <limingx.l.an@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: fixed the issue that the notebook overlay-scrollbar is overlappedLiming An2012-04-161-1/+0
| | | | | | | | | | | | In those systems which had use gtk overlay-scrollbar feature,such as Ubuntu 11.10, we have the issue with the multiple overlaped scrollbar in 'Recipe View' notebook or 'Package View' notebook, this patch is going to fix it. (Bitbake rev: f6be78d8a45dc501c2bbe1e1a399a342dabe11d5) Signed-off-by: Liming An <limingx.l.an@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: Fix contents in imagedetailsscreenDongxiao Xu2012-04-162-5/+6
| | | | | | | | | | This commit fixes the contents in imagedetailsscreen, which lacks some kind of image types, e.x., iso and hddimg. (Bitbake rev: 4505097f4f7834857a6086d5dabeedb24b49cf4c) Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: add exception handlingShane Wang2012-04-152-103/+128
| | | | | | | | | | Create a wrapper with exception handling to call self.server.runCommand() safely. Again, add exception handling to load_template() and save_template() (Bitbake rev: cb07a027d3366ed30b0f7e5e85d08c6fda4eb5b9) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: Simplify the init processDongxiao Xu2012-04-152-19/+5
| | | | | | | | | | This commit merges some functionalities together and avoid unnecessary signal handling. This can help to speed up the Hob startup. (Bitbake rev: e5a6eb4f007bf270f2fddc814eb856da46e20eee) Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: Handle NoProvider event in runningbuild moduleDongxiao Xu2012-04-153-25/+31
| | | | | | | | | | | | | If NoProvider event is received, we will handle it in runningbuild module and send notification to Hob instance, avoiding stepping into the final page with no image built out. This fixes [YOCTO #2249] (Bitbake rev: 067bc46a0fbc542fef1fcaa406ad3737a4c5a55a) Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: reset user recipe selection and package selection after settings are ↵Shane Wang2012-04-142-7/+9
| | | | | | | | | | | | | | | | changed Reset user recipe list and package list after the user changes the settings and triggers recipe reparsing. This is to continue to fix the bug [Yocto #2255] [Yocto #2255] (Bitbake rev: 95f4e9dc351f67442844ff52f90fc154fa95ba95) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: remember layers and settings between Hob sessionsShane Wang2012-04-144-72/+127
| | | | | | | | | | | | | | | | | | | | | | | This patch is to remember layers and settings between Hob sessions, which includes: - Put some variables for the build details screen from Configuration to Parameters because they are not actually for build but for show - We create a dummy Configuration instance and a dummy Parameters instance in __init__ of builder - The two instances will be assigned the real values by update_configuration_parameters() after parsing (in the event callback) - When it is the first time to launch Hob in a build directory, nothing is remembered since everything is fresh. - The feature is implemented with templates, and based on the hook for Hob. - When the user changes the layers or the settings, a default template file is saved into ".hob/". - Later on, the layers and the settings are remembered by loading the default template automatically. (Bitbake rev: f7c874ab930b9e7f95e79d0e84e62eb9b967f566) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: Use BB_DEFAULT_TASK as build task instead of hardcoded "build"Dongxiao Xu2012-04-142-7/+15
| | | | | | | | | | | | Originally we use hardcoded "build" as the default task. This commit fixes it by using BB_DEFAULT_TASK. This fixes [YOCTO #2283] (Bitbake rev: 7540f8d446345559ea9b47f4ff71d203ffdfaf8d) Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: Build selected image if not customizedDongxiao Xu2012-04-142-13/+23
| | | | | | | | | | | | If user selected a base image and didn't customize it, Hob will still build the selected image instead of hob-image. This fixes [YOCTO #2253] (Bitbake rev: a74a6a033e66a0ae7b47c84d842bdd54066c69a1) Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: Save the original image name into templateDongxiao Xu2012-04-142-23/+2
| | | | | | | | | | Previously we use the template file name as the image name. This commit changes to use the original selected image into template file. (Bitbake rev: 14a9da66fe08d181f45853c52e0c9f14773070a8) Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: A minor fix on tooltipRichard Purdie2012-04-141-1/+4
| | | | | | | | (Bitbake rev: b1449ce6ccf4e33eb2fd34829d2c435a464ae88b) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: Added required packages for toolchain.Lianhao Lu2012-04-131-1/+3
| | | | | | | | | | | | Added the requried packages task-core-standalone-sdk-target(-dbg) for building toolchain. Fixed bug [YOCTO #2274] (Bitbake rev: 434fdb3913cc78e2e9cdeede4c4fa7f1c8ef8892) Signed-off-by: Lianhao Lu <lianhao.lu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: forbid users to exit Hob directly when Hob is busyShane Wang2012-04-131-0/+6
| | | | | | | | | | | | | When Hob is busy with generating data, exiting Hob is not allowed. That should be reasonable because at that time the mouse cursor is not a pointer. If users want to exit, they can click "Stop" first and then do exit. That is also a walkaround for [Yocto #2142] (Bitbake rev: ad7f6bf3c7c4c15d546781aaefdaf03f00193f7c) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: Implement Hob config parse hookDongxiao Xu2012-04-132-12/+40
| | | | | | | | | | | | | | | To make Hob's specific variable settings take effect, we add a Hob config hook at the end of parsing for each configuration file, and in the hook function, Hob will set its own variables to the data store. This fixes: [YOCTO #2210] [YOCTO #2254] (Bitbake rev: 0ec7d1bbfd2e09ae60f99e6134b20ffd1d9145b1) Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: fix the missing functionsShane Wang2012-04-121-2/+6
| | | | | | | | | | | | | The patch is to correct 7e5d41ab223b73c1c7b2cf7e4dd13289a2dc2e8b (Bitbake rev: b6e68019494044305ab28492a517d1eafea851c3) to fix the missing functions. [Yocto #2281] (Bitbake rev: 3c2808b67384e92601cbd66877c36ca40df7c7ba) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* packageselectionpage: add missing methodJoshua Lock2012-04-121-0/+4
| | | | | | | | | | | | This is just a copy of the same method from the recipeselectionpage so that we can actually run hob again. Fixes [YOCTO #2281] (Bitbake rev: b6e68019494044305ab28492a517d1eafea851c3) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* builder: fix missing \ for if continuationSaul Wold2012-04-121-1/+1
| | | | | | | (Bitbake rev: f44f12b812d246da994519bc39789bf2dcfbac4b) Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* hig/builder: use the new which_terminal() functionSaul Wold2012-04-112-7/+12
| | | | | | | | | | Also adjusted the cmdline ordering to work correctly with both xterm and vte. (Bitbake rev: 4219e2ea033232d95117211947b751bdb5efafd4) Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/crumbs/utils.py: new file for choosing terminalsSaul Wold2012-04-111-0/+33
| | | | | | | | | | | | Adding this simple version of a terminal selector for use hob since it's needed. Moving forward in the 1.3 release the existing code in meta/lib/oe/termnial.py will be migrated to core bitbake code and this will use that code. (Bitbake rev: 359a9ea4c8d61247064db3eaefb816ef116d332a) Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob:Fixed some incorrect values of Build configuration tabLiming An2012-04-112-15/+19
| | | | | | | | | | | | | Because some variables not be updated when building started, so add them to the updating function of configuration class, and add reset function of configurate treeview of building detail page [YOCTO #2244] (Bitbake rev: 06ce753fd4680a204ccc63949ace637dc1c115e2) Signed-off-by: Liming An <limingx.l.an@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: show those appliable buttons on the image details page onlyShane Wang2012-04-111-38/+84
| | | | | | | | | | | | We don't use "grayed out" but use "show/hide" for those appliable buttons in the image details page. [Yocto #2143] (Bitbake rev: df1564d78d081ceab51d628d227e57b7a197259b) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: forget selected_recipes and selected_packages after users change the ↵Shane Wang2012-04-112-3/+24
| | | | | | | | | | | | | | | | | | | | | | machine The patch is to fix [Yocto #2255]. Now the logic is: - If users change the machine, the image combo is empty for users to select. - If users load the template, the image combo should set the value of selected_image specified in the template. - After loading a template, if users change the machine, the selected_image specified in the template should be removed from the image combo because it is probably invalid for a new machine. - If users customize the recipe/package list, and change the settings which causes reparsing, selected_recipes and selected_packages should be remembered. - If users add more layers, selected_recipes and selected_packages should be remembered. (Bitbake rev: e549b11f4f31863393f62a253ee96bead4594523) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: add tooltips into image details screenShane Wang2012-04-111-5/+11
| | | | | | | | | [Yocto #2243] (Bitbake rev: 543e81b87b48de9c5285b81c856376c9f52d7902) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: tooltip change for "Build image" buttonShane Wang2012-04-111-1/+1
| | | | | | | | | [Yocto #2242] (Bitbake rev: a36bd8ddf62397c554dadb97841532e260b01b91) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: clean up and reword stop_parse()Shane Wang2012-04-112-4/+4
| | | | | | | (Bitbake rev: f6e0d93c96d1626e7da298e296b1be9e425173b2) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: clean up generate_configuration()Shane Wang2012-04-111-1/+4
| | | | | | | (Bitbake rev: 569d5ac3a3e89c7a8d69ec611b69edbae414b5fe) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: clean up cancel_build()Shane Wang2012-04-111-2/+5
| | | | | | | (Bitbake rev: ef441d51700f73577e72c106ee2a0ecd4eceda08) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: clean up request_package_info_async()Shane Wang2012-04-112-2/+5
| | | | | | | (Bitbake rev: e95b52820f26a7a35865e8978ea752053dccd4b1) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: clean up and unify get_parameters() to be get_parameters_sync()Shane Wang2012-04-111-3/+6
| | | | | | | (Bitbake rev: 16fecd0d0f95285bf774030cd24006206185faee) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: clean up to call clear_busy() in hobeventhandler.pyShane Wang2012-04-112-1/+1
| | | | | | | (Bitbake rev: 7b6414e2b82666c3cfa5432ce8fe8c348b227441) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: clean up and unify the steps for IMAGE_GENERATING to call ↵Shane Wang2012-04-111-16/+16
| | | | | | | | | | | | generate_image_async() For the steps in IMAGE_GENERATING, the patch consolidates them into generate_image_async() to call. (Bitbake rev: d4f2335e40d4d667847d3faed79bcee74baeea37) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: clean up and unify the steps for PACKAGE_GENERATING and ↵Shane Wang2012-04-111-11/+19
| | | | | | | | | | | | | | | FAST_IMAGE_GENERATING to call generate_packages_async() and fast_generate_image_async() For the steps in PACKAGE_GENERATING, the patch consolidates them into generate_packages_async() to call. For the steps in FAST_IMAGE_GENERATING, the patch also consolidates them into fast_generate_image_async() to call. (Bitbake rev: 1ec53d41774528ab01e835d1cf4166f0202a7c38) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>