summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* profile-manual: Fixed bad title.Scott Rifenbark2014-07-031-1/+1
| | | | | | | (From yocto-docs rev: 256b8b8644c179ccb40a64b234dc1844e3a92b33) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* dev-manual: Fixed a mult-line <ulink> cross-referenceScott Rifenbark2014-07-031-2/+1
| | | | | | | | | | | These types of references cannot span multiple lines. If they do then mega-manual.sed will not process the link in the mega-manual.html file. (From yocto-docs rev: 8a06542c0f1fee503eda12052adddaaf9c94ca91) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* mega-manual.sed: Added line to process profile-manual.Scott Rifenbark2014-07-031-0/+1
| | | | | | | | | | This line was left out for links with no target. The line is now in there. (From yocto-docs rev: 5a27a32261628b7d4f60981cfe624f08d8cf1535) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* groff: Fix build on Fedora 17 for 1.18.1.4Ming Liu2014-07-031-0/+8
| | | | | | | | | | | | | The commit 79fc5576: [ groff: Fix build on Fedora 17 ] was applied to 1.22.2, but it's also needed by 1.18.1.4 to solve a same issue. (From OE-Core rev: b019f2cdacfb64f149483df8a5b6b7b3f7943222) Signed-off-by: Ming Liu <ming.liu@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* gawk: fix optional dependency mpfrRoxana Ciobanu2014-07-031-0/+2
| | | | | | | | | | | | | Gawk was failing to compile because of the optional feature mpfr if it found libmpfr on build host and linked against that or mpfr existed in sysroot but not in deploy, or if gawk was pulled from sstate and someone had mpfr built. [YOCTO# 6473] (From OE-Core rev: ec0def7cc204f402fba017264ea201956add342d) Signed-off-by: Roxana Ciobanu <roxana.ciobanu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* groff: remove redundant code snippetMing Liu2014-07-031-8/+0
| | | | | | | | | | | | The exact same code snippet exists both in do_install_append and do_install_append_class-native which is not necessary. Remove it from do_install_append_class-native. (From OE-Core rev: 0f107a76713cebb49004d48fd410d9f014dda4b3) Signed-off-by: Ming Liu <ming.liu@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* python3: fix builtins importsRoxana2014-06-301-1/+3
| | | | | | | | | | | | | | | | | The intent of this code is to generate things like -L=/usr/lib/foo so for paths which start with "/" we should appent the "=". We should not do this for ".". On some recent versions of binutils or patchsets on some recent distros this appears to work differently and causes build failures, for example on Ubuntu 14.04 LTS. The simple fix is to check for "." as the path prefix. [YOCTO #6467]. (From OE-Core rev: c36d459f0d40bdbd3ba809835e0475e8992bc778) Signed-off-by: Roxana <roxana.ciobanu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* adt_installer: Fix sed file not found errorRichard Purdie2014-06-301-1/+1
| | | | | | | | | | | | | | We need to look for the installed file within the sysroot we just installed so add in the missing prefix. This avoids errors like: Installing cross canadian packages for qemux86 ... sed: no input files [YOCTO #6443] (From OE-Core rev: 3042dcaecadee266b1e4dcae102030c7e4802b89) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* oeqa/selftest/_toaster.py: fix 'IndentationError' issuesIonut Chisanovici2014-06-301-280/+280
| | | | | | | | | | There were some indentation errors when the _toaster.py was merged into master. This patch fix those errors. (From OE-Core rev: 173194493294574e49874858ee7003000f41b4d6) Signed-off-by: Ionut Chisanovici <ionutx.chisanovici@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* oeqa/selftest/toaster.py: renamed to _toaster.pyIonut Chisanovici2014-06-301-0/+0
| | | | | | | | | In order not to run the toaster selftests by default, we renamed to _toaster.py (From OE-Core rev: 8da2ebba10e0128938919b39c29be40b7c1d80aa) Signed-off-by: Ionut Chisanovici <ionutx.chisanovici@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Revert "libusb: add missing build dependency on udev"Richard Purdie2014-06-291-2/+0
| | | | | | | | | | This reverts commit 6cebce6e355c4c7a87f4088bfa849d0a1c3439da. Leads to build failures as nativesdk-udev doesn't exist (nor should it). It also leads to circular dependencies and build failures from these. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* classes/kernel: Use full path for symlink in update-alternatives.Drew Moseley2014-06-291-1/+1
| | | | | | | | | | | | Use a fully qualified path for the <path> parameter in calls to update-alternatives. The chkconfig-alternatives version requires a full path and without it, the symlink is not properly created. (From OE-Core rev: 78ee4d8b1782445caecce8331e68efe83fc32044) Signed-off-by: Drew Moseley <drew_moseley@mentor.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* populate_sdk_base: Remove confusing echoRichard Purdie2014-06-291-2/+0
| | | | | | | | | | | Remove a confusing echo after the previous commit, thanks for a suggestion from Laurentiu. (From OE-Core rev: cd1fdd05cc7457706d1e40042854c154cbb3d9e9) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> A
* populate_sdk_base: add auto-completion in setupDennis Meier2014-06-291-2/+1
| | | | | | | (From OE-Core rev: d6c55f6910270e395f668c9114ec374b44c57538) Signed-off-by: Dennis Meier <meier.dennis@siemens.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* classes/report-error: tweak summary messagePaul Eggleton2014-06-291-2/+2
| | | | | | | | | | | | * We don't want everyone to remove their identifying info, just if they feel the need to * Split lines for clarity * A couple of grammar/spelling tweaks (From OE-Core rev: b5c7538416e4c7a9e594edf930fa7ee844a347e6) Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* libusb: add missing build dependency on udevFabien Chereau2014-06-291-0/+2
| | | | | | | | | This fixes the ./configure error in case libusb is built before udev/systemd. (From OE-Core rev: 6cebce6e355c4c7a87f4088bfa849d0a1c3439da) Signed-off-by: Fabien Chereau <fabien.chereau@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* test-dependencies.sh: Return non-zero return code when there was some ↵Martin Jansa2014-06-291-13/+39
| | | | | | | | | | | | | | | | failure detected * this is useful when using from jenkins job where you don't want to read output just to dectect how bad it was * add .log suffix to all files, so they can be easily downloaded from http servers without default mimetype set to something useful * add recipes failed in step 1 to steps 2 and 3 to generate standalone logs for them (From OE-Core rev: cef1d6deb5437edae56740436d8e77b8d941945a) Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* sstate-diff-machines.sh: Return non-zero return code when there was some ↵Martin Jansa2014-06-291-10/+75
| | | | | | | | | | | | | | failure detected * add --analyze option, which is useful when using from jenkins job where you don't want to read output just to dectect how bad it was * I was always using something like this inside jenkins job, but better to share it in original script (From OE-Core rev: e73e1261879d9154d89cec35669ba22b499d8331) Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* patch.bbclass: unset TMPDIR after useRoss Burton2014-06-291-0/+1
| | | | | | | | | | | | | | | GNU Patch < 2.6.1 has a race condition so we create a per-instance TMPDIR to avoid this. This was implemented by setting os.environ[TMPDIR] but at the end of do_patch the temporary directory is deleted but TMPDIR is not unset. In general this doesn't cause a problem but if do_patch is embedded in a larger function then TMPDIR is set to a directory that doesn't exist. Avoid this by removing TMPDIR from os.environ when the directory is deleted. (From OE-Core rev: 51ea4378864f1468df2ca282a84f78a17d6861aa) Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* recipes-devtools: fix segfault in lib32-gcc with "." multilib_dirPaul Gortmaker2014-06-292-0/+67
| | | | | | | | | | | | | | | | | | When enabling a lib32-gcc in a 64 bit build, without doing any other configuration, the mutilib dir is unspecified, which is represented internally in gcc as "." and as such uncovers an invalid free on a non-malloc'd pointer. As suggested by the gcc folks, simply make sure the "." case is also stored in a malloc'd pointer, so that the intended runtime behaviour of the code remains unchanged. Patch has been accepted by upstream maintainers of gcc. (From OE-Core rev: bf1473d0c1b099b8d919835cc430b99606134aab) Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* initrdscripts: Try to boot if boot label is unknownDrew Moseley2014-06-291-0/+4
| | | | | | | | | | | | | The init-live.sh scripts assumes that the boot label set by the LABELS variable is either "boot", "install", or "install-efi". If that variable is overridden to something else we fall off the end of the case statement and the system locks up. If the boot label is unknown, at least attempt to boot. (From OE-Core rev: 98353862c08be2f1724aaad7aa4ed0521e3621f2) Signed-off-by: Drew Moseley <drew_moseley@mentor.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* distutils/distutils3: Fix bashismRichard Purdie2014-06-292-9/+3
| | | | | | | | | | | | | read -d is a bashism. Replace with a direct exec to avoid the problem in this case. This fixes silent build failures in do_install of tasks on systems with dash as /bin/sh. Also merge the fix to distutils for only changing necessary files to disutils3 as well. (From OE-Core rev: 7d61661348cf48cbe379ae600565840ea08664b1) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* u-boot-fw-utils: install config fileMaxin B. John2014-06-251-0/+2
| | | | | | | | | | The on-target fw_printenv and fw_setenv needs configuration file (fw_env.config) to be present in the target. (From OE-Core rev: b4cd268cf7506a521d7800112cb775bd49e1ef09) Signed-off-by: Maxin B. John <maxin.john@enea.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* createrepo: RDEPENDS on libxml2-pythonRobert Yang2014-06-251-0/+1
| | | | | | | | | | | | | | Fixed the error when run createrepo on target: Traceback (most recent call last): File "/usr/share/createrepo/genpkgmetadata.py", line 27, in <module> import libxml2 File "/usr/lib64/python2.7/site-packages/libxml2.py", line 1, in <module> ImportError: No module named libxml2mod (From OE-Core rev: 3ec0f411985cf6891b34e1f9624df9df38c9fc6f) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* sudo: upgrade from 1.8.10p2 to 1.8.10p3Chen Qi2014-06-251-2/+2
| | | | | | | | | | | Upgrade sudo from 1.8.10p2 to 1.8.10p3. [YOCTO #6457] (From OE-Core rev: acd711f7faa98990f32b11f6235e739723ec2743) Signed-off-by: Chen Qi <Qi.Chen@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* initramfs-framework: get rid of udev-utilsChen Qi2014-06-251-1/+1
| | | | | | | | | | | Now that udev-utils package has been removed and 'udevadm' has been moved to udev package, the initramfs-framework should also get rid of the udev-utils package. (From OE-Core rev: f0b8f08e13f395820172d16c9d4c016a0fbdbfe9) Signed-off-by: Chen Qi <Qi.Chen@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* systemd: remove udev-utils, move 'udevadm' to udev packageChen Qi2014-06-251-6/+3
| | | | | | | | | | | | | | | The udev package RDEPENDS on the udev-utils package, and the actually udev-utils package relies on the udev package because if there's no udev daemon, 'udevadm' command doesn't make much sense. Now that we have removed udev-utils package and moved 'udevadm' to the udev package in the older udev recipe, we should do the same for systemd. (From OE-Core rev: 393867e8818b54255271bb70bcd7b6ffea137c0a) Signed-off-by: Chen Qi <Qi.Chen@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* udev: remove udev-utils, add 'udevadm' to udev packageChen Qi2014-06-251-5/+3
| | | | | | | | | | | | | | | | | | Previously, the udev package only RRECOMMENDS udev-utils package, but its init script in the udev package really relies on the 'udevadm' command to work properly. As a result, if 'NO_RECOMMENDATIONS' is set to '1', errors occur at system start-up. The udev-utils package only contains one file, that is /bin/udevadm. So it's better that we remove the udev-utils package and move the 'udevadm' command to the udev package. [YOCTO #6388] (From OE-Core rev: 4814a7a85ccff74923a554bdc11820fceff84e2e) Signed-off-by: Chen Qi <Qi.Chen@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* udev-cache.default: set PROBE_PLATFORM_BUS to "yes" by defaultDenys Dmytriyenko2014-06-251-0/+1
| | | | | | | | | Force probing of "platform" bus by default. (From OE-Core rev: 6aae37c66fb6e7153b829ad860b7e7f94e804bd4) Signed-off-by: Denys Dmytriyenko <denys@ti.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* udev: update init script for conditional probing of platform busDenys Dmytriyenko2014-06-251-1/+6
| | | | | | | | | | | | | | | | | Make probing of "platform" bus conditional based on PROBE_PLATFORM_BUS variable from /etc/default/udev-cache on subsequent boots when udev cache is used. PROBE_PLATFORM_BUS has to be set to "yes" in order to force probing on every boot, otherwise it uses the old default behaviour of probing it just the first time. This is helpful on modern SoCs where most of the low level peripheral drivers are registered on the platform bus and need to be probed to load the necessary modules and enable the connected buses and subsystems. (From OE-Core rev: 70a695735e0a7d14448f2f5a9986bfe105210a91) Signed-off-by: Denys Dmytriyenko <denys@ti.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* own-mirrors: Add gitsm:// mirror supportRichard Purdie2014-06-251-0/+1
| | | | | | (From OE-Core rev: 2abc6923956a3ebf8c0a00122ce605b8ec10ceb7) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* gtk-doc: Add pkgconfig inheritRichard Purdie2014-06-251-0/+2
| | | | | | | | | Anything using gtk-doc will be using pkgconfig as well so add in the dependency rather than doing it for each and every recipe. (From OE-Core rev: 7ee05554c55607d9aa02f9a93762e2024bcd4bb0) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* libsdl: Convert to use pkg-config in internal m4 macrosRichard Purdie2014-06-252-0/+188
| | | | | | | | | Rather than code which doesn't even work properly when cross compiling, lets just use pkg-config instead. Its a little simpler. (From OE-Core rev: b550572bdad318aed02230496721430eec89c937) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* gst-openmax: Add missing pkgconfig inheritRichard Purdie2014-06-251-1/+1
| | | | | | (From OE-Core rev: 0f11090e566ae13fe76c4273655db320a87ba7ae) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* lib/oe/package_manager.py: Add processing for alternative SDK_OSMark Hatle2014-06-251-1/+5
| | | | | | | | | | For the meta-mingw layer, we need to process alternative SDK_OS, since this is not a Linux based OS. (From OE-Core rev: b31e015d2e379c24610948d345c5970545887468) Signed-off-by: Mark Hatle <mark.hatle@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* gcc-cross-canadian: Add configure-target-libgccMark Hatle2014-06-251-3/+10
| | | | | | | | | | | | While we're not going to package the libgcc component as part of the SDK, we do need to generate it to get the unwind, and quadmath headers. Without this change it is not possible to build eglibc or other components that require these headers with the SDK toolchain. (From OE-Core rev: e67b24401a366b20644510703c7140be975869ea) Signed-off-by: Mark Hatle <mark.hatle@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* populate_sdk: Fix TOOLCHAIN_TARGET_TASK_ATTEMPTONLY implementationMark Hatle2014-06-252-1/+2
| | | | | | | | | | The variable was only partially implemented, and the part that was there was named incorrectly to, missing the 'TASK' piece. (From OE-Core rev: d0cb34cfe9a51fd8bc1e6e28c8eda60a25adc1ec) Signed-off-by: Mark Hatle <mark.hatle@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* classes/package_rpm.bbclass: Fix SDK Suffix referenceMark Hatle2014-06-251-1/+2
| | | | | | | | | | | | | The meta-mingw layer attempts to change the SDK Suffix, but the rpm packaging had a hard coded reference to _nativesdk. I did a quick scan for other hard coded entries and did not fine any more. (From OE-Core rev: 0d3f7a753f17fa8c455f64e3df3259ef1887fd8a) Signed-off-by: Mark Hatle <mark.hatle@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* curl: Convert CURLGNUTL to PACKAGECONFIGSaul Wold2014-06-251-11/+7
| | | | | | | | | | | This will allow for easier configuration of curl for SSL vs gnutls [YOCTO #6329] (From OE-Core rev: 6a8144390eb2dee6e1baf7be75cffcacbb247002) Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ca-certificates: Update to 20140325Saul Wold2014-06-252-3/+233
| | | | | | | | | | | | | | Changes to debian/copyright: Update to "Copyright: Mozilla Contributors" for mozilla/{certdata.txt,nssckbi.h} Backported on additional patch from ca-certificates tree [YOCTO #6454] (From OE-Core rev: 3af33d60f03afb19543247b5350137ff3a7ee7e0) Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* mobile-broadband-provider-info: Update SRCREVSaul Wold2014-06-251-2/+2
| | | | | | | (From OE-Core rev: 684c9c8261494e3b66e37052c487c4449d8f9b01) Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* man-pages: Update to 3.69Saul Wold2014-06-251-2/+2
| | | | | | | (From OE-Core rev: 4fe42df0b384383c57d9bf16d0a725778b3477ad) Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* xcb-util-renderutil: Update to version 0.3.9Saul Wold2014-06-252-13/+10
| | | | | | | | | | Updated LIC_FILES_CHKSUM to focus only on header section no license changes (From OE-Core rev: 2832cb12b31f171e06b9bdd4e496682813301baf) Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* curl: Update to 7.37Saul Wold2014-06-252-42/+2
| | | | | | | | | Remove patches that are fixed upstream (From OE-Core rev: d5d169af2b34596deb3997c2bfa7398c447c4fac) Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* gnupg: Update to 2.0.23Saul Wold2014-06-251-2/+2
| | | | | | | (From OE-Core rev: ea397e7060fcb92b0b31c3de7c498c0df3f55ac4) Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* liburcu: Update to 0.8.4Saul Wold2014-06-252-22/+3
| | | | | | | | | Removed patch fixed upstream (From OE-Core rev: 08a136e6fd9b598fc11787752b1a0a5c53e898ec) Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* libusb1: Update to 1.0.19Saul Wold2014-06-251-2/+2
| | | | | | | (From OE-Core rev: 94368a16636b05dc21db564a0a55e0a705fbfa29) Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* sqlite3: Update to 3.8.5.0Saul Wold2014-06-251-2/+2
| | | | | | | (From OE-Core rev: 6b3ac5de53417f130f5335b88aa78f1bd655c4e0) Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* u-boot: Optionally deploy an environment or script fileAsh Charles2014-06-251-0/+25
| | | | | | | | | | | | | | | | Some boards are configured to read a script or environment file as part of the u-boot boot sequence. This file, typically called 'uEnv.txt' or 'boot.scr', would be deployed alongside the u-boot binary. If a recipe uses this u-boot.inc, such a file can be deployed by setting the optional UBOOT_ENV parameter and including the file in the SRC_URI. For example: SRC_URI_append_overo = "file://uEnv.txt" UBOOT_ENV_overo = "uEnv" (From OE-Core rev: 1506c40c93651356b9fe2f7184b5e26f99e22686) Signed-off-by: Ash Charles <ashcharles@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* cmake.bbclass: restore OECMAKE_SOURCEPATHRoss Burton2014-06-251-3/+6
| | | | | | | | | | | | | | | Some packages put their CMakeLists.txt file in a subdirectory, so assuming that it is in ${S} won't work. Restore OECMAKE_SOURCEPATH (defaulting to ${S}) so that the location of CMakeLists.txt can be set if required. Based on a patch by Miroslav Keš <miroslav.kes@gmail.com> (From OE-Core rev: 2c23d7ab913a636aa0ab6a6e899cf6211d1e2714) Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>