summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* pybootchartgui: Correct the legendPeter Kjellerstedt2014-01-231-1/+1
| | | | | | | (From OE-Core rev: 1ca2e1a2ae3dc4d1e62a9daf25df588ec27a195a) Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pybootchartgui: Make the -s option work againPeter Kjellerstedt2014-01-231-4/+5
| | | | | | | | | [YOCTO #5588] (From OE-Core rev: 8245ceab3acd02618f24665ff5dc203c1e5cce1d) Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* libtool: remove the unrecognized configure optionChen Qi2014-01-231-2/+0
| | | | | | | | | | Remove the unrecognized configure option '--with-sysroot' to avoid build time warnings. (From OE-Core rev: 6f6a10372b6a318be7695b6b50275a8a3e9ed033) Signed-off-by: Chen Qi <Qi.Chen@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* cmake.bbclass: fix note when warning about deprecated variablesRoss Burton2014-01-221-1/+1
| | | | | | | | | | | The note issues when OECMAKE_BUILDPATH and OECMAKE_SOURCEPATH were being used stated that an in-tree build would be done, but the default is in fact an out-of-tree build. (From OE-Core rev: 0dafb9f78e9ab9ec1a1483efc37902c2e8de3623) Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* adt_installer: do not install rootfs if target is not selectedLaurentiu Palcu2014-01-223-15/+15
| | | | | | | | | | | | | | | | | | | | | | Currently, if YOCTOADT_TARGETS does not contain an architecture but the rootfs/machine settings are uncommented, then the rootfs is installed and adt will throw an error because is not able to find the toolchain environment script. This patch will: * not allow to install a target rootfs if the toolchain for the target architecture is not selected; * uncomment the target rootfs/machine settings for the other architectures since it's easier for the user to just add a new architecture in YOCTOADT_TARGETS and have the target rootfs installed; [YOCTO #5727] (From OE-Core rev: 22351d27de76b39cb71904396e73497e36d9e1d6) Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* lib/oeqa: sshcontrol: fix false timeout failuresStefan Stanacar2014-01-221-2/+2
| | | | | | | | | | | | | Ocasionally AB shows odd false fails like: http://autobuilder.yoctoproject.org/main/builders/nightly-arm/builds/1/steps/Running%20Sanity%20Tests/logs/stdio This should fix that by checking for eof instead of polling the return code of the ssh process, because the process might still be there. (From OE-Core rev: 3a22b5df5aa38a98b35bc2931d646a2b7702fbec) Signed-off-by: Stefan Stanacar <stefanx.stanacar@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* gdk-pixbuf: use PACKAGECONFIG to control loaders with external dependenciesRoss Burton2014-01-221-8/+11
| | | | | | | (From OE-Core rev: aaa3644a75a7698604102b3b68d40b4dcc02df1d) Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* gdk-pixbuf: don't forcibly disable GIO sniffing, use PACKAGECONFIG.Ross Burton2014-01-222-22/+3
| | | | | | | | | | | There's a configure option for GIO sniffing so don't use a patch to disable it. Instead use a PACKAGECONFIG for this and default to off, as using GIO for sniffing means a hard dependency on shared-mime-info. (From OE-Core rev: 624e79deb58c08bcc32053e792df140f527d20b1) Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* gdk-pixbuf: upgrade to 2.30.3Ross Burton2014-01-221-2/+2
| | | | | | | (From OE-Core rev: 992c054c0656efce50d3902b3f0b101ab9ea602a) Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* libxcb: upgrade to 1.10Ross Burton2014-01-223-14/+10
| | | | | | | | | | Remove spurious libxcb-xinerama addition to PACKAGES, this is handled by the dynamic split_packages() now. (From OE-Core rev: cfb0b1124d38c332536abb5d3e2726a3b8993140) Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* xcb-proto: upgrade to 1.10Ross Burton2014-01-221-2/+2
| | | | | | | (From OE-Core rev: d31d1a3e6cfada74bfe5e288e6af2de409fb7a6a) Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* glproto: upgrade to 1.4.17Ross Burton2014-01-221-2/+2
| | | | | | | (From OE-Core rev: aad0b0495ebdc3d0757ea664daa4053f91a8dbe4) Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* poky.ent: Fixed broken OE_LISTS_URL.Scott Rifenbark2014-01-211-1/+1
| | | | | | | | | | | This variable was wrong and it was causing six mailing links in the manual set to no resolve. Who knows how long they have been broken. They work now. (From yocto-docs rev: 8af811fff06fca799bcead538a5dfece9ddbc5ce) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* dev-manual: Updated the section that describes finding source code.Scott Rifenbark2014-01-211-43/+31
| | | | | | | | | | I changed the description to match that which is used in the WORKDIR variable. (From yocto-docs rev: 7d9071c2bb99e7c3f3eeae9ddf0abc34563c6725) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ref-manual: Updated the TCMODE variable.Scott Rifenbark2014-01-211-0/+12
| | | | | | | | | | | | | Fixes [YOCTO #4942] Added a note to the variable description stating that if the user does not set TCMODE to "default", it is up to them to verify that components are compatible with the toolchain. (From yocto-docs rev: e67d7635c1d749e65aaef0d4cc6576a3ee312ddd) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ref-manual: Updated the nativesdk class to have correct class.Scott Rifenbark2014-01-211-1/+1
| | | | | | | (From yocto-docs rev: 8e0a3c236f746caa6263038380144957039feabe) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ref-manual: Updated native and nativesdk classes.Scott Rifenbark2014-01-211-0/+6
| | | | | | | | | Added a bit about needing to place the inherit statement last. (From yocto-docs rev: 204e15035a9a116002b7f645e4edb378979c89f6) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ref-manual: Small wording change to WORKDIR variable description.Scott Rifenbark2014-01-211-2/+2
| | | | | | | (From yocto-docs rev: 83fe607b25d3fa0867ba4d06838ad800b74bc349) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ref-manual: Updated the WORKDIR variable description.Scott Rifenbark2014-01-211-42/+36
| | | | | | | | | | | Removed the machine-dependent and machine-independent descriptions. Created matching description from the "Writing a New Recipe" section. (From yocto-docs rev: 89a00beb81be60668abfdd67b13f5ee5bdc7ea1c) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* dev-manual: Another small fix to the EXTENDPE definition.Scott Rifenbark2014-01-211-2/+2
| | | | | | | | | | Better wording as it is described in the "Writing a New Recipe" section. (From yocto-docs rev: 88b039ccd0aa825220de091ea7225ada3d212553) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* dev-manual: Small fix to EXTENDPE definition in "Writing a New Recipe"Scott Rifenbark2014-01-211-3/+4
| | | | | | | (From yocto-docs rev: 1d020cd87e5b843622422db79f09b564da526376) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* dev-manual: Review edits to "Writing a New Recipe" section.Scott Rifenbark2014-01-211-8/+15
| | | | | | | | | | Final review comments from Paul Eggleton implemented here. This should be it for the new section. (From yocto-docs rev: 5307b471c73f46103e0a031172df3174c1880806) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* dev-manual: Added review comments to "Writing a New Recipe" section.Scott Rifenbark2014-01-211-8/+19
| | | | | | | | | These changes are Paul Eggleton's fourth review change. (From yocto-docs rev: 8470c1b516f7799148b4e2eae28534730e93b58b) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* poky.ent: Updated lists.linuxtogo.org with lists.openembedded.orgScott Rifenbark2014-01-211-1/+1
| | | | | | | (From yocto-docs rev: cb3521dbe3a2bc7b7369f09e92838f528be061b7) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* mega-manual, dev-manual: Updated the recipe flow figure.Scott Rifenbark2014-01-212-0/+0
| | | | | | | (From yocto-docs rev: 746eacaf4256c2b28182ca69f4d393025f854a68) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* dev-manual: Minor re-wording to introduce recipe flow diagram.Scott Rifenbark2014-01-211-1/+1
| | | | | | | (From yocto-docs rev: e8f169a3547cff5da0e4811f706f2cef5eb3be4d) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* dev-manual: Edits to the "Writing a New Recipe" section.Scott Rifenbark2014-01-211-37/+38
| | | | | | | | | | Completed applying the revision comments from Paul Eggleton for the third revision of this new section. (From yocto-docs rev: d641aa6318cb87e9d41dda39cc4747c44888aa4d) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ref-manual: Fixed cross-reference anchor name.Scott Rifenbark2014-01-211-1/+1
| | | | | | | (From yocto-docs rev: 06f429d986c02a1b4d7b324e34c2434da0e9e9af) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ref-manual: Fixed cross-reference anchor name.Scott Rifenbark2014-01-211-1/+1
| | | | | | | (From yocto-docs rev: 15c124c85e95e070c959ab110511ddd70acbb71f) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* dev-manual: Edits to the "Writing a New Recipe" section.Scott Rifenbark2014-01-211-117/+89
| | | | | | | | | Implemented some third review feedback from Paul Eggleton. (From yocto-docs rev: 3fd9c3cc4cf2aba876f0ad2ab36660ec32ea4c08) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ref-manual: Added note about curly brace parsing to BitBake chapter.Scott Rifenbark2014-01-211-0/+40
| | | | | | | (From yocto-docs rev: 91f199552f0012f1790dbac4d038eac101f2a274) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ref-manual: Edits to TCLIBC variable.Scott Rifenbark2014-01-211-3/+3
| | | | | | | | | Some minor changes. (From yocto-docs rev: e545ee26e7e6c827c5ee6d7061f01eda58c9c82b) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* dev-manual: Edits to "Examples" and "Post-Installation" sections.Scott Rifenbark2014-01-211-85/+87
| | | | | | | | | | | | | Applied review comments to these sections, which are part of the "Writing a New Recipe" section. Moved the Post-installation section out of the examples area into its own, higher-level section as it was not really an example. Other edits were direct result of Paul Eggleton's review. (From yocto-docs rev: c147a8bedf79d0be42d7b338e10b7e42d7c0b080) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* dev-manual: Edits to "Testing" section.Scott Rifenbark2014-01-211-2/+0
| | | | | | | | | | | Applied review comments from Paul Eggleton to this section, which is a part of the "Writing a New Recipe" section. Very minor fix to remove a sentence that was somewhat isolated and unecessary. (From yocto-docs rev: fd2a0eac1bc4b9e6af0bc8ce9a30802dbea35873) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* dev-manual: Edits to "Packaging" section.Scott Rifenbark2014-01-211-2/+3
| | | | | | | | | | | | | Applied some self-edits to this section that is part of the "Writing a New Recipe" section. There was no feedback from the second review but I noticed a few issues. Also, I added that reference on how to add a post-installation script from the "Enabling System Services" section as noted by Paul Eggleton. (From yocto-docs rev: 6be835637cb1dc232d6d6dd1dfe1bc803efecfd3) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* dev-manual: Edits to "Enabling System Services" section.Scott Rifenbark2014-01-211-20/+24
| | | | | | | | | | | | Applied review comments from Paul Eggleton to the section that is part of the "Writing a New Recipe" section. I changed the title of the section and applied some rewordings to better reprepresent exactly what sysvinit and systemd really are (managers). (From yocto-docs rev: 95c3ed5b7d1ace08828baacc8401e1ea5d96a06e) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* dev-manual: Edits to "Installing" section.Scott Rifenbark2014-01-211-8/+17
| | | | | | | | | | Applied review comments from Paul Eggleton to this section that is part of the new "Writing a New Recipe" section. Minor edits. (From yocto-docs rev: a5116900ca42377c3dc19433b2f6046828ad2dcc) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* dev-manual: Edits to "Compilation" section.Scott Rifenbark2014-01-211-4/+22
| | | | | | | | | | | | Added review comments to the section inside the new "Writing a New Recipe" section. Minor word fixes. I did add a new common compilation failure scenario. All input from Paul Eggleton. (From yocto-docs rev: 5818a8882ff55fc27c5dc77233854465b8c2245b) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* dev-manual: Edits to "Configuring the Recipe" section.Scott Rifenbark2014-01-211-14/+18
| | | | | | | | | | | Applied review edits from Paul Eggleton for this section that is part of the "Writing a New Recipe" section. Minor wording issues only. (From yocto-docs rev: 8e291826fcb9547c3fc16aa81ccf6867fe2e417d) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* dev-manual: Edits to the "Licensing" section.Scott Rifenbark2014-01-211-6/+5
| | | | | | | | | | Applied review comments to this section per Paul Eggleton. Minor word changes. (From yocto-docs rev: 5130559003778e3b613d3d480350d041dfd10fcd) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ref-manual: Edits to the SPDXLICENSEMAP variable.Scott Rifenbark2014-01-211-1/+2
| | | | | | | | | Fixed wording to reference default mappings. (From yocto-docs rev: 4ceddbe8454f473907e5ae469102f3a43d20122c) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* dev-manual: Edits to "Unpacking Code" section.Scott Rifenbark2014-01-211-7/+10
| | | | | | | | | Applied review comments to this section. (From yocto-docs rev: f4075f61ca081df6c87abd876207da968450a8f3) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* dev-manual: Edits to "Fetching Code" section.Scott Rifenbark2014-01-211-91/+101
| | | | | | | | | | | | | | | Applied review comments to this section. Specifically, I addressed the organization and got rid of the bullet list. I integrated this information into the examples used for the various SRC_URI snippits. Also, part of the feedback including separating out the patching information into an isolated section. I set up the section and moved minimal information into it. (From yocto-docs rev: 0a16977c2125402cdd04e24ad5bce074859eb28a) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* dev-manual: Edits to "Running a Build on the Recipe"Scott Rifenbark2014-01-211-25/+24
| | | | | | | | | | Corrective edits to this section based on Paul's feedback. Several items addressed. (From yocto-docs rev: a09ebe38e0ad22ad4ab12eab3d5a73166e4c56f8) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* dev-manual: Edits to "Storing and Naming the Recipe"Scott Rifenbark2014-01-211-41/+39
| | | | | | | | | | | Re-ordered this such that the storage of the recipe comes first and that is followed by naming it. Also, formatted into a list to give a better sense of the suggested order. (From yocto-docs rev: aead82f034a097cbdfe38b3b1f09a60cc411d6ea) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* dev-manual: Edits to "Locate a Base Recipe" section.Scott Rifenbark2014-01-211-6/+7
| | | | | | | | | | Updated the introductory paragraph to be more general about where a user might locate an existing recipe as a base. (From yocto-docs rev: d6147d19785824cde29e82aa32916dcec5ae2276) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* dev-manual: Edits to "Locate a Base Recipe" section.Scott Rifenbark2014-01-211-7/+12
| | | | | | | | | | | | I removed the note structure for the information about BitBake parcing curly braces. The note was to prominent. I added a leading sentence to better integrate the information into the section. (From yocto-docs rev: 21dd7ceced2c9867e4fefc2aab81a4ab3da3bc7d) Signed-off-by: Scott Rifenbark <scott.m.rifenbark@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* poky.conf: Remove Debian Squeeze from SANITY_TESTED_DISTROSOlof Johansson2014-01-211-1/+0
| | | | | | | | | | Debian Squeeze is not a supported platform, since the bitbake python dependency on Python was bumped to 2.7. (From meta-yocto rev: d18666aebe2d1889dcf45dc0fda491970cb77433) Signed-off-by: Olof Johansson <olof.johansson@axis.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* poky.conf: add Debian 7.3 to SANITY_TESTED_DISTROSOlof Johansson2014-01-211-0/+1
| | | | | | | | | | 7.3 is a point release with security and bug fixes only, and I can confirm that it works. (From meta-yocto rev: baf65c002f6bc2ecf6c61a8ec5f1ad8b994b033d) Signed-off-by: Olof Johansson <olof.johansson@axis.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* sstate.bbclass: remove previous version's stampRobert Yang2014-01-211-9/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There is a potential problem if we don't remove the previous version's stamp, for example: The depend chain is: libtool-native -> autoconf-native -> m4-native We have two m4-native: 1.4.9 and 1.4.7 1) Clean all of them to make a fresh build so that we can reproduce the problem $ bitbake m4-native autoconf-native libtool-native -ccleansstate 2) Build libtool-native so that the m4-native_1.4.17 will be built $ bitbake libtool-native 3) Set PREFERRED_VERSION_m4-native = "1.4.9" and build again $ bitbake libtool-native 4) Set PREFERRED_VERSION_m4-native = "1.4.17" and build again $ bitbake libtool-native -ccleansstate && bitbake libtool-native Then the build will fail: [snip] | m4: unrecognized option '--gnu' | Try `m4 --help' for more information. | autom4te: m4 failed with exit status: 1 [snip] The is because when we change m4-native to 1.4.17 and build libtool-native again: 5) libtool-native depends on autoconf-native, and autoconf-native's version isn't change, so it can remove the current stamp and mirror the sstate (the one depends on m4-native_1.4.9) from the SSTATE_DIR correctly. 6) The mirrored autoconf-native depends on m4-native_1.4.17's do_populate_sysroot, and the stamp is already there (which is made by step 2), so it would do nothing, but this is incorrect, since the one that really in the sysroot is m4-native_1.4.9, then the error happens. Remove previous version's stamp in sstate_clean() will fix the problem. [YOCTO #5422] (From OE-Core rev: 4659d29b1040349116549644e45035a5b37d9311) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>