summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* bc: dc: fix exit code of q commandLi Zhou2019-07-022-1/+46
| | | | | | | | | | | | | | | | | | | | The exit code for "echo q | dc" is 1 for dc-1.4.1; while the exit code for "echo q | dc" is 0 for dc-1.4. Here is the answer from ken@gnu.org: dc-1.4 was right. There was a rewrite of a chunk of code for 1.4.1 to fix a corner case in the Q command, and somehow the placement of the clean-up label for the 'q' command got misplaced on the error-handling branch instead of the clean-exit branch. The patch below fixes this (it is committed for whenever the next bc/dc release gets made). Thanks for the report, --Ken Pizzini (From OE-Core rev: ab16d9ccaf824fbda5e43c5b3cbdc43ec70be87f) Signed-off-by: Li Zhou <li.zhou@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* bison: update to 3.4.1Oleksandr Kravchuk2019-07-021-2/+2
| | | | | | | (From OE-Core rev: b97a5a37262a8d7ce45ae75d861e87dfe28fe0df) Signed-off-by: Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Revert "pigz: Add debug for autobuilder errors"Richard Purdie2019-06-303-192/+2
| | | | | | This reverts commit b08976456c8ab7f29efd83644ce42746c0d6501b. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* package: Build pkgdata specific to the current recipeRichard Purdie2019-06-303-14/+173
| | | | | | | | | | | | | | | | | | | | | | | | | | This switches the code to build pkgdata specific to the current recipe which means that its filtered to the recipes dependencies and can perform better as we can drop the lockfile. It uses a similar method to the staging code to do this, using BB_TASKDEPDATA to construct a list of packagedata task output which this recipe should "see". The original pkgdata store is left unaltered so existing code works. The lock file was there to prevent files disappearing as they were read or as directories were listed. Since we have a copy of the data and only access output from completed tasks (as per their manifests), we can remove the lock. The lock was causing starvation issues on systems with parallelism. There was also a potential determinism problem as the current code could "see" data from recipes which it doesn't depend upon. [YOCTO #13412] (From OE-Core rev: 1951132576bfb95675b4879287f8b3b7c47524fa) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* staging: Code cleanupRichard Purdie2019-06-301-7/+0
| | | | | | | | | multiconfig dependencies no longer appear in BB_TASKDEPDATA so we can drop this code. (From OE-Core rev: 288b04c8a31fcf257219a57e23663b74178c75f2) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* mobile-broadband-provider-info: upgrade 20190116 -> 20190618Alexander Kanavin2019-06-301-2/+4
| | | | | | | | | The new version is using xsltproc utility (From OE-Core rev: a8c370a9ff2c6f7d7d516ef69cc2c4c8b8279f61) Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* gtk-doc: correct the style.css permissionsAlexander Kanavin2019-06-303-1/+25
| | | | | | | | | | | style.css was set to write-only during build which means it wasn't actually installed or packaged (with only webkitgtk producing a build failure!), which in turn means generated documentation was broken. (From OE-Core rev: 946516f5312edaa62fd20162d8c7596f77e9ca64) Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* rt-tests: exclude 1.4 version from upstream check as wellAlexander Kanavin2019-06-301-2/+2
| | | | | | | (From OE-Core rev: 4769f94a2cc493cdf77b9e6a41a2e9b6a9c8f52f) Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* libsolf: update to 0.7.5Oleksandr Kravchuk2019-06-302-190/+1
| | | | | | | | | Removed patch was upstreamed. (From OE-Core rev: 60fb828e581c5e109f19625b05f5bf7363f5c70d) Signed-off-by: Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* expat: update to 2.2.7Oleksandr Kravchuk2019-06-302-28/+2
| | | | | | | | | Removed patch is not appropriate anymore. (From OE-Core rev: 485db07c099845ec106cf555065676efef61030f) Signed-off-by: Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* libinput: update to 1.13.4Oleksandr Kravchuk2019-06-301-2/+2
| | | | | | | (From OE-Core rev: 0e71fea258ffa53a4d7a693d7cac4a0e9f8b5ee7) Signed-off-by: Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* apt: update to 1.2.31Oleksandr Kravchuk2019-06-303-2/+2
| | | | | | | (From OE-Core rev: b414b95a0e0fc5b5e1403272eaaf59e0bec6da06) Signed-off-by: Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* dpkg: update to 1.19.7Oleksandr Kravchuk2019-06-302-12/+12
| | | | | | | (From OE-Core rev: 4b312777a2e154a6d86311981299bc16f23f053c) Signed-off-by: Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* babeltrace: update to 1.5.7Oleksandr Kravchuk2019-06-301-1/+1
| | | | | | | (From OE-Core rev: 2743f3ae192f84be6b216e5d33928e123e82007d) Signed-off-by: Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* glibc: Fix multilibs + usrmerge buildsJason Wessel2019-06-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The build of glibc fails when you have multilibs enabled + the distro feature usrmerge. Here is an example configuration: === MACHINE = "qemux86-64" VIRTUAL-RUNTIME_init_manager = "systemd" DISTRO_FEATURES_append = " systemd " DISTRO_FEATURES_append += " usrmerge" require conf/multilib.conf MULTILIBS = "multilib:lib32" DEFAULTTUNE_virtclass-multilib-lib32 = "x86" === This will fail with the following error: NOTE: Executing SetScene Tasks NOTE: Executing RunQueue Tasks ERROR: glibc-2.28-r0 do_poststash_install_cleanup: Function failed: do_poststash_install_cleanup (log file is located at /poky/build/tmp/work/core2-64-poky-linux/glibc/2.28-r0/temp/log.do_poststash_install_cleanup.107893) ERROR: Logfile of failure stored in: /poky/build/tmp/work/core2-64-poky-linux/glibc/2.28-r0/temp/log.do_poststash_install_cleanup.107893 The fix is to not perform the rmdir check when using the multilib + usr/merge, namely: if [ "${libdir}" != "${exec_prefix}/lib" ] && [ "${root_prefix}/lib" != "${exec_prefix}/lib" ]; then This will evaluate as follows (collecting the output from bitbake -e glibc) * no multilibs no usrmerge if [ "/usr/lib" != "/usr/lib" ] && [ "/lib" != "/usr/lib" ]; then * no multilibs yes usrmerge if [ "/usr/lib" != "/usr/lib" ] && [ "/usr/lib" != "/usr/lib" ]; then * yes multilibs no usrmerge if [ "/usr/lib64" != "/usr/lib" ] && [ "/lib" != "/usr/lib" ]; then * yes multilibs yes user merge if [ "/usr/lib64" != "/usr/lib" ] && [ "/usr/lib" != "/usr/lib" ]; then (From OE-Core rev: c5640f8c8663c8f81125bf7c5bc2ef8e9fe55315) Signed-off-by: Jason Wessel <jason.wessel@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pigz: Add debug for autobuilder errorsRichard Purdie2019-06-303-2/+192
| | | | | | (From OE-Core rev: b08976456c8ab7f29efd83644ce42746c0d6501b) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* package_rpm.bbclass: python2 -> python3Robert Yang2019-06-301-1/+1
| | | | | | | (From OE-Core rev: 8208fffc95b46e03bab967462c17d83e0a687d50) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* oeqa: Cleanup /usr/bin/env pythonRobert Yang2019-06-302-2/+0
| | | | | | | (From OE-Core rev: eb79217b8761816a21c8f7bed3c5379c1b9230ea) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ext-sdk-prepare.py: python2 -> python3Robert Yang2019-06-301-1/+1
| | | | | | | | | This script is python3 indeed. (From OE-Core rev: 62443240d01ba4b696a8dbab9e60774a84662cdd) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* wic: python2 -> python3Robert Yang2019-06-303-3/+3
| | | | | | | (From OE-Core rev: 9303f92599343adf645fee5d2434fadd97e7febb) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ksum.py: python -> python3Robert Yang2019-06-301-22/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | * Testinfo: In kernel's builddir: $ /path/to/oe-core/scripts/tiny/ksum.py Collecting object files [DONE] Totals: vmlinux: text data bss total 10933110 3824470 1605632 16363212 modules (2004): text data bss total 46144408 3047516 167580 49359504 vmlinux + modules: text data bss total 57077518 6871986 1773212 65722716 (From OE-Core rev: a55955f337b4cebf557f96f5dd7c2edc0bfa6d8a) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* bitbake: bitbake: toaster:tests: python -> python3Robert Yang2019-06-2830-30/+30
| | | | | | (Bitbake rev: 683c24788d96176699a585055eb62d8a71830a12) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* bitbake: bitbake: lib: Cleanup /usr/bin/env pythonRobert Yang2019-06-2811-12/+1
| | | | | | | (Bitbake rev: cc712f3257904960247a7532cfc4611f3dccd36c) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* bitbake: tests/fetch.py: add missing skipIfNoNetwork tags to tests that try ↵Luca Boccassi2019-06-281-0/+5
| | | | | | | | | | | | | to git clone test_git_submodule_dbus_broker, test_git_submodule_CLI11, test_git_submodule_update_CLI11, test_git_submodule_aktualizr and test_git_submodule_iotedge try to access the network via git clone, which fails when there is no network available. Add the relevant skip tag. (Bitbake rev: 9b0538753da0514e6518723dac537007abf7a649) Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* python3: Fix .pyc file reproduciblilityJoshua Watt2019-06-282-0/+36
| | | | | | | | | | Applies a patch to python that makes the pre-compiled .pyc files generated during the build reproducible. (From OE-Core rev: 148d54f91f43147f31b16a7c2cb1ade385832366) Signed-off-by: Joshua Watt <JPEWhacker@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* eudev: update to 3.2.8Oleksandr Kravchuk2019-06-281-2/+2
| | | | | | | (From OE-Core rev: e2ae59520e3df661aced4f67fda630cca6aaf6f8) Signed-off-by: Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* git: update to 2.22.0Oleksandr Kravchuk2019-06-282-11/+11
| | | | | | | (From OE-Core rev: 7e4d2d2792b70edf4d0a6c2e3d5278d9138c8709) Signed-off-by: Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* python3-pygobject: update to 3.32.2Oleksandr Kravchuk2019-06-281-3/+3
| | | | | | | (From OE-Core rev: 26b7298d2f34b5a20cf22b449ce362987b2b52f9) Signed-off-by: Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* python3-pbr: update to 5.3.1Oleksandr Kravchuk2019-06-282-5/+5
| | | | | | | (From OE-Core rev: 9bb4c8b5b0f0bec15fa80f1d3e55a34ee13c08bb) Signed-off-by: Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* python3-mako: update to 1.0.12Oleksandr Kravchuk2019-06-282-3/+3
| | | | | | | | | License checksum changed due to madified copyright year. (From OE-Core rev: 9225797184c877dd22aa5f96503a182a548303ff) Signed-off-by: Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* autoconf-archive: update to 2019.01.06Oleksandr Kravchuk2019-06-281-2/+2
| | | | | | | (From OE-Core rev: 5ef547b9ba4f7a2836dea43013a450c7ca13e6e8) Signed-off-by: Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* libxt: update to 1.2.0Oleksandr Kravchuk2019-06-283-42/+16
| | | | | | | | | | | License checksum changed due to modified copyright year. Removed patch was upstreamed. (From OE-Core rev: 4a77ac273cb16167fff8fcb9831434d9a25f8fcf) Signed-off-by: Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* libxi: update to 1.7.10Oleksandr Kravchuk2019-06-281-3/+2
| | | | | | | (From OE-Core rev: d5290687f261e1f4ee35b8c27b2d886fe09b88d8) Signed-off-by: Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* libinput: update to 1.13.3Oleksandr Kravchuk2019-06-281-2/+2
| | | | | | | (From OE-Core rev: e4c316699b3937d92d97991aad4f64e9f6f8c132) Signed-off-by: Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* gawk: update to 5.0.1Oleksandr Kravchuk2019-06-281-2/+2
| | | | | | | (From OE-Core rev: 34dd24a00adbce5f10b56028af29db96b2910bb6) Signed-off-by: Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* cve-update-db: do_populate_cve_db depends on do_fetchPierre Le Magourou2019-06-281-8/+13
| | | | | | | | | | | | | | | To be able to populate NVD database on a fetchall (bitbake <image> --run-all=fetch), set the do_populate_cve_db task to be executed before do_fetch. Do not get CVE_CHECK_DB_DIR, CVE_CHECK_DB_FILE and CVE_CHECK_TMP_FILE variable because do_populate_cve_db can be called in a context where cve-check class is not loaded. (From OE-Core rev: 975793e3825a2a9ca6dc0e43577f680214cb7993) Signed-off-by: Pierre Le Magourou <pierre.lemagourou@softbankrobotics.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* encodings: update to 1.0.5Oleksandr Kravchuk2019-06-282-10/+18
| | | | | | | (From OE-Core rev: f65013af8e556b8e56001fae147aac890fb1836c) Signed-off-by: Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* buildhistory: report sysroot changesRoss Burton2019-06-281-1/+10
| | | | | | | | | Now that the sysroot is written into the build history, write it out. (From OE-Core rev: e9df98ba63e6d2baefee550170dbdd11ed2ad03a) Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* buildhistory: write the contents of the sysrootRoss Burton2019-06-281-1/+9
| | | | | | | | | | Changes to the sysroot are just as interesting during development, so write the file listing for the sysroot to buildhistory too. (From OE-Core rev: b3ac82a27ab70ed6996fe3087a578ac637820329) Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ltp: fix shmctl01 failure when executed.Hongzhi.Song2019-06-282-0/+82
| | | | | | | | | | | | | schmctl01 fails with following error: [shmctl01 5 TFAIL : shmctl01.c:171: shmctl01 call failed - errno = 22 : Invalid argument] Backport the patch from upstream can fix it. (From OE-Core rev: 337e6923375e7cf568a66b299b6c3461f33a903c) Signed-off-by: Hongzhi.Song <hongzhi.song@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* glib-2.0: Update to 2.60.4Peter Kjellerstedt2019-06-282-65/+2
| | | | | | | | | | | * For changes, see: https://gitlab.gnome.org/GNOME/glib/blob/glib-2-60/NEWS * Remove backported CVE-2019-12450.patch. (From OE-Core rev: 82714d374744d55f57d48fd08971e8b952a7bcdd) Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* devtool: warn user about multiple layer having the same base nameChen Qi2019-06-281-4/+18
| | | | | | | | | | | | | | | | | | | Currently `devtool finish RECIPE meta' will silently succeed even if there are multiple layers having the same base name of 'meta'. e.g. meta layer from oe-core and meta layer from meta-secure-core. We should at least give user a warning in such case. With the patch, we will get warning like below. WARNING: Multiple layers have the same base name 'meta', use the first one '<PROJ_DIR>/oe-core/meta'. WARNING: Consider using path instead of base name to specify layer: <PROJ_DIR>/oe-core/meta <PROJ_DIR>/meta-secure-core/meta (From OE-Core rev: 2c8740f543c38dbaef3345e40827ef48b3f75405) Signed-off-by: Chen Qi <Qi.Chen@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* package.bbclass: fix directories setuid and setgid bitsJoël Esponde2019-06-281-1/+2
| | | | | | | | | | | | | | | populate_packages relies on ``mkdir`` to both create a directory and set its permissions. However, ``mkdir`` honors the ``umask`` value. Therefore, some bits may be lost in the operation. In our case, the setgid bit on the directories were lost. This commit fixes this by having a distinct call to create the directory and to set the permissions. (From OE-Core rev: 0f82b53a650e76e0129fae6ce7581a41d042315b) Signed-off-by: Jean-Tiare Le Bigot <jean-tiare.le-bigot@easymile.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* busybox: Fix typo in syslog initscriptRichard Purdie2019-06-271-1/+1
| | | | | | | | | The change to ensure the existing processes shut down had a clear copy and paste error. This really fixes syslog to avoid errors on restart. (From OE-Core rev: 9f674a88c781c7092d5b3460922a1579b9fe4bf9) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* oeqa/runtime/syslog: Add delay to test to avoid failuresRichard Purdie2019-06-271-0/+3
| | | | | | | | | | | On a loaded builder we've seen the log message not make it to the log file before the ssh command completes. Add a short delay to try and ensure this does happen. There is unforunately no way to flush syslog in all cases we test. (From OE-Core rev: 66322b689e46520647e2d94d5e3f3ce282a41247) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* oeqa/runtime/oesyslog: systemd syslog restart doesn't change pidRichard Purdie2019-06-271-2/+5
| | | | | | | | | The systemd-journald process doesn't restart/change the way syslog does, don't test/error in this case. (From OE-Core rev: be48190dca0643df4881624d29c2eae453395919) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* oeqa/runtime/syslog: Improve test debug messagesRichard Purdie2019-06-271-12/+20
| | | | | | | | | | | | Its useful to test whether the restart command returned an error code and exit early from the test if so. Also add different messages to tell if the syslog processes didn't die or didn't restart. (From OE-Core rev: f19e95b8571a0d8213c4dec0da056e3d243fbbd1) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* busybox: Improve syslog restart handlingRichard Purdie2019-06-271-1/+21
| | | | | | | | | | | | We're seeing races on the autobuilder where syslogd fails to shut down fast enough to be restarted leading to failures. Add some checks to ensure when restarting that processes exit before being restarted. (From OE-Core rev: 04de384256ad321834cf5e3dbb9a8d3ea2ab66c2) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* sysklogd: Fix init script racesRichard Purdie2019-06-271-0/+22
| | | | | | | | | | | | | | In testing we're seeing sysklogd fail to restart klogd since the original process hasn't stopped before the new one is started. This means a restart can result in no process running which is clearly not desireable. Add extra code to ensure this works correctly. Busybox start-stop-daemon seems particularly open to this kind of issue, the dpkg version maybe less so if timeout options are used (which we don't use). (From OE-Core rev: dc1fcb61f7d89cd066ace2edc143e7a2d329e033) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* oe_syslog.py: Handle syslogd/klogd restart raceJon Mason2019-06-271-9/+59
| | | | | | | | | | | | | | | | syslogd and klogd can occasionally take too long to restart, which causes tests to fail by starting before the log daemons are ready. To work around this problem, poll for up to 30 seconds on the processes to verify the old ones are killed and the new ones are up and running. Similarly, add checks for rsyslogd and systemd-journald to possibly catch issues with those daemons. [YOCTO #13379] (From OE-Core rev: dc73872b828ea271678fa624c15199364a5cba9e) Signed-off-by: Jon Mason <jdmason@kudzu.us> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>