summaryrefslogtreecommitdiffstats
path: root/meta/recipes-support/libcap/files/CVE-2023-2603.patch
diff options
context:
space:
mode:
Diffstat (limited to 'meta/recipes-support/libcap/files/CVE-2023-2603.patch')
-rw-r--r--meta/recipes-support/libcap/files/CVE-2023-2603.patch58
1 files changed, 58 insertions, 0 deletions
diff --git a/meta/recipes-support/libcap/files/CVE-2023-2603.patch b/meta/recipes-support/libcap/files/CVE-2023-2603.patch
new file mode 100644
index 0000000000..cf86ac2a46
--- /dev/null
+++ b/meta/recipes-support/libcap/files/CVE-2023-2603.patch
@@ -0,0 +1,58 @@
1Backport of:
2
3From 422bec25ae4a1ab03fd4d6f728695ed279173b18 Mon Sep 17 00:00:00 2001
4From: "Andrew G. Morgan" <morgan@kernel.org>
5Date: Wed, 3 May 2023 19:44:22 -0700
6Subject: Large strings can confuse libcap's internal strdup code.
7
8Avoid something subtle with really long strings: 1073741823 should
9be enough for anybody. This is an improved fix over something attempted
10in libcap-2.55 to address some static analysis findings.
11
12Reviewing the library, cap_proc_root() and cap_launcher_set_chroot()
13are the only two calls where the library is potentially exposed to a
14user controlled string input.
15
16Credit for finding this bug in libcap goes to Richard Weinberger of
17X41 D-Sec GmbH (https://x41-dsec.de/) who performed a security audit
18of the libcap source code in April of 2023. The audit was sponsored
19by the Open Source Technology Improvement Fund (https://ostif.org/).
20
21Audit ref: LCAP-CR-23-02 (CVE-2023-2603)
22
23Signed-off-by: Andrew G. Morgan <morgan@kernel.org>
24
25Upstream-Status: Backport [import from ubuntu https://git.launchpad.net/ubuntu/+source/libcap2/tree/debian/patches/CVE-2023-2603.patch?h=ubuntu/focal-security
26Upstream commit https://git.kernel.org/pub/scm/libs/libcap/libcap.git/commit/?id=422bec25ae4a1ab03fd4d6f728695ed279173b18]
27CVE: CVE-2023-2603
28Signed-off-by: Vijay Anusuri <vanusuri@mvista.com>
29---
30 libcap/cap_alloc.c | 12 +++++++-----
31 1 file changed, 7 insertions(+), 5 deletions(-)
32
33--- a/libcap/cap_alloc.c
34+++ b/libcap/cap_alloc.c
35@@ -76,13 +76,22 @@ cap_t cap_init(void)
36 char *_libcap_strdup(const char *old)
37 {
38 __u32 *raw_data;
39+ size_t len;
40
41 if (old == NULL) {
42 errno = EINVAL;
43 return NULL;
44 }
45
46- raw_data = malloc( sizeof(__u32) + strlen(old) + 1 );
47+ len = strlen(old);
48+ if ((len & 0x3fffffff) != len) {
49+ _cap_debug("len is too long for libcap to manage");
50+ errno = EINVAL;
51+ return NULL;
52+ }
53+ len += sizeof(__u32) + 1;
54+
55+ raw_data = malloc(len);
56 if (raw_data == NULL) {
57 errno = ENOMEM;
58 return NULL;