summaryrefslogtreecommitdiffstats
path: root/meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-Add-checks-for-invalid-pointers-to-fix-seg.patch
diff options
context:
space:
mode:
Diffstat (limited to 'meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-Add-checks-for-invalid-pointers-to-fix-seg.patch')
-rw-r--r--meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-Add-checks-for-invalid-pointers-to-fix-seg.patch61
1 files changed, 61 insertions, 0 deletions
diff --git a/meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-Add-checks-for-invalid-pointers-to-fix-seg.patch b/meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-Add-checks-for-invalid-pointers-to-fix-seg.patch
new file mode 100644
index 0000000000..8fdeedb008
--- /dev/null
+++ b/meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-Add-checks-for-invalid-pointers-to-fix-seg.patch
@@ -0,0 +1,61 @@
1From a6e259b2cd43db3c0f69441f627a8cf214f88506 Mon Sep 17 00:00:00 2001
2From: Mark Asselstine <mark.asselstine@windriver.com>
3Date: Thu, 5 Apr 2012 15:19:44 -0400
4Subject: [PATCH] trace-cmd: Add checks for invalid pointers to fix segfaults
5
6Upstream-Status: Backport
7
8Running 'trace-cmd report' after running latency tracers will cause a
9segfault due to invalid pointers. Adding checks to ensure
10pointers/lists are initialized before attempting to use them prevents
11these segfaults.
12
13Link: http://lkml.kernel.org/r/1333653586-3379-2-git-send-email-mark.asselstine@windriver.com
14
15Signed-off-by: Mark Asselstine <mark.asselstine@windriver.com>
16Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
17---
18 trace-input.c | 12 +++++++++---
19 1 file changed, 9 insertions(+), 3 deletions(-)
20
21diff --git a/trace-input.c b/trace-input.c
22index b6af1e6..5151c1e 100644
23--- a/trace-input.c
24+++ b/trace-input.c
25@@ -695,7 +695,8 @@ static void __free_page(struct tracecmd_input *handle, struct page *page)
26
27 static void free_page(struct tracecmd_input *handle, int cpu)
28 {
29- if (!handle->cpu_data[cpu].page)
30+ if (!handle->cpu_data || cpu >= handle->cpus ||
31+ !handle->cpu_data[cpu].page)
32 return;
33
34 __free_page(handle, handle->cpu_data[cpu].page);
35@@ -746,8 +747,12 @@ void tracecmd_record_ref(struct record *record)
36
37 static void free_next(struct tracecmd_input *handle, int cpu)
38 {
39- struct record *record = handle->cpu_data[cpu].next;
40+ struct record *record;
41+
42+ if (!handle->cpu_data || cpu >= handle->cpus)
43+ return;
44
45+ record = handle->cpu_data[cpu].next;
46 if (!record)
47 return;
48
49@@ -2337,7 +2342,8 @@ void tracecmd_close(struct tracecmd_input *handle)
50 /* The tracecmd_peek_data may have cached a record */
51 free_next(handle, cpu);
52 free_page(handle, cpu);
53- if (!list_empty(&handle->cpu_data[cpu].pages))
54+ if (handle->cpu_data &&
55+ !list_empty(&handle->cpu_data[cpu].pages))
56 warning("pages still allocated on cpu %d%s",
57 cpu, show_records(&handle->cpu_data[cpu].pages));
58 }
59--
601.7.10.4
61