summaryrefslogtreecommitdiffstats
path: root/meta/recipes-kernel/lttng/lttng-modules/0005-fix-block-add-a-disk_uevent-helper-v5.12.patch
diff options
context:
space:
mode:
Diffstat (limited to 'meta/recipes-kernel/lttng/lttng-modules/0005-fix-block-add-a-disk_uevent-helper-v5.12.patch')
-rw-r--r--meta/recipes-kernel/lttng/lttng-modules/0005-fix-block-add-a-disk_uevent-helper-v5.12.patch305
1 files changed, 305 insertions, 0 deletions
diff --git a/meta/recipes-kernel/lttng/lttng-modules/0005-fix-block-add-a-disk_uevent-helper-v5.12.patch b/meta/recipes-kernel/lttng/lttng-modules/0005-fix-block-add-a-disk_uevent-helper-v5.12.patch
new file mode 100644
index 0000000000..3a2280ccdc
--- /dev/null
+++ b/meta/recipes-kernel/lttng/lttng-modules/0005-fix-block-add-a-disk_uevent-helper-v5.12.patch
@@ -0,0 +1,305 @@
1From 17cd2dc91cb82ed342b0da699f2b1a70c1bf6a03 Mon Sep 17 00:00:00 2001
2From: Michael Jeanson <mjeanson@efficios.com>
3Date: Mon, 15 Mar 2021 14:54:02 -0400
4Subject: [PATCH 2/4] fix: block: add a disk_uevent helper (v5.12)
5
6See upstream commit:
7
8 commit bc359d03c7ec1bf3b86d03bafaf6bbb21e6414fd
9 Author: Christoph Hellwig <hch@lst.de>
10 Date: Sun Jan 24 11:02:39 2021 +0100
11
12 block: add a disk_uevent helper
13
14 Add a helper to call kobject_uevent for the disk and all partitions, and
15 unexport the disk_part_iter_* helpers that are now only used in the core
16 block code.
17
18Upstream-status: Backport [2.12.6]
19
20Change-Id: If6e8797049642ab382d5699660ee1dd734e92c90
21Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
22Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
23---
24 Makefile | 1 +
25 lttng-statedump-impl.c | 34 +++++++++----
26 src/wrapper/genhd.c | 111 +++++++++++++++++++++++++++++++++++++++++
27 wrapper/genhd.h | 62 +++++++++++++++++++++++
28 4 files changed, 198 insertions(+), 10 deletions(-)
29 create mode 100644 src/wrapper/genhd.c
30
31diff --git a/Makefile b/Makefile
32index a9aff3f1..34043cfb 100644
33--- a/Makefile
34+++ b/Makefile
35@@ -80,6 +80,7 @@ ifneq ($(KERNELRELEASE),)
36 wrapper/kallsyms.o \
37 wrapper/irqdesc.o \
38 wrapper/fdtable.o \
39+ wrapper/genhd.o \
40 lttng-wrapper-impl.o
41
42 ifneq ($(CONFIG_HAVE_SYSCALL_TRACEPOINTS),)
43diff --git a/lttng-statedump-impl.c b/lttng-statedump-impl.c
44index 60b937c9..5511c7e8 100644
45--- a/lttng-statedump-impl.c
46+++ b/lttng-statedump-impl.c
47@@ -250,13 +250,17 @@ int lttng_enumerate_block_devices(struct lttng_session *session)
48 struct device_type *ptr_disk_type;
49 struct class_dev_iter iter;
50 struct device *dev;
51+ int ret = 0;
52
53 ptr_block_class = wrapper_get_block_class();
54- if (!ptr_block_class)
55- return -ENOSYS;
56+ if (!ptr_block_class) {
57+ ret = -ENOSYS;
58+ goto end;
59+ }
60 ptr_disk_type = wrapper_get_disk_type();
61 if (!ptr_disk_type) {
62- return -ENOSYS;
63+ ret = -ENOSYS;
64+ goto end;
65 }
66 class_dev_iter_init(&iter, ptr_block_class, NULL, ptr_disk_type);
67 while ((dev = class_dev_iter_next(&iter))) {
68@@ -272,22 +276,32 @@ int lttng_enumerate_block_devices(struct lttng_session *session)
69 (disk->flags & GENHD_FL_SUPPRESS_PARTITION_INFO))
70 continue;
71
72- disk_part_iter_init(&piter, disk, DISK_PITER_INCL_PART0);
73- while ((part = disk_part_iter_next(&piter))) {
74+ /*
75+ * The original 'disk_part_iter_init' returns void, but our
76+ * wrapper can fail to lookup the original symbol.
77+ */
78+ if (wrapper_disk_part_iter_init(&piter, disk, DISK_PITER_INCL_PART0) < 0) {
79+ ret = -ENOSYS;
80+ goto iter_exit;
81+ }
82+
83+ while ((part = wrapper_disk_part_iter_next(&piter))) {
84 char name_buf[BDEVNAME_SIZE];
85
86 if (lttng_get_part_name(disk, part, name_buf) == -ENOSYS) {
87- disk_part_iter_exit(&piter);
88- class_dev_iter_exit(&iter);
89- return -ENOSYS;
90+ wrapper_disk_part_iter_exit(&piter);
91+ ret = -ENOSYS;
92+ goto iter_exit;
93 }
94 trace_lttng_statedump_block_device(session,
95 lttng_get_part_devt(part), name_buf);
96 }
97- disk_part_iter_exit(&piter);
98+ wrapper_disk_part_iter_exit(&piter);
99 }
100+iter_exit:
101 class_dev_iter_exit(&iter);
102- return 0;
103+end:
104+ return ret;
105 }
106
107 #ifdef CONFIG_INET
108diff --git a/src/wrapper/genhd.c b/src/wrapper/genhd.c
109new file mode 100644
110index 00000000..a5a6c410
111--- /dev/null
112+++ b/src/wrapper/genhd.c
113@@ -0,0 +1,111 @@
114+/* SPDX-License-Identifier: (GPL-2.0-only OR LGPL-2.1-only)
115+ *
116+ * wrapper/genhd.c
117+ *
118+ * Wrapper around disk_part_iter_(init|next|exit). Using KALLSYMS to get the
119+ * addresses when available, else we need to have a kernel that exports this
120+ * function to GPL modules. This export was removed in 5.12.
121+ *
122+ * Copyright (C) 2021 Michael Jeanson <mjeanson@efficios.com>
123+ */
124+
125+#include <lttng/kernel-version.h>
126+#include <linux/module.h>
127+#include <wrapper/genhd.h>
128+
129+#if (defined(CONFIG_KALLSYMS) && \
130+ (LTTNG_LINUX_VERSION_CODE >= LTTNG_KERNEL_VERSION(5,12,0)))
131+
132+#include <wrapper/kallsyms.h>
133+
134+static
135+void (*disk_part_iter_init_sym)(struct disk_part_iter *piter, struct gendisk *disk,
136+ unsigned int flags);
137+
138+static
139+LTTNG_DISK_PART_TYPE *(*disk_part_iter_next_sym)(struct disk_part_iter *piter);
140+
141+static
142+void (*disk_part_iter_exit_sym)(struct disk_part_iter *piter);
143+
144+/*
145+ * This wrapper has an 'int' return type instead of the original 'void', to be
146+ * able to report the symbol lookup failure to the caller.
147+ *
148+ * Return 0 on success, -1 on error.
149+ */
150+int wrapper_disk_part_iter_init(struct disk_part_iter *piter, struct gendisk *disk,
151+ unsigned int flags)
152+{
153+ if (!disk_part_iter_init_sym)
154+ disk_part_iter_init_sym = (void *) kallsyms_lookup_funcptr("disk_part_iter_init");
155+
156+ if (disk_part_iter_init_sym) {
157+ disk_part_iter_init_sym(piter, disk, flags);
158+ } else {
159+ printk_once(KERN_WARNING "LTTng: disk_part_iter_init symbol lookup failed.\n");
160+ return -1;
161+ }
162+ return 0;
163+}
164+EXPORT_SYMBOL_GPL(wrapper_disk_part_iter_init);
165+
166+LTTNG_DISK_PART_TYPE *wrapper_disk_part_iter_next(struct disk_part_iter *piter)
167+{
168+ if (!disk_part_iter_next_sym)
169+ disk_part_iter_next_sym = (void *) kallsyms_lookup_funcptr("disk_part_iter_next");
170+
171+ if (disk_part_iter_next_sym) {
172+ return disk_part_iter_next_sym(piter);
173+ } else {
174+ printk_once(KERN_WARNING "LTTng: disk_part_iter_next symbol lookup failed.\n");
175+ return NULL;
176+ }
177+}
178+EXPORT_SYMBOL_GPL(wrapper_disk_part_iter_next);
179+
180+/*
181+ * We don't return an error on symbol lookup failure here because there is
182+ * nothing the caller can do to cleanup the iterator.
183+ */
184+void wrapper_disk_part_iter_exit(struct disk_part_iter *piter)
185+{
186+ if (!disk_part_iter_exit_sym)
187+ disk_part_iter_exit_sym = (void *) kallsyms_lookup_funcptr("disk_part_iter_exit");
188+
189+ if (disk_part_iter_exit_sym) {
190+ disk_part_iter_exit_sym(piter);
191+ } else {
192+ printk_once(KERN_WARNING "LTTng: disk_part_iter_exit symbol lookup failed.\n");
193+ }
194+}
195+EXPORT_SYMBOL_GPL(wrapper_disk_part_iter_exit);
196+
197+#else
198+
199+/*
200+ * This wrapper has an 'int' return type instead of the original 'void', so the
201+ * kallsyms variant can report the symbol lookup failure to the caller.
202+ *
203+ * This variant always succeeds and returns 0.
204+ */
205+int wrapper_disk_part_iter_init(struct disk_part_iter *piter, struct gendisk *disk,
206+ unsigned int flags)
207+{
208+ disk_part_iter_init(piter, disk, flags);
209+ return 0;
210+}
211+EXPORT_SYMBOL_GPL(wrapper_disk_part_iter_init);
212+
213+LTTNG_DISK_PART_TYPE *wrapper_disk_part_iter_next(struct disk_part_iter *piter)
214+{
215+ return disk_part_iter_next(piter);
216+}
217+EXPORT_SYMBOL_GPL(wrapper_disk_part_iter_next);
218+
219+void wrapper_disk_part_iter_exit(struct disk_part_iter *piter)
220+{
221+ disk_part_iter_exit(piter);
222+}
223+EXPORT_SYMBOL_GPL(wrapper_disk_part_iter_exit);
224+#endif
225diff --git a/wrapper/genhd.h b/wrapper/genhd.h
226index 98feb57b..6bae239d 100644
227--- a/wrapper/genhd.h
228+++ b/wrapper/genhd.h
229@@ -13,6 +13,13 @@
230 #define _LTTNG_WRAPPER_GENHD_H
231
232 #include <linux/genhd.h>
233+#include <lttng/kernel-version.h>
234+
235+#if (LTTNG_LINUX_VERSION_CODE >= LTTNG_KERNEL_VERSION(5,11,0))
236+#define LTTNG_DISK_PART_TYPE struct block_device
237+#else
238+#define LTTNG_DISK_PART_TYPE struct hd_struct
239+#endif
240
241 #ifdef CONFIG_KALLSYMS_ALL
242
243@@ -94,4 +101,59 @@ struct device_type *wrapper_get_disk_type(void)
244
245 #endif
246
247+/*
248+ * This wrapper has an 'int' return type instead of the original 'void', to be
249+ * able to report the symbol lookup failure to the caller.
250+ *
251+ * Return 0 on success, -1 on error.
252+ */
253+int wrapper_disk_part_iter_init(struct disk_part_iter *piter, struct gendisk *disk,
254+ unsigned int flags);
255+LTTNG_DISK_PART_TYPE *wrapper_disk_part_iter_next(struct disk_part_iter *piter);
256+void wrapper_disk_part_iter_exit(struct disk_part_iter *piter);
257+
258+/*
259+ * Canary function to check for 'disk_part_iter_init()' at compile time.
260+ *
261+ * From 'include/linux/genhd.h':
262+ *
263+ * extern void disk_part_iter_init(struct disk_part_iter *piter,
264+ * struct gendisk *disk, unsigned int flags);
265+ *
266+ */
267+static inline
268+void __canary__disk_part_iter_init(struct disk_part_iter *piter, struct gendisk *disk,
269+ unsigned int flags)
270+{
271+ disk_part_iter_init(piter, disk, flags);
272+}
273+
274+/*
275+ * Canary function to check for 'disk_part_iter_next()' at compile time.
276+ *
277+ * From 'include/linux/genhd.h':
278+ *
279+ * struct block_device *disk_part_iter_next(struct disk_part_iter *piter);
280+ *
281+ */
282+static inline
283+LTTNG_DISK_PART_TYPE *__canary__disk_part_iter_next(struct disk_part_iter *piter)
284+{
285+ return disk_part_iter_next(piter);
286+}
287+
288+/*
289+ * Canary function to check for 'disk_part_iter_exit()' at compile time.
290+ *
291+ * From 'include/linux/genhd.h':
292+ *
293+ * extern void disk_part_iter_exit(struct disk_part_iter *piter);
294+ *
295+ */
296+static inline
297+void __canary__disk_part_iter_exit(struct disk_part_iter *piter)
298+{
299+ return disk_part_iter_exit(piter);
300+}
301+
302 #endif /* _LTTNG_WRAPPER_GENHD_H */
303--
3042.25.1
305
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-05-18 13:25:45 +0000