diff options
Diffstat (limited to 'meta/recipes-gnome/epiphany/files/CVE-2022-29536.patch')
-rw-r--r-- | meta/recipes-gnome/epiphany/files/CVE-2022-29536.patch | 46 |
1 files changed, 46 insertions, 0 deletions
diff --git a/meta/recipes-gnome/epiphany/files/CVE-2022-29536.patch b/meta/recipes-gnome/epiphany/files/CVE-2022-29536.patch new file mode 100644 index 0000000000..71cfc1238a --- /dev/null +++ b/meta/recipes-gnome/epiphany/files/CVE-2022-29536.patch | |||
@@ -0,0 +1,46 @@ | |||
1 | CVE: CVE-2022-29536 | ||
2 | Upstream-Status: Backport [ https://gitlab.gnome.org/GNOME/epiphany/-/commit/486da133569ebfc436c959a7419565ab102e8525 ] | ||
3 | Signed-off-by: Lee Chee Yang <chee.yang.lee@intel.com> | ||
4 | |||
5 | From 486da133569ebfc436c959a7419565ab102e8525 Mon Sep 17 00:00:00 2001 | ||
6 | From: Michael Catanzaro <mcatanzaro@redhat.com> | ||
7 | Date: Fri, 15 Apr 2022 18:09:46 -0500 | ||
8 | Subject: [PATCH] Fix memory corruption in ephy_string_shorten() | ||
9 | |||
10 | This fixes a regression that I introduced in 232c613472b38ff0d0d97338f366024ddb9cd228. | ||
11 | |||
12 | I got my browser stuck in a crash loop today while visiting a website | ||
13 | with a page title greater than ephy-embed.c's MAX_TITLE_LENGTH, the only | ||
14 | condition in which ephy_string_shorten() is ever used. Turns out this | ||
15 | commit is wrong: an ellipses is a multibyte character (three bytes in | ||
16 | UTF-8) and so we're writing past the end of the buffer when calling | ||
17 | strcat() here. Ooops. | ||
18 | |||
19 | Shame it took nearly four years to notice and correct this. | ||
20 | |||
21 | Part-of: <https://gitlab.gnome.org/GNOME/epiphany/-/merge_requests/1106> | ||
22 | --- | ||
23 | lib/ephy-string.c | 5 ++--- | ||
24 | 1 file changed, 2 insertions(+), 3 deletions(-) | ||
25 | |||
26 | diff --git a/lib/ephy-string.c b/lib/ephy-string.c | ||
27 | index 35a148ab32..8e524d52ca 100644 | ||
28 | --- a/lib/ephy-string.c | ||
29 | +++ b/lib/ephy-string.c | ||
30 | @@ -114,11 +114,10 @@ ephy_string_shorten (char *str, | ||
31 | /* create string */ | ||
32 | bytes = GPOINTER_TO_UINT (g_utf8_offset_to_pointer (str, target_length - 1) - str); | ||
33 | |||
34 | - /* +1 for ellipsis, +1 for trailing NUL */ | ||
35 | - new_str = g_new (gchar, bytes + 1 + 1); | ||
36 | + new_str = g_new (gchar, bytes + strlen ("…") + 1); | ||
37 | |||
38 | strncpy (new_str, str, bytes); | ||
39 | - strcat (new_str, "…"); | ||
40 | + strncpy (new_str + bytes, "…", strlen ("…") + 1); | ||
41 | |||
42 | g_free (str); | ||
43 | |||
44 | -- | ||
45 | GitLab | ||
46 | |||