summaryrefslogtreecommitdiffstats
path: root/meta/recipes-devtools/qemu/qemu/CVE-2021-20196_2.patch
diff options
context:
space:
mode:
Diffstat (limited to 'meta/recipes-devtools/qemu/qemu/CVE-2021-20196_2.patch')
-rw-r--r--meta/recipes-devtools/qemu/qemu/CVE-2021-20196_2.patch67
1 files changed, 67 insertions, 0 deletions
diff --git a/meta/recipes-devtools/qemu/qemu/CVE-2021-20196_2.patch b/meta/recipes-devtools/qemu/qemu/CVE-2021-20196_2.patch
new file mode 100644
index 0000000000..dd442ccb8f
--- /dev/null
+++ b/meta/recipes-devtools/qemu/qemu/CVE-2021-20196_2.patch
@@ -0,0 +1,67 @@
1From 1d48445a951fd5504190a38abeda70ea9372cf77 Mon Sep 17 00:00:00 2001
2From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= <philmd@redhat.com>
3Date: Wed, 24 Nov 2021 17:15:35 +0100
4Subject: [PATCH 12/12] hw/block/fdc: Kludge missing floppy drive to fix
5 CVE-2021-20196
6MIME-Version: 1.0
7Content-Type: text/plain; charset=UTF-8
8Content-Transfer-Encoding: 8bit
9
10Guest might select another drive on the bus by setting the
11DRIVE_SEL bit of the DIGITAL OUTPUT REGISTER (DOR).
12The current controller model doesn't expect a BlockBackend
13to be NULL. A simple way to fix CVE-2021-20196 is to create
14an empty BlockBackend when it is missing. All further
15accesses will be safely handled, and the controller state
16machines keep behaving correctly.
17
18Cc: qemu-stable@nongnu.org
19Fixes: CVE-2021-20196
20Reported-by: Gaoning Pan (Ant Security Light-Year Lab) <pgn@zju.edu.cn>
21Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
22Reviewed-by: Hanna Reitz <hreitz@redhat.com>
23Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
24Message-id: 20211124161536.631563-3-philmd@redhat.com
25BugLink: https://bugs.launchpad.net/qemu/+bug/1912780
26Resolves: https://gitlab.com/qemu-project/qemu/-/issues/338
27Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
28Reviewed-by: Hanna Reitz <hreitz@redhat.com>
29Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
30Signed-off-by: John Snow <jsnow@redhat.com>
31
32Upstream-Status: Backport [1ab95af033a419e7a64e2d58e67dd96b20af5233]
33CVE: CVE-2021-20196
34
35Signed-off-by: Sakib Sajal <sakib.sajal@windriver.com>
36---
37 hw/block/fdc.c | 14 +++++++++++++-
38 1 file changed, 13 insertions(+), 1 deletion(-)
39
40diff --git a/hw/block/fdc.c b/hw/block/fdc.c
41index 854b4f172..a736c4d14 100644
42--- a/hw/block/fdc.c
43+++ b/hw/block/fdc.c
44@@ -1365,7 +1365,19 @@ static FDrive *get_drv(FDCtrl *fdctrl, int unit)
45
46 static FDrive *get_cur_drv(FDCtrl *fdctrl)
47 {
48- return get_drv(fdctrl, fdctrl->cur_drv);
49+ FDrive *cur_drv = get_drv(fdctrl, fdctrl->cur_drv);
50+
51+ if (!cur_drv->blk) {
52+ /*
53+ * Kludge: empty drive line selected. Create an anonymous
54+ * BlockBackend to avoid NULL deref with various BlockBackend
55+ * API calls within this model (CVE-2021-20196).
56+ * Due to the controller QOM model limitations, we don't
57+ * attach the created to the controller device.
58+ */
59+ cur_drv->blk = blk_create_empty_drive();
60+ }
61+ return cur_drv;
62 }
63
64 /* Status A register : 0x00 (read-only) */
65--
662.31.1
67