summaryrefslogtreecommitdiffstats
path: root/meta/recipes-devtools/librepo/librepo/CVE-2020-14352.patch
diff options
context:
space:
mode:
Diffstat (limited to 'meta/recipes-devtools/librepo/librepo/CVE-2020-14352.patch')
-rw-r--r--meta/recipes-devtools/librepo/librepo/CVE-2020-14352.patch55
1 files changed, 55 insertions, 0 deletions
diff --git a/meta/recipes-devtools/librepo/librepo/CVE-2020-14352.patch b/meta/recipes-devtools/librepo/librepo/CVE-2020-14352.patch
new file mode 100644
index 0000000000..8f4c5b73bc
--- /dev/null
+++ b/meta/recipes-devtools/librepo/librepo/CVE-2020-14352.patch
@@ -0,0 +1,55 @@
1From 6027d68337b537bf9a68cf810cf9b8e40dac22f8 Mon Sep 17 00:00:00 2001
2From: Jaroslav Rohel <jrohel@redhat.com>
3Date: Wed, 12 Aug 2020 08:35:28 +0200
4Subject: [PATCH] Validate path read from repomd.xml (RhBug:1868639)
5
6= changelog =
7msg: Validate path read from repomd.xml
8type: security
9resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1868639
10
11Upstream-Status: Acepted [https://github.com/rpm-software-management/librepo/commit/7daea2a2429a54dad68b1de9b37a5f65c5cf2600]
12CVE: CVE-2020-14352
13Signed-off-by: Minjae Kim <flowergom@gmail.com>
14---
15 librepo/yum.c | 17 +++++++++++++++++
16 1 file changed, 17 insertions(+)
17
18diff --git a/librepo/yum.c b/librepo/yum.c
19index 3059188..529257b 100644
20--- a/librepo/yum.c
21+++ b/librepo/yum.c
22@@ -23,6 +23,7 @@
23 #define BITS_IN_BYTE 8
24
25 #include <stdio.h>
26+#include <libgen.h>
27 #include <assert.h>
28 #include <stdlib.h>
29 #include <errno.h>
30@@ -770,6 +771,22 @@ prepare_repo_download_targets(LrHandle *handle,
31 continue;
32
33 char *location_href = record->location_href;
34+
35+ char *dest_dir = realpath(handle->destdir, NULL);
36+ path = lr_pathconcat(handle->destdir, record->location_href, NULL);
37+ char *requested_dir = realpath(dirname(path), NULL);
38+ lr_free(path);
39+ if (!g_str_has_prefix(requested_dir, dest_dir)) {
40+ g_debug("%s: Invalid path: %s", __func__, location_href);
41+ g_set_error(err, LR_YUM_ERROR, LRE_IO, "Invalid path: %s", location_href);
42+ g_slist_free_full(*targets, (GDestroyNotify) lr_downloadtarget_free);
43+ free(requested_dir);
44+ free(dest_dir);
45+ return FALSE;
46+ }
47+ free(requested_dir);
48+ free(dest_dir);
49+
50 gboolean is_zchunk = FALSE;
51 #ifdef WITH_ZCHUNK
52 if (handle->cachedir && record->header_checksum)
53--
542.17.1
55