summaryrefslogtreecommitdiffstats
path: root/meta/recipes-devtools/go/go-1.14/CVE-2023-24537.patch
diff options
context:
space:
mode:
Diffstat (limited to 'meta/recipes-devtools/go/go-1.14/CVE-2023-24537.patch')
-rw-r--r--meta/recipes-devtools/go/go-1.14/CVE-2023-24537.patch76
1 files changed, 76 insertions, 0 deletions
diff --git a/meta/recipes-devtools/go/go-1.14/CVE-2023-24537.patch b/meta/recipes-devtools/go/go-1.14/CVE-2023-24537.patch
new file mode 100644
index 0000000000..e04b717fc1
--- /dev/null
+++ b/meta/recipes-devtools/go/go-1.14/CVE-2023-24537.patch
@@ -0,0 +1,76 @@
1From bf8c7c575c8a552d9d79deb29e80854dc88528d0 Mon Sep 17 00:00:00 2001
2From: Damien Neil <dneil@google.com>
3Date: Mon, 20 Mar 2023 10:43:19 -0700
4Subject: [PATCH] [release-branch.go1.20] mime/multipart: limit parsed mime
5 message sizes
6
7Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/1802456
8Reviewed-by: Julie Qiu <julieqiu@google.com>
9Reviewed-by: Roland Shoemaker <bracewell@google.com>
10Run-TryBot: Damien Neil <dneil@google.com>
11Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/1802611
12Reviewed-by: Damien Neil <dneil@google.com>
13Change-Id: Ifdfa192d54f722d781a4d8c5f35b5fb72d122168
14Reviewed-on: https://go-review.googlesource.com/c/go/+/481986
15Reviewed-by: Matthew Dempsky <mdempsky@google.com>
16TryBot-Result: Gopher Robot <gobot@golang.org>
17Run-TryBot: Michael Knyszek <mknyszek@google.com>
18Auto-Submit: Michael Knyszek <mknyszek@google.com>
19
20Upstream-Status: Backport [https://github.com/golang/go/commit/126a1d02da82f93ede7ce0bd8d3c51ef627f2104]
21CVE: CVE-2023-24537
22Signed-off-by: Vivek Kumbhar <vkumbhar@mvista.com>
23---
24 src/go/parser/parser_test.go | 16 ++++++++++++++++
25 src/go/scanner/scanner.go | 5 ++++-
26 2 files changed, 20 insertions(+), 1 deletion(-)
27
28diff --git a/src/go/parser/parser_test.go b/src/go/parser/parser_test.go
29index 37a6a2b..714557c 100644
30--- a/src/go/parser/parser_test.go
31+++ b/src/go/parser/parser_test.go
32@@ -738,3 +738,19 @@ func TestScopeDepthLimit(t *testing.T) {
33 }
34 }
35 }
36+
37+// TestIssue59180 tests that line number overflow doesn't cause an infinite loop.
38+func TestIssue59180(t *testing.T) {
39+ testcases := []string{
40+ "package p\n//line :9223372036854775806\n\n//",
41+ "package p\n//line :1:9223372036854775806\n\n//",
42+ "package p\n//line file:9223372036854775806\n\n//",
43+ }
44+
45+ for _, src := range testcases {
46+ _, err := ParseFile(token.NewFileSet(), "", src, ParseComments)
47+ if err == nil {
48+ t.Errorf("ParseFile(%s) succeeded unexpectedly", src)
49+ }
50+ }
51+}
52diff --git a/src/go/scanner/scanner.go b/src/go/scanner/scanner.go
53index 00fe2dc..3159d25 100644
54--- a/src/go/scanner/scanner.go
55+++ b/src/go/scanner/scanner.go
56@@ -246,13 +246,16 @@ func (s *Scanner) updateLineInfo(next, offs int, text []byte) {
57 return
58 }
59
60+ // Put a cap on the maximum size of line and column numbers.
61+ // 30 bits allows for some additional space before wrapping an int32.
62+ const maxLineCol = 1<<30 - 1
63 var line, col int
64 i2, n2, ok2 := trailingDigits(text[:i-1])
65 if ok2 {
66 //line filename:line:col
67 i, i2 = i2, i
68 line, col = n2, n
69- if col == 0 {
70+ if col == 0 || col > maxLineCol {
71 s.error(offs+i2, "invalid column number: "+string(text[i2:]))
72 return
73 }
74--
752.25.1
76