summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--meta/recipes-devtools/mmc/mmc-utils/0001-lsmmc-replace-strncpy-with-memmove-on-overlapping-me.patch36
-rw-r--r--meta/recipes-devtools/mmc/mmc-utils_git.bb5
2 files changed, 2 insertions, 39 deletions
diff --git a/meta/recipes-devtools/mmc/mmc-utils/0001-lsmmc-replace-strncpy-with-memmove-on-overlapping-me.patch b/meta/recipes-devtools/mmc/mmc-utils/0001-lsmmc-replace-strncpy-with-memmove-on-overlapping-me.patch
deleted file mode 100644
index 62e25fde9b..0000000000
--- a/meta/recipes-devtools/mmc/mmc-utils/0001-lsmmc-replace-strncpy-with-memmove-on-overlapping-me.patch
+++ /dev/null
@@ -1,36 +0,0 @@
1From 175ac0f362bf6121c3537e2f1760ad41c8f81367 Mon Sep 17 00:00:00 2001
2From: Khem Raj <raj.khem@gmail.com>
3Date: Thu, 29 Mar 2018 01:04:57 -0700
4Subject: [PATCH] lsmmc: replace strncpy with memmove on overlapping memory
5 copy
6
7here source and destination addresses are overlapping so using memmove is
8going to be more efficient.
9
10Additionally, the bounded size for copy is overflowing for first copy
11
12In function 'strncpy',
13 inlined from 'read_file' at lsmmc.c:356:3:
14/mnt/a/oe/build/tmp/work/cortexa7t2hf-neon-vfpv4-bec-linux-gnueabi/mmc-utils/0.1-r0/recipe-sysroot/usr/include/bits/string_fortified.h:106:10: error: '__builtin_strncpy' accessing 4096 bytes at offsets 0 and 1 overlaps 4095 bytes at offset 1 [-Werror=restrict]
15 return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
16 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
17
18Signed-off-by: Khem Raj <raj.khem@gmail.com>
19---
20Upstream-Status: Submitted [https://patchwork.kernel.org/patch/10314723/]
21 lsmmc.c | 2 +-
22 1 file changed, 1 insertion(+), 1 deletion(-)
23
24diff --git a/lsmmc.c b/lsmmc.c
25index c4faa00..bcb854d 100644
26--- a/lsmmc.c
27+++ b/lsmmc.c
28@@ -353,7 +353,7 @@ char *read_file(char *name)
29 line[strlen(line) - 1] = '\0';
30
31 while (isspace(line[0]))
32- strncpy(&line[0], &line[1], sizeof(line));
33+ memmove(&line[0], &line[1], sizeof(line)-1);
34
35 return strdup(line);
36 }
diff --git a/meta/recipes-devtools/mmc/mmc-utils_git.bb b/meta/recipes-devtools/mmc/mmc-utils_git.bb
index 37a4755234..f3a7234670 100644
--- a/meta/recipes-devtools/mmc/mmc-utils_git.bb
+++ b/meta/recipes-devtools/mmc/mmc-utils_git.bb
@@ -4,12 +4,11 @@ LICENSE = "GPLv2"
4LIC_FILES_CHKSUM = "file://mmc.c;beginline=1;endline=20;md5=fae32792e20f4d27ade1c5a762d16b7d" 4LIC_FILES_CHKSUM = "file://mmc.c;beginline=1;endline=20;md5=fae32792e20f4d27ade1c5a762d16b7d"
5 5
6SRCBRANCH ?= "master" 6SRCBRANCH ?= "master"
7SRCREV = "b4fe0c8c0e57a74c01755fa9362703b60d7ee49d" 7SRCREV = "aef913e31b659462fe6b9320d241676cba97f67b"
8 8
9PV = "0.1" 9PV = "0.1+git${SRCPV}"
10 10
11SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc-utils.git;branch=${SRCBRANCH} \ 11SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc-utils.git;branch=${SRCBRANCH} \
12 file://0001-lsmmc-replace-strncpy-with-memmove-on-overlapping-me.patch \
13 " 12 "
14UPSTREAM_CHECK_COMMITS = "1" 13UPSTREAM_CHECK_COMMITS = "1"
15 14