diff options
author | Patrick Ohly <patrick.ohly@intel.com> | 2017-05-03 15:38:53 +0200 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2017-05-18 14:01:47 +0100 |
commit | 0ef6fc5f9bf4d76e711a70942d4c7337b37c5b3f (patch) | |
tree | f7dbffc85a64cce492d919710f4c2f185d4db2cf /scripts/oe-build-perf-report | |
parent | 5b649b4bbd348f9933be4159c980c41a739bf68a (diff) | |
download | poky-0ef6fc5f9bf4d76e711a70942d4c7337b37c5b3f.tar.gz |
QemuRunner: avoid tainting os.environ
That a utility function permanently changes the process environment is
bad style and leads to subtle, hard to debug problems.
For example, we had one oe-selftest which used runqemu() with an
override for DEPLOY_DIR_IMAGE. Another test then just called runCmd()
and ended up passing the wrong DEPLOY_DIR_IMAGE set earlier in
os.environ.
The approach used here is to pass the desired environment dict to the
launch() method as a new, optional parameter, which then gets passed
on to subproject.Popen(). The modified env variables do not get
logged, as before.
[YOCTO #11443]
(From OE-Core rev: cab20f3b2fe668a63c58b44f2ad797fed74226fe)
Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'scripts/oe-build-perf-report')
0 files changed, 0 insertions, 0 deletions