summaryrefslogtreecommitdiffstats
path: root/scripts/nativesdk-intercept
diff options
context:
space:
mode:
authorEilís 'pidge' Ní Fhlannagáin <pidge@baylibre.com>2023-09-07 11:38:03 +0000
committerRichard Purdie <richard.purdie@linuxfoundation.org>2023-09-08 22:59:47 +0100
commitb5dbdfe90497867a70fcdd69a3e347952dff7d3a (patch)
tree0e69327d43a153130227c3048c0bacd03b601859 /scripts/nativesdk-intercept
parenta8f3ebc4e0ab5caa9c715798d19ac6dbd15d3957 (diff)
downloadpoky-b5dbdfe90497867a70fcdd69a3e347952dff7d3a.tar.gz
nativesdk-intercept: Fix bad intercept chgrp/chown logic
Running either of these ends up corrupting the os.execv args. If we run: ./scripts/nativesdk-intercept/chown -R foo:foo bar The loop here ends up missing the conversion of foo:foo to root:root because it sees sys.argv[0] and assumes that it's the user:group argument and that we should convert that. We end up a os.execv(path, args) that have the following args: ['root:root', '-R', 'foo:foo', 'bar'] As os.execv ignores args[0], we can just populate it with sys.argv[0] and then loop through sys.argv[1:]. As both chgrp and chown would have either flags and USER[:GROUP] next, this fixes the issue. (From OE-Core rev: 2a75f647ec7696d353f4b09099d777ba53f34d36) Signed-off-by: Eilís 'pidge' Ní Fhlannagáin <pidge@baylibre.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'scripts/nativesdk-intercept')
-rwxr-xr-xscripts/nativesdk-intercept/chgrp5
-rwxr-xr-xscripts/nativesdk-intercept/chown5
2 files changed, 8 insertions, 2 deletions
diff --git a/scripts/nativesdk-intercept/chgrp b/scripts/nativesdk-intercept/chgrp
index 30cc417d3a..f8ae84b8b3 100755
--- a/scripts/nativesdk-intercept/chgrp
+++ b/scripts/nativesdk-intercept/chgrp
@@ -14,7 +14,10 @@ real_chgrp = shutil.which('chgrp', path=path)
14args = list() 14args = list()
15 15
16found = False 16found = False
17for i in sys.argv: 17
18args.append(real_chgrp)
19
20for i in sys.argv[1:]:
18 if i.startswith("-"): 21 if i.startswith("-"):
19 args.append(i) 22 args.append(i)
20 continue 23 continue
diff --git a/scripts/nativesdk-intercept/chown b/scripts/nativesdk-intercept/chown
index 3914b3e384..0805ceb70a 100755
--- a/scripts/nativesdk-intercept/chown
+++ b/scripts/nativesdk-intercept/chown
@@ -14,7 +14,10 @@ real_chown = shutil.which('chown', path=path)
14args = list() 14args = list()
15 15
16found = False 16found = False
17for i in sys.argv: 17
18args.append(real_chown)
19
20for i in sys.argv[1:]:
18 if i.startswith("-"): 21 if i.startswith("-"):
19 args.append(i) 22 args.append(i)
20 continue 23 continue