diff options
author | Patrick Ohly <patrick.ohly@intel.com> | 2017-06-27 17:33:40 +0200 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2017-07-06 14:38:14 +0100 |
commit | 3cdeea61c180e3063721d7e08f2a790e25754296 (patch) | |
tree | 0c1a63ea874a09036e3d3444909992c02dbe92db /scripts/lib | |
parent | afedb883da3361e9c8a217d19ac48faa9ac36d78 (diff) | |
download | poky-3cdeea61c180e3063721d7e08f2a790e25754296.tar.gz |
yocto-compat-layer.py: apply test_signatures to all layers
Software layers were previously allowed to change signatures, but
that's not desired for those layers either. The rule that a layer
which is "Yocto Compatible 2.0" must not change signatures unless
explicitly requested holds for all kinds of layers.
However, as this is something that software layers might not be able
to do right away, testing for signature changes in software layers can
be disabled. It's on by default, as that was Richard's
recommendation. Whether that should change needs further discussion as
part of finalizing "Yocto Compatible 2.0".
As it might still change, the tool now has both a with/without
parameter so that users of the tool can choose the desired behavior
without being affected by future changes to the default.
(From OE-Core rev: e7fe215f50a1b75771f33fffdda529a95c026d3f)
Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'scripts/lib')
-rw-r--r-- | scripts/lib/compatlayer/cases/common.py | 5 | ||||
-rw-r--r-- | scripts/lib/compatlayer/context.py | 3 |
2 files changed, 5 insertions, 3 deletions
diff --git a/scripts/lib/compatlayer/cases/common.py b/scripts/lib/compatlayer/cases/common.py index 2dfcbb1c32..a1cdbab51e 100644 --- a/scripts/lib/compatlayer/cases/common.py +++ b/scripts/lib/compatlayer/cases/common.py | |||
@@ -27,8 +27,9 @@ class CommonCompatLayer(OECompatLayerTestCase): | |||
27 | 'bitbake -e') | 27 | 'bitbake -e') |
28 | 28 | ||
29 | def test_signatures(self): | 29 | def test_signatures(self): |
30 | if self.tc.layer['type'] == LayerType.SOFTWARE: | 30 | if self.tc.layer['type'] == LayerType.SOFTWARE and \ |
31 | raise unittest.SkipTest("Layer %s isn't BSP or DISTRO one." \ | 31 | not self.tc.test_software_layer_signatures: |
32 | raise unittest.SkipTest("Not testing for signature changes in a software layer %s." \ | ||
32 | % self.tc.layer['name']) | 33 | % self.tc.layer['name']) |
33 | 34 | ||
34 | # task -> (old signature, new signature) | 35 | # task -> (old signature, new signature) |
diff --git a/scripts/lib/compatlayer/context.py b/scripts/lib/compatlayer/context.py index 4932238798..7811d4ac20 100644 --- a/scripts/lib/compatlayer/context.py +++ b/scripts/lib/compatlayer/context.py | |||
@@ -9,6 +9,7 @@ import re | |||
9 | from oeqa.core.context import OETestContext | 9 | from oeqa.core.context import OETestContext |
10 | 10 | ||
11 | class CompatLayerTestContext(OETestContext): | 11 | class CompatLayerTestContext(OETestContext): |
12 | def __init__(self, td=None, logger=None, layer=None): | 12 | def __init__(self, td=None, logger=None, layer=None, test_software_layer_signatures=True): |
13 | super(CompatLayerTestContext, self).__init__(td, logger) | 13 | super(CompatLayerTestContext, self).__init__(td, logger) |
14 | self.layer = layer | 14 | self.layer = layer |
15 | self.test_software_layer_signatures = test_software_layer_signatures | ||