summaryrefslogtreecommitdiffstats
path: root/scripts/lib/wic
diff options
context:
space:
mode:
authorEd Bartosh <ed.bartosh@linux.intel.com>2015-04-15 23:47:10 +0300
committerRichard Purdie <richard.purdie@linuxfoundation.org>2015-04-24 11:06:55 +0100
commitf2a0a985236af116a84cc62a4f7e1d4707aea6e9 (patch)
tree781ff0e7990d38b314d9bea34a02abf085ff453d /scripts/lib/wic
parent1d0c3387e8881a7a372ee38c0944540ce2ac8bc5 (diff)
downloadpoky-f2a0a985236af116a84cc62a4f7e1d4707aea6e9.tar.gz
wic: code cleanup: wildcard imports
Here is what PEP8(Style Guide for Python Code) says about this: Wildcard imports (from <module> import *) should be avoided, as they make it unclear which names are present in the namespace, confusing both readers and many automated tools. (From OE-Core rev: 13416c1941f5dc8abcdb0073f2104a89eae2d6f1) Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'scripts/lib/wic')
-rw-r--r--scripts/lib/wic/imager/direct.py1
-rw-r--r--scripts/lib/wic/plugin.py2
-rw-r--r--scripts/lib/wic/plugins/source/bootimg-efi.py8
-rw-r--r--scripts/lib/wic/plugins/source/bootimg-partition.py2
-rw-r--r--scripts/lib/wic/plugins/source/bootimg-pcbios.py9
-rw-r--r--scripts/lib/wic/plugins/source/fsimage.py2
-rw-r--r--scripts/lib/wic/plugins/source/rawcopy.py2
-rw-r--r--scripts/lib/wic/plugins/source/rootfs.py9
-rw-r--r--scripts/lib/wic/utils/fs_related.py5
-rw-r--r--scripts/lib/wic/utils/partitionedfs.py4
10 files changed, 13 insertions, 31 deletions
diff --git a/scripts/lib/wic/imager/direct.py b/scripts/lib/wic/imager/direct.py
index 0e687bd70e..9a7d0f5117 100644
--- a/scripts/lib/wic/imager/direct.py
+++ b/scripts/lib/wic/imager/direct.py
@@ -32,7 +32,6 @@ from wic.utils import fs_related, runner, misc
32from wic.utils.partitionedfs import Image 32from wic.utils.partitionedfs import Image
33from wic.utils.errors import CreatorError, ImageError 33from wic.utils.errors import CreatorError, ImageError
34from wic.imager.baseimager import BaseImageCreator 34from wic.imager.baseimager import BaseImageCreator
35from wic.utils.oe.misc import *
36from wic.plugin import pluginmgr 35from wic.plugin import pluginmgr
37 36
38disk_methods = { 37disk_methods = {
diff --git a/scripts/lib/wic/plugin.py b/scripts/lib/wic/plugin.py
index 41a80175ca..9872d20985 100644
--- a/scripts/lib/wic/plugin.py
+++ b/scripts/lib/wic/plugin.py
@@ -20,7 +20,7 @@ import os, sys
20from wic import msger 20from wic import msger
21from wic import pluginbase 21from wic import pluginbase
22from wic.utils import errors 22from wic.utils import errors
23from wic.utils.oe.misc import * 23from wic.utils.oe.misc import get_bitbake_var
24 24
25__ALL__ = ['PluginMgr', 'pluginmgr'] 25__ALL__ = ['PluginMgr', 'pluginmgr']
26 26
diff --git a/scripts/lib/wic/plugins/source/bootimg-efi.py b/scripts/lib/wic/plugins/source/bootimg-efi.py
index 883378ee84..2fc0357a5c 100644
--- a/scripts/lib/wic/plugins/source/bootimg-efi.py
+++ b/scripts/lib/wic/plugins/source/bootimg-efi.py
@@ -29,13 +29,9 @@ import shutil
29 29
30from wic.utils.errors import ImageError 30from wic.utils.errors import ImageError
31from wic import kickstart, msger 31from wic import kickstart, msger
32from wic.utils import misc, fs_related, errors, runner, cmdln
33from wic.conf import configmgr
34from wic.plugin import pluginmgr
35import wic.imager.direct as direct
36from wic.pluginbase import SourcePlugin 32from wic.pluginbase import SourcePlugin
37from wic.utils.oe.misc import * 33from wic.utils.oe.misc import exec_cmd, exec_native_cmd, get_bitbake_var, \
38from wic.imager.direct import DirectImageCreator 34 BOOTDD_EXTRA_SPACE
39 35
40class BootimgEFIPlugin(SourcePlugin): 36class BootimgEFIPlugin(SourcePlugin):
41 name = 'bootimg-efi' 37 name = 'bootimg-efi'
diff --git a/scripts/lib/wic/plugins/source/bootimg-partition.py b/scripts/lib/wic/plugins/source/bootimg-partition.py
index c5eb7b8b80..909e59b6e2 100644
--- a/scripts/lib/wic/plugins/source/bootimg-partition.py
+++ b/scripts/lib/wic/plugins/source/bootimg-partition.py
@@ -28,7 +28,7 @@ import re
28 28
29from wic import msger 29from wic import msger
30from wic.pluginbase import SourcePlugin 30from wic.pluginbase import SourcePlugin
31from wic.utils.oe.misc import * 31from wic.utils.oe.misc import exec_cmd, get_bitbake_var
32from glob import glob 32from glob import glob
33 33
34class BootimgPartitionPlugin(SourcePlugin): 34class BootimgPartitionPlugin(SourcePlugin):
diff --git a/scripts/lib/wic/plugins/source/bootimg-pcbios.py b/scripts/lib/wic/plugins/source/bootimg-pcbios.py
index 2280867308..9c638554c0 100644
--- a/scripts/lib/wic/plugins/source/bootimg-pcbios.py
+++ b/scripts/lib/wic/plugins/source/bootimg-pcbios.py
@@ -28,13 +28,10 @@ import os
28 28
29from wic.utils.errors import ImageError 29from wic.utils.errors import ImageError
30from wic import kickstart, msger 30from wic import kickstart, msger
31from wic.utils import misc, fs_related, errors, runner, cmdln 31from wic.utils import runner
32from wic.conf import configmgr
33from wic.plugin import pluginmgr
34import wic.imager.direct as direct
35from wic.pluginbase import SourcePlugin 32from wic.pluginbase import SourcePlugin
36from wic.utils.oe.misc import * 33from wic.utils.oe.misc import exec_cmd, exec_native_cmd, \
37from wic.imager.direct import DirectImageCreator 34 get_bitbake_var, BOOTDD_EXTRA_SPACE
38 35
39class BootimgPcbiosPlugin(SourcePlugin): 36class BootimgPcbiosPlugin(SourcePlugin):
40 name = 'bootimg-pcbios' 37 name = 'bootimg-pcbios'
diff --git a/scripts/lib/wic/plugins/source/fsimage.py b/scripts/lib/wic/plugins/source/fsimage.py
index 4a090bac42..ef56cf278b 100644
--- a/scripts/lib/wic/plugins/source/fsimage.py
+++ b/scripts/lib/wic/plugins/source/fsimage.py
@@ -19,7 +19,7 @@ import os
19 19
20from wic import msger 20from wic import msger
21from wic.pluginbase import SourcePlugin 21from wic.pluginbase import SourcePlugin
22from wic.utils.oe.misc import * 22from wic.utils.oe.misc import get_bitbake_var
23 23
24class FSImagePlugin(SourcePlugin): 24class FSImagePlugin(SourcePlugin):
25 name = 'fsimage' 25 name = 'fsimage'
diff --git a/scripts/lib/wic/plugins/source/rawcopy.py b/scripts/lib/wic/plugins/source/rawcopy.py
index ca6b721b67..444c0268fb 100644
--- a/scripts/lib/wic/plugins/source/rawcopy.py
+++ b/scripts/lib/wic/plugins/source/rawcopy.py
@@ -19,7 +19,7 @@ import os
19 19
20from wic import msger 20from wic import msger
21from wic.pluginbase import SourcePlugin 21from wic.pluginbase import SourcePlugin
22from wic.utils.oe.misc import * 22from wic.utils.oe.misc import exec_cmd, get_bitbake_var
23 23
24class RawCopyPlugin(SourcePlugin): 24class RawCopyPlugin(SourcePlugin):
25 name = 'rawcopy' 25 name = 'rawcopy'
diff --git a/scripts/lib/wic/plugins/source/rootfs.py b/scripts/lib/wic/plugins/source/rootfs.py
index 6f5d9bb19f..7d444301fb 100644
--- a/scripts/lib/wic/plugins/source/rootfs.py
+++ b/scripts/lib/wic/plugins/source/rootfs.py
@@ -27,14 +27,9 @@
27 27
28import os 28import os
29 29
30from wic import kickstart, msger 30from wic import msger
31from wic.utils import misc, fs_related, errors, runner, cmdln
32from wic.conf import configmgr
33from wic.plugin import pluginmgr
34import wic.imager.direct as direct
35from wic.pluginbase import SourcePlugin 31from wic.pluginbase import SourcePlugin
36from wic.utils.oe.misc import * 32from wic.utils.oe.misc import find_bitbake_env_lines, find_artifact
37from wic.imager.direct import DirectImageCreator
38 33
39class RootfsPlugin(SourcePlugin): 34class RootfsPlugin(SourcePlugin):
40 name = 'rootfs' 35 name = 'rootfs'
diff --git a/scripts/lib/wic/utils/fs_related.py b/scripts/lib/wic/utils/fs_related.py
index fb9054d568..2e74461a40 100644
--- a/scripts/lib/wic/utils/fs_related.py
+++ b/scripts/lib/wic/utils/fs_related.py
@@ -20,10 +20,7 @@ from __future__ import with_statement
20import os 20import os
21import errno 21import errno
22 22
23from wic import msger 23from wic.utils.oe.misc import exec_cmd
24from wic.utils import runner
25from wic.utils.errors import *
26from wic.utils.oe.misc import *
27 24
28def makedirs(dirname): 25def makedirs(dirname):
29 """A version of os.makedirs() that doesn't throw an 26 """A version of os.makedirs() that doesn't throw an
diff --git a/scripts/lib/wic/utils/partitionedfs.py b/scripts/lib/wic/utils/partitionedfs.py
index 40d6e889b0..1c9e3eab58 100644
--- a/scripts/lib/wic/utils/partitionedfs.py
+++ b/scripts/lib/wic/utils/partitionedfs.py
@@ -19,10 +19,8 @@
19# Temple Place - Suite 330, Boston, MA 02111-1307, USA. 19# Temple Place - Suite 330, Boston, MA 02111-1307, USA.
20 20
21from wic import msger 21from wic import msger
22from wic.utils import runner
23from wic.utils.errors import ImageError 22from wic.utils.errors import ImageError
24from wic.utils.fs_related import * 23from wic.utils.oe.misc import exec_cmd, exec_native_cmd
25from wic.utils.oe.misc import *
26 24
27# Overhead of the MBR partitioning scheme (just one sector) 25# Overhead of the MBR partitioning scheme (just one sector)
28MBR_OVERHEAD = 1 26MBR_OVERHEAD = 1