diff options
author | Ed Bartosh <ed.bartosh@linux.intel.com> | 2015-06-05 10:17:11 +0300 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2015-06-11 23:59:12 +0100 |
commit | c3148c6199756439d1802555b45249066eb7e6cf (patch) | |
tree | 67b8736c180038e91752ad4110234280eac69ffb /scripts/lib/wic/plugins/source | |
parent | 5b4ab4e4be2622a8d546dfd38de58bfd72cd4831 (diff) | |
download | poky-c3148c6199756439d1802555b45249066eb7e6cf.tar.gz |
wic: Refactored getting root device name
Replaced DirectImageCreator._get_boot_config private method
with a 'rootdev' property.
Simplified the code and API.
Used 'uuid' property instead of incorrectly used 'part_type'.
(From OE-Core rev: 4a303007149ea1205bbd454e70810e7dfa343d4c)
Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'scripts/lib/wic/plugins/source')
-rw-r--r-- | scripts/lib/wic/plugins/source/bootimg-efi.py | 6 | ||||
-rw-r--r-- | scripts/lib/wic/plugins/source/bootimg-pcbios.py | 3 | ||||
-rw-r--r-- | scripts/lib/wic/plugins/source/rootfs_pcbios_ext.py | 3 |
3 files changed, 4 insertions, 8 deletions
diff --git a/scripts/lib/wic/plugins/source/bootimg-efi.py b/scripts/lib/wic/plugins/source/bootimg-efi.py index 400e3a2df8..39ce9f375e 100644 --- a/scripts/lib/wic/plugins/source/bootimg-efi.py +++ b/scripts/lib/wic/plugins/source/bootimg-efi.py | |||
@@ -47,7 +47,6 @@ class BootimgEFIPlugin(SourcePlugin): | |||
47 | else: | 47 | else: |
48 | splashline = "" | 48 | splashline = "" |
49 | 49 | ||
50 | (rootdev, root_part_uuid) = cr._get_boot_config() | ||
51 | options = cr.ks.handler.bootloader.appendLine | 50 | options = cr.ks.handler.bootloader.appendLine |
52 | 51 | ||
53 | grubefi_conf = "" | 52 | grubefi_conf = "" |
@@ -62,7 +61,7 @@ class BootimgEFIPlugin(SourcePlugin): | |||
62 | kernel = "/bzImage" | 61 | kernel = "/bzImage" |
63 | 62 | ||
64 | if cr.ptable_format in ('msdos', 'gpt'): | 63 | if cr.ptable_format in ('msdos', 'gpt'): |
65 | rootstr = rootdev | 64 | rootstr = cr.rootdev |
66 | else: | 65 | else: |
67 | raise ImageError("Unsupported partition table format found") | 66 | raise ImageError("Unsupported partition table format found") |
68 | 67 | ||
@@ -87,7 +86,6 @@ class BootimgEFIPlugin(SourcePlugin): | |||
87 | install_cmd = "install -d %s/loader/entries" % hdddir | 86 | install_cmd = "install -d %s/loader/entries" % hdddir |
88 | exec_cmd(install_cmd) | 87 | exec_cmd(install_cmd) |
89 | 88 | ||
90 | (rootdev, root_part_uuid) = cr._get_boot_config() | ||
91 | options = cr.ks.handler.bootloader.appendLine | 89 | options = cr.ks.handler.bootloader.appendLine |
92 | 90 | ||
93 | timeout = kickstart.get_timeout(cr.ks) | 91 | timeout = kickstart.get_timeout(cr.ks) |
@@ -107,7 +105,7 @@ class BootimgEFIPlugin(SourcePlugin): | |||
107 | kernel = "/bzImage" | 105 | kernel = "/bzImage" |
108 | 106 | ||
109 | if cr.ptable_format in ('msdos', 'gpt'): | 107 | if cr.ptable_format in ('msdos', 'gpt'): |
110 | rootstr = rootdev | 108 | rootstr = cr.rootdev |
111 | else: | 109 | else: |
112 | raise ImageError("Unsupported partition table format found") | 110 | raise ImageError("Unsupported partition table format found") |
113 | 111 | ||
diff --git a/scripts/lib/wic/plugins/source/bootimg-pcbios.py b/scripts/lib/wic/plugins/source/bootimg-pcbios.py index 1c3c6e605c..dd49480141 100644 --- a/scripts/lib/wic/plugins/source/bootimg-pcbios.py +++ b/scripts/lib/wic/plugins/source/bootimg-pcbios.py | |||
@@ -83,7 +83,6 @@ class BootimgPcbiosPlugin(SourcePlugin): | |||
83 | else: | 83 | else: |
84 | splashline = "" | 84 | splashline = "" |
85 | 85 | ||
86 | (rootdev, root_part_uuid) = cr._get_boot_config() | ||
87 | options = cr.ks.handler.bootloader.appendLine | 86 | options = cr.ks.handler.bootloader.appendLine |
88 | 87 | ||
89 | syslinux_conf = "" | 88 | syslinux_conf = "" |
@@ -105,7 +104,7 @@ class BootimgPcbiosPlugin(SourcePlugin): | |||
105 | syslinux_conf += "KERNEL " + kernel + "\n" | 104 | syslinux_conf += "KERNEL " + kernel + "\n" |
106 | 105 | ||
107 | if cr.ptable_format in ('msdos', 'gpt'): | 106 | if cr.ptable_format in ('msdos', 'gpt'): |
108 | rootstr = rootdev | 107 | rootstr = cr.rootdev |
109 | else: | 108 | else: |
110 | raise ImageError("Unsupported partition table format found") | 109 | raise ImageError("Unsupported partition table format found") |
111 | 110 | ||
diff --git a/scripts/lib/wic/plugins/source/rootfs_pcbios_ext.py b/scripts/lib/wic/plugins/source/rootfs_pcbios_ext.py index 50b221382c..90dac05dca 100644 --- a/scripts/lib/wic/plugins/source/rootfs_pcbios_ext.py +++ b/scripts/lib/wic/plugins/source/rootfs_pcbios_ext.py | |||
@@ -82,7 +82,6 @@ class RootfsPlugin(SourcePlugin): | |||
82 | 82 | ||
83 | Called before do_prepare_partition() | 83 | Called before do_prepare_partition() |
84 | """ | 84 | """ |
85 | rootdev = image_creator._get_boot_config()[0] | ||
86 | options = image_creator.ks.handler.bootloader.appendLine | 85 | options = image_creator.ks.handler.bootloader.appendLine |
87 | 86 | ||
88 | syslinux_conf = "" | 87 | syslinux_conf = "" |
@@ -102,7 +101,7 @@ class RootfsPlugin(SourcePlugin): | |||
102 | syslinux_conf += " KERNEL /boot/bzImage\n" | 101 | syslinux_conf += " KERNEL /boot/bzImage\n" |
103 | 102 | ||
104 | if image_creator.ptable_format in ('msdos', 'gpt'): | 103 | if image_creator.ptable_format in ('msdos', 'gpt'): |
105 | rootstr = rootdev | 104 | rootstr = image_creator.rootdev |
106 | else: | 105 | else: |
107 | raise ImageError("Unsupported partition table format found") | 106 | raise ImageError("Unsupported partition table format found") |
108 | 107 | ||