summaryrefslogtreecommitdiffstats
path: root/meta
diff options
context:
space:
mode:
authorRobert Yang <liezhi.yang@windriver.com>2014-08-11 23:08:11 -0700
committerRichard Purdie <richard.purdie@linuxfoundation.org>2014-08-15 18:21:51 +0100
commitc4f51a048ffbf29b36670fab2db35b8af10228a2 (patch)
tree5a3b0ede6b49002fde39b7f517e67dfc2948560f /meta
parent25bf76a8668d2572c6f1a396b657e795b031bbb3 (diff)
downloadpoky-c4f51a048ffbf29b36670fab2db35b8af10228a2.tar.gz
image.bbclass: image_types.bbclass is a must
The image_types.bbclass is a must since we use this in image.bbclass: [snip] python () { deps = " " + imagetypes_getdepends(d) d.appendVarFlag('do_rootfs', 'depends', deps) [snip] The imagetypes_getdepends() is defined in image_types.bbclass. Use "+=" to replace "?=" since it is a must, so that the user can use "IMAGE_CLASSES = foo.bbclass" in local.conf to add their own image class. NOTE: the IMAGE_CLASSES_append = " foo" doesn't work since we use this in image.bbclass: IMAGE_CLASSES += "image_types" inherit ${IMAGE_CLASSES} I think that it is because inherit takes effect before append? Another way to fix the problem is: IMAGE_CLASSES ?= "" inherit image_types ${IMAGE_CLASSES} But it seems that we need another name for IMAGE_CLASSES, for example IMAGE_CLASSES_EXTRA, and also need update the doc, which would make it complicated. (From OE-Core rev: c225613d997ef40dedf64b880b5ca4ae89adfded) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta')
-rw-r--r--meta/classes/image.bbclass2
1 files changed, 1 insertions, 1 deletions
diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index 82605f2087..940bdb6bc0 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -163,7 +163,7 @@ python () {
163 d.appendVarFlag('do_bundle_initramfs', 'depends', " %s:do_rootfs" % initramfs_image) 163 d.appendVarFlag('do_bundle_initramfs', 'depends', " %s:do_rootfs" % initramfs_image)
164} 164}
165 165
166IMAGE_CLASSES ?= "image_types" 166IMAGE_CLASSES += "image_types"
167inherit ${IMAGE_CLASSES} 167inherit ${IMAGE_CLASSES}
168 168
169IMAGE_POSTPROCESS_COMMAND ?= "" 169IMAGE_POSTPROCESS_COMMAND ?= ""