diff options
author | Ming Liu <liu.ming50@gmail.com> | 2021-06-21 13:29:39 +0200 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2021-06-22 15:18:11 +0100 |
commit | fc253e327caf0e143d87de95467c27817c5f4f8c (patch) | |
tree | 11ecc5b6c3bf847540194d9ecb774392beb68d59 /meta | |
parent | e9fa8f9001471bb240e997cb4537d2f617f22957 (diff) | |
download | poky-fc253e327caf0e143d87de95467c27817c5f4f8c.tar.gz |
uboot-sign.bbclass: fix some install commands
A "install -d" command is missing when dealing with
${UBOOT_NODTB_BINARY} in install_spl_helper function, this can lead
to invalid install error saying:
| install: cannot create .../usr/share/u-boot-nodtb-2021.04-r0.bin': No such file or directory
Let's drop all "install -d" and replace them with "install -Dm" in
install_helper/install_spl_helper functions.
(From OE-Core rev: db2b1da511ea3d4daef136a8b1d85b7040a46632)
Signed-off-by: Ming Liu <liu.ming50@gmail.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta')
-rw-r--r-- | meta/classes/uboot-sign.bbclass | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/meta/classes/uboot-sign.bbclass b/meta/classes/uboot-sign.bbclass index 29b2edc833..9671cf76a5 100644 --- a/meta/classes/uboot-sign.bbclass +++ b/meta/classes/uboot-sign.bbclass | |||
@@ -196,10 +196,9 @@ concat_spl_dtb() { | |||
196 | # signing, and kernel will deploy UBOOT_DTB_BINARY after signs it. | 196 | # signing, and kernel will deploy UBOOT_DTB_BINARY after signs it. |
197 | install_helper() { | 197 | install_helper() { |
198 | if [ -f "${UBOOT_DTB_BINARY}" ]; then | 198 | if [ -f "${UBOOT_DTB_BINARY}" ]; then |
199 | install -d ${D}${datadir} | ||
200 | # UBOOT_DTB_BINARY is a symlink to UBOOT_DTB_IMAGE, so we | 199 | # UBOOT_DTB_BINARY is a symlink to UBOOT_DTB_IMAGE, so we |
201 | # need both of them. | 200 | # need both of them. |
202 | install ${UBOOT_DTB_BINARY} ${D}${datadir}/${UBOOT_DTB_IMAGE} | 201 | install -Dm 0644 ${UBOOT_DTB_BINARY} ${D}${datadir}/${UBOOT_DTB_IMAGE} |
203 | ln -sf ${UBOOT_DTB_IMAGE} ${D}${datadir}/${UBOOT_DTB_BINARY} | 202 | ln -sf ${UBOOT_DTB_IMAGE} ${D}${datadir}/${UBOOT_DTB_BINARY} |
204 | else | 203 | else |
205 | bbwarn "${UBOOT_DTB_BINARY} not found" | 204 | bbwarn "${UBOOT_DTB_BINARY} not found" |
@@ -209,14 +208,13 @@ install_helper() { | |||
209 | # Install SPL dtb and u-boot nodtb to datadir, | 208 | # Install SPL dtb and u-boot nodtb to datadir, |
210 | install_spl_helper() { | 209 | install_spl_helper() { |
211 | if [ -f "${SPL_DIR}/${SPL_DTB_BINARY}" ]; then | 210 | if [ -f "${SPL_DIR}/${SPL_DTB_BINARY}" ]; then |
212 | install -d ${D}${datadir} | 211 | install -Dm 0644 ${SPL_DIR}/${SPL_DTB_BINARY} ${D}${datadir}/${SPL_DTB_IMAGE} |
213 | install ${SPL_DIR}/${SPL_DTB_BINARY} ${D}${datadir}/${SPL_DTB_IMAGE} | ||
214 | ln -sf ${SPL_DTB_IMAGE} ${D}${datadir}/${SPL_DTB_BINARY} | 212 | ln -sf ${SPL_DTB_IMAGE} ${D}${datadir}/${SPL_DTB_BINARY} |
215 | else | 213 | else |
216 | bbwarn "${SPL_DTB_BINARY} not found" | 214 | bbwarn "${SPL_DTB_BINARY} not found" |
217 | fi | 215 | fi |
218 | if [ -f "${UBOOT_NODTB_BINARY}" ] ; then | 216 | if [ -f "${UBOOT_NODTB_BINARY}" ] ; then |
219 | install ${UBOOT_NODTB_BINARY} ${D}${datadir}/${UBOOT_NODTB_IMAGE} | 217 | install -Dm 0644 ${UBOOT_NODTB_BINARY} ${D}${datadir}/${UBOOT_NODTB_IMAGE} |
220 | ln -sf ${UBOOT_NODTB_IMAGE} ${D}${datadir}/${UBOOT_NODTB_BINARY} | 218 | ln -sf ${UBOOT_NODTB_IMAGE} ${D}${datadir}/${UBOOT_NODTB_BINARY} |
221 | else | 219 | else |
222 | bbwarn "${UBOOT_NODTB_BINARY} not found" | 220 | bbwarn "${UBOOT_NODTB_BINARY} not found" |