diff options
author | Ulf Magnusson <ulfalizer@gmail.com> | 2016-10-01 04:47:09 +0200 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2016-10-04 16:29:05 +0100 |
commit | 4768cd65199a3ff0709b5350d1e13b85ff9a9058 (patch) | |
tree | a1420bd8413964b6c907e7196c7f9b02cb4ab42e /meta | |
parent | 4dbb0d73dd7458dd67091afb250e4de976e68940 (diff) | |
download | poky-4768cd65199a3ff0709b5350d1e13b85ff9a9058.tar.gz |
utility-tasks.bbclass: Use bb.fatal() instead of raising FuncFailed
This sets a good example and avoids unnecessarily contributing to
perceived complexity and cargo culting.
Motivating quote below:
< kergoth> the *original* intent was for the function/task to error via
whatever appropriate means, bb.fatal, whatever, and
funcfailed was what you'd catch if you were calling
exec_func/exec_task. that is, it's what those functions
raise, not what metadata functions should be raising
< kergoth> it didn't end up being used that way
< kergoth> but there's really never a reason to raise it yourself
FuncFailed.__init__ takes a 'name' argument rather than a 'msg'
argument, which also shows that the original purpose got lost.
(From OE-Core rev: de45a7e302fe5a2a08baf26c91e2c788d7285263)
Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta')
-rw-r--r-- | meta/classes/utility-tasks.bbclass | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/meta/classes/utility-tasks.bbclass b/meta/classes/utility-tasks.bbclass index 7bc584abb9..7ba56e28ae 100644 --- a/meta/classes/utility-tasks.bbclass +++ b/meta/classes/utility-tasks.bbclass | |||
@@ -47,7 +47,7 @@ python do_checkuri() { | |||
47 | fetcher = bb.fetch2.Fetch(src_uri, d) | 47 | fetcher = bb.fetch2.Fetch(src_uri, d) |
48 | fetcher.checkstatus() | 48 | fetcher.checkstatus() |
49 | except bb.fetch2.BBFetchException as e: | 49 | except bb.fetch2.BBFetchException as e: |
50 | raise bb.build.FuncFailed(e) | 50 | bb.fatal(str(e)) |
51 | } | 51 | } |
52 | 52 | ||
53 | addtask checkuriall after do_checkuri | 53 | addtask checkuriall after do_checkuri |