summaryrefslogtreecommitdiffstats
path: root/meta
diff options
context:
space:
mode:
authorUlf Magnusson <ulfalizer@gmail.com>2016-10-01 04:47:06 +0200
committerRichard Purdie <richard.purdie@linuxfoundation.org>2016-10-04 16:29:05 +0100
commitc5823be186d1ab8c36a35597e738d8578a153b16 (patch)
treea0c00c8ca83ac0be96e516bc67abccc08b04a369 /meta
parentfe7a7836edaea2fbb773ea822608fc3f8e3b84a0 (diff)
downloadpoky-c5823be186d1ab8c36a35597e738d8578a153b16.tar.gz
testsdk.bbclass: Use bb.fatal() instead of raising FuncFailed
This sets a good example and avoids unnecessarily contributing to perceived complexity and cargo culting. Motivating quote below: < kergoth> the *original* intent was for the function/task to error via whatever appropriate means, bb.fatal, whatever, and funcfailed was what you'd catch if you were calling exec_func/exec_task. that is, it's what those functions raise, not what metadata functions should be raising < kergoth> it didn't end up being used that way < kergoth> but there's really never a reason to raise it yourself FuncFailed.__init__ takes a 'name' argument rather than a 'msg' argument, which also shows that the original purpose got lost. (From OE-Core rev: 086240468265dc15c5b4cdb2594d5aa7c3114dda) Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta')
-rw-r--r--meta/classes/testsdk.bbclass2
1 files changed, 1 insertions, 1 deletions
diff --git a/meta/classes/testsdk.bbclass b/meta/classes/testsdk.bbclass
index 0b8716edb5..77c9203cf9 100644
--- a/meta/classes/testsdk.bbclass
+++ b/meta/classes/testsdk.bbclass
@@ -44,7 +44,7 @@ def run_test_context(CTestContext, d, testdir, tcname, pn, *args):
44 msg += " (skipped=%d)" % skipped 44 msg += " (skipped=%d)" % skipped
45 bb.plain(msg) 45 bb.plain(msg)
46 else: 46 else:
47 raise bb.build.FuncFailed("%s - FAILED - check the task log and the commands log" % pn ) 47 bb.fatal("%s - FAILED - check the task log and the commands log" % pn)
48 48
49def testsdk_main(d): 49def testsdk_main(d):
50 import os 50 import os