summaryrefslogtreecommitdiffstats
path: root/meta
diff options
context:
space:
mode:
authorMark Hatle <mark.hatle@windriver.com>2018-04-16 11:34:18 -0400
committerRichard Purdie <richard.purdie@linuxfoundation.org>2018-05-03 09:53:49 +0100
commit9565237a678ac03c86c98987345d8052720f8b49 (patch)
tree5e2145166dedc2de70f7f3bee5c0591c917e328f /meta
parent95f831745cd5fe850fe374c34aaccb8a52b827c4 (diff)
downloadpoky-9565237a678ac03c86c98987345d8052720f8b49.tar.gz
package.bbclass: Add '-b' option to file call in isELF
The isELF function works by running: result = file <pathname> if 'ELF' in result By default 'file' will prepend the result with the path name of the file that is being checked. This usually works fine, such as: $ file /home/foo/openembedded-core/meta/classes/package.bbclass /home/foo/openembedded-core/meta/classes/package.bbclass: Python script, ASCII text executable, with very long lines However, if the path includes 'ELF', ELF will end up in the result, and then the check will return positive. $ file /home/ELF/openembedded-core/meta/classes/package.bbclass /home/ELF/openembedded-core/meta/classes/package.bbclass: Python script, ASCII text executable, with very long lines This will then result in the isELF coming back true, and possibly causing the checks that use isELF, such as the 'is it already stripped' check, to do the incorrect thing. Adding the '-b' option to file will result in the path being omitted in the result: $ file /home/ELF/openembedded-core/meta/classes/package.bbclass Python script, ASCII text executable, with very long lines (From OE-Core rev: 5a324e9b2cf6378f8eaa4e394f9cb36d4e2680ac) (From OE-Core rev: 46ddc11a8be79515b4ab9f9f7568c3d624ac72fe) Signed-off-by: Mark Hatle <mark.hatle@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> [fixup for Rocko] Signed-off-by: Armin Kuster <akuster808@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta')
-rw-r--r--meta/classes/package.bbclass2
-rw-r--r--meta/lib/oe/package.py2
2 files changed, 2 insertions, 2 deletions
diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index 2053d46395..cee64f3267 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -901,7 +901,7 @@ python split_and_strip_files () {
901 # 16 - kernel module 901 # 16 - kernel module
902 def isELF(path): 902 def isELF(path):
903 type = 0 903 type = 0
904 ret, result = oe.utils.getstatusoutput("file \"%s\"" % path.replace("\"", "\\\"")) 904 ret, result = oe.utils.getstatusoutput("file -b '%s'" % path.replace("\"", "\\\""))
905 905
906 if ret: 906 if ret:
907 msg = "split_and_strip_files: 'file %s' failed" % path 907 msg = "split_and_strip_files: 'file %s' failed" % path
diff --git a/meta/lib/oe/package.py b/meta/lib/oe/package.py
index 1e5c3aa8e1..599fca60f8 100644
--- a/meta/lib/oe/package.py
+++ b/meta/lib/oe/package.py
@@ -73,7 +73,7 @@ def strip_execs(pn, dstdir, strip_cmd, libdir, base_libdir, qa_already_stripped=
73 def is_elf(path): 73 def is_elf(path):
74 exec_type = 0 74 exec_type = 0
75 ret, result = oe.utils.getstatusoutput( 75 ret, result = oe.utils.getstatusoutput(
76 "file \"%s\"" % path.replace("\"", "\\\"")) 76 "file -b \"%s\"" % path.replace("\"", "\\\""))
77 77
78 if ret: 78 if ret:
79 bb.error("split_and_strip_files: 'file %s' failed" % path) 79 bb.error("split_and_strip_files: 'file %s' failed" % path)