summaryrefslogtreecommitdiffstats
path: root/meta
diff options
context:
space:
mode:
authorUlf Magnusson <ulfalizer@gmail.com>2016-10-01 04:47:07 +0200
committerRichard Purdie <richard.purdie@linuxfoundation.org>2016-10-04 16:29:05 +0100
commit4c25460c5ae3b7779ced56ce8ed114d512e1f883 (patch)
tree5619c2e574ea6f07c5fed5b21dcc5fec536532c0 /meta
parentc5823be186d1ab8c36a35597e738d8578a153b16 (diff)
downloadpoky-4c25460c5ae3b7779ced56ce8ed114d512e1f883.tar.gz
libc-package.bbclass: Use bb.fatal() instead of raising FuncFailed
This sets a good example and avoids unnecessarily contributing to perceived complexity and cargo culting. Motivating quote below: < kergoth> the *original* intent was for the function/task to error via whatever appropriate means, bb.fatal, whatever, and funcfailed was what you'd catch if you were calling exec_func/exec_task. that is, it's what those functions raise, not what metadata functions should be raising < kergoth> it didn't end up being used that way < kergoth> but there's really never a reason to raise it yourself FuncFailed.__init__ takes a 'name' argument rather than a 'msg' argument, which also shows that the original purpose got lost. (From OE-Core rev: 5369bb7fa6238cc85f0b5263519974c1a2d9eea8) Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta')
-rw-r--r--meta/classes/libc-package.bbclass2
1 files changed, 1 insertions, 1 deletions
diff --git a/meta/classes/libc-package.bbclass b/meta/classes/libc-package.bbclass
index 8c99d6113d..4d17ff90c0 100644
--- a/meta/classes/libc-package.bbclass
+++ b/meta/classes/libc-package.bbclass
@@ -260,7 +260,7 @@ python package_do_split_gconvs () {
260 localedef_opts = locale_arch_options[target_arch] 260 localedef_opts = locale_arch_options[target_arch]
261 else: 261 else:
262 bb.error("locale_arch_options not found for target_arch=" + target_arch) 262 bb.error("locale_arch_options not found for target_arch=" + target_arch)
263 raise bb.build.FuncFailed("unknown arch:" + target_arch + " for locale_arch_options") 263 bb.fatal("unknown arch:" + target_arch + " for locale_arch_options")
264 264
265 localedef_opts += " --force --no-archive --prefix=%s \ 265 localedef_opts += " --force --no-archive --prefix=%s \
266 --inputfile=%s/%s/i18n/locales/%s --charmap=%s %s/%s" \ 266 --inputfile=%s/%s/i18n/locales/%s --charmap=%s %s/%s" \