summaryrefslogtreecommitdiffstats
path: root/meta
diff options
context:
space:
mode:
authorSaul Wold <sgw@linux.intel.com>2013-05-23 10:13:09 -0700
committerRichard Purdie <richard.purdie@linuxfoundation.org>2013-05-24 14:14:47 +0100
commit39214157dafb806f31d2446b7f410cc5f8aa194b (patch)
treed87a1f4b2b3fa0ea1a447ebfadaa2a555b099508 /meta
parentefbb9f83ffca344d7b6115c35a0e609ed89eee7f (diff)
downloadpoky-39214157dafb806f31d2446b7f410cc5f8aa194b.tar.gz
binutils: the cat should always succeed when building config.cache
There is a race condition between when the CONFIG_SITE list is generated and then used here via the cat to create the config.cache and in *all* configure scripts when reading from CONFIG_SITE. The race in this case is that the sstate setscene task runs on a package that contains a site config file (ncurses in this case) and then bitbake decides that it needs to rebuild and cleans out the site config file, so it existed for siteinfo_get_files() to find in SITECONFIG_SYSROOTCACHE and then was removed for the rebuild. When bintuils tried to run the do_configure() task which creates the binutil's version of config.cache it reads from CONFIG_SITE which now contains the non-existant site config file. (confused yet ;-)? Currently the configure script does a test -r to ensure the file is readable before using it, therefore having the cat succeed regardless of the file being available is consistent behaviour. (From OE-Core rev: ffd8f05e5548500199c9b04a174067811ad2c5e7) Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta')
-rw-r--r--meta/recipes-devtools/binutils/binutils.inc2
1 files changed, 1 insertions, 1 deletions
diff --git a/meta/recipes-devtools/binutils/binutils.inc b/meta/recipes-devtools/binutils/binutils.inc
index 1e592962ee..5e78dc03df 100644
--- a/meta/recipes-devtools/binutils/binutils.inc
+++ b/meta/recipes-devtools/binutils/binutils.inc
@@ -90,7 +90,7 @@ do_configure () {
90# 90#
91 mkdir -p ${B}/build-${BUILD_SYS} 91 mkdir -p ${B}/build-${BUILD_SYS}
92 for i in ${CONFIG_SITE}; do 92 for i in ${CONFIG_SITE}; do
93 cat $i >> ${B}/build-${BUILD_SYS}/config.cache 93 cat $i >> ${B}/build-${BUILD_SYS}/config.cache || true
94 done 94 done
95} 95}
96 96