diff options
author | Richard Purdie <richard.purdie@linuxfoundation.org> | 2021-12-08 23:51:32 +0000 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2021-12-09 10:33:25 +0000 |
commit | 67664c51c7fb24f3404557c3d7c8de03ee438460 (patch) | |
tree | e2af3dc9b9e7ba2bad3c934a0d48abd96dbaed24 /meta/recipes-sato/puzzles/files/fix-compiling-failure-with-option-g-O.patch | |
parent | 8231454281bb2ed01dce606fc3f6347cc5cea879 (diff) | |
download | poky-67664c51c7fb24f3404557c3d7c8de03ee438460.tar.gz |
puzzles: Refresh patches based upon upstream discussion
I mentioned these patches to upstream and this cleans them up based upon
our discussion with better fixes, fixed comments and tracking down the correct
issue in the malloc case.
If we can test and confirm them in this form, we should be in a good position
to resovle the issues with upstream and be able to drop the patches ultimately.
(From OE-Core rev: 87e6a2715b1dcd5b03d9d6eb0fd0feacc5710e7a)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/recipes-sato/puzzles/files/fix-compiling-failure-with-option-g-O.patch')
-rw-r--r-- | meta/recipes-sato/puzzles/files/fix-compiling-failure-with-option-g-O.patch | 33 |
1 files changed, 11 insertions, 22 deletions
diff --git a/meta/recipes-sato/puzzles/files/fix-compiling-failure-with-option-g-O.patch b/meta/recipes-sato/puzzles/files/fix-compiling-failure-with-option-g-O.patch index 28040523d4..4ee7543166 100644 --- a/meta/recipes-sato/puzzles/files/fix-compiling-failure-with-option-g-O.patch +++ b/meta/recipes-sato/puzzles/files/fix-compiling-failure-with-option-g-O.patch | |||
@@ -1,17 +1,9 @@ | |||
1 | From 876c6ff1e20f51b0921acda99861f476b6423f26 Mon Sep 17 00:00:00 2001 | ||
2 | From: Hongxu Jia <hongxu.jia@windriver.com> | 1 | From: Hongxu Jia <hongxu.jia@windriver.com> |
3 | Date: Mon, 11 Aug 2014 12:39:53 +0800 | ||
4 | Subject: [PATCH] gtk.c: fix compiling failure with option -g -O | ||
5 | 2 | ||
6 | There were compiling failure with option -g -O | 3 | gtk.c: fix compiling failure with option -g -O |
4 | |||
5 | There was a compile failure with option -g -O | ||
7 | ... | 6 | ... |
8 | ././gtk.c: In function 'configure_area': | ||
9 | ././gtk.c:397:2: error: 'cr' may be used uninitialized in this function [-Werror=maybe-uninitialized] | ||
10 | cairo_set_source_rgb(cr, | ||
11 | ^ | ||
12 | ././gtk.c:384:14: note: 'cr' was declared here | ||
13 | cairo_t *cr; | ||
14 | ^ | ||
15 | ././gtk.c: In function 'main': | 7 | ././gtk.c: In function 'main': |
16 | ././gtk.c:2911:6: error: 'error' may be used uninitialized in this function [-Werror=maybe-uninitialized] | 8 | ././gtk.c:2911:6: error: 'error' may be used uninitialized in this function [-Werror=maybe-uninitialized] |
17 | fprintf(stderr, "%s: %s\n", pname, error); | 9 | fprintf(stderr, "%s: %s\n", pname, error); |
@@ -19,21 +11,18 @@ There were compiling failure with option -g -O | |||
19 | cc1: all warnings being treated as errors | 11 | cc1: all warnings being treated as errors |
20 | ... | 12 | ... |
21 | 13 | ||
22 | Initialized pointer 'cr' and 'error' with NULL | 14 | Fix by initializing pointer 'error' with NULL |
23 | 15 | ||
24 | Upstream-Status: Pending | 16 | Upstream-Status: Submitted [email discussion with upstream] |
25 | 17 | ||
18 | Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> | ||
26 | Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> | 19 | Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> |
27 | 20 | ||
28 | --- | 21 | Index: git/gtk.c |
29 | gtk.c | 2 +- | 22 | =================================================================== |
30 | 1 file changed, 1 insertion(+), 1 deletion(-) | 23 | --- git.orig/gtk.c |
31 | 24 | +++ git/gtk.c | |
32 | diff --git a/gtk.c b/gtk.c | 25 | @@ -3578,7 +3578,7 @@ static void list_presets_from_menu(struc |
33 | index 4565836..5e83b48 100644 | ||
34 | --- a/gtk.c | ||
35 | +++ b/gtk.c | ||
36 | @@ -2944,7 +2944,7 @@ static void list_presets_from_menu(struct preset_menu *menu) | ||
37 | int main(int argc, char **argv) | 26 | int main(int argc, char **argv) |
38 | { | 27 | { |
39 | char *pname = argv[0]; | 28 | char *pname = argv[0]; |