tiff: fix CVE-2019-6128

(From OE-Core rev: 7293e417dd9bdd04fe0fec177a76c9286234ed46)

(From OE-Core rev: c4fcc2dfefb304ac59f8c49acaad149e239de260)

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

2 files changed, 53 insertions, 1 deletions

diff --git a/meta/recipes-multimedia/libtiff/tiff/CVE-2019-6128.patch b/meta/recipes-multimedia/libtiff/tiff/CVE-2019-6128.patch
new file mode 100644
index 0000000000..6f1fd4d447
--- /dev/null
+++ b/meta/recipes-multimedia/libtiff/tiff/CVE-2019-6128.patch
@@ -0,0 +1,52 @@
+CVE: CVE-2019-6128
+Upstream-Status: Backport
+Signed-off-by: Ross Burton <ross.burton@intel.com>
+
+From 0c74a9f49b8d7a36b17b54a7428b3526d20f88a8 Mon Sep 17 00:00:00 2001
+From: Scott Gayou <github.scott@gmail.com>
+Date: Wed, 23 Jan 2019 15:03:53 -0500
+Subject: [PATCH] Fix for simple memory leak that was assigned CVE-2019-6128.
+
+pal2rgb failed to free memory on a few errors. This was reported
+here: http://bugzilla.maptools.org/show_bug.cgi?id=2836.
+---
+ tools/pal2rgb.c | 7 ++++++-
+ 1 file changed, 6 insertions(+), 1 deletion(-)
+
+diff --git a/tools/pal2rgb.c b/tools/pal2rgb.c
+index 01d8502ec..9492f1cf1 100644
+--- a/tools/pal2rgb.c
++++ b/tools/pal2rgb.c
+@@ -118,12 +118,14 @@ main(int argc, char* argv[])
+            shortv != PHOTOMETRIC_PALETTE) {
+                fprintf(stderr, "%s: Expecting a palette image.\n",
+                    argv[optind]);
++               (void) TIFFClose(in);
+                return (-1);
+        }
+        if (!TIFFGetField(in, TIFFTAG_COLORMAP, &rmap, &gmap, &bmap)) {
+                fprintf(stderr,
+                    "%s: No colormap (not a valid palette image).\n",
+                    argv[optind]);
++               (void) TIFFClose(in);
+                return (-1);
+        }
+        bitspersample = 0;
+@@ -131,11 +133,14 @@ main(int argc, char* argv[])
+        if (bitspersample != 8) {
+                fprintf(stderr, "%s: Sorry, can only handle 8-bit images.\n",
+                    argv[optind]);
++               (void) TIFFClose(in);
+                return (-1);
+        }
+        out = TIFFOpen(argv[optind+1], "w");
+-       if (out == NULL)
++       if (out == NULL) {
++               (void) TIFFClose(in);
+                return (-2);
++       }
+        cpTags(in, out);
+        TIFFGetField(in, TIFFTAG_IMAGEWIDTH, &imagewidth);
+        TIFFGetField(in, TIFFTAG_IMAGELENGTH, &imagelength);
+-- 
+2.21.0
diff --git a/meta/recipes-multimedia/libtiff/tiff_4.0.10.bb b/meta/recipes-multimedia/libtiff/tiff_4.0.10.bb
index 152fa819a5..a82d74498e 100644
--- a/meta/recipes-multimedia/libtiff/tiff_4.0.10.bb
+++ b/meta/recipes-multimedia/libtiff/tiff_4.0.10.bb
@@ -6,8 +6,8 @@ CVE_PRODUCT = "libtiff"
 
 SRC_URI = "http://download.osgeo.org/libtiff/tiff-${PV}.tar.gz \
            file://libtool2.patch \
+           file://CVE-2019-6128.patch"
            "
-
 SRC_URI[md5sum] = "114192d7ebe537912a2b97408832e7fd"
 SRC_URI[sha256sum] = "2c52d11ccaf767457db0c46795d9c7d1a8d8f76f68b0b800a3dfe45786b996e4"