diff options
author | Nitin A Kamble <nitin.a.kamble@intel.com> | 2011-01-20 17:15:36 -0800 |
---|---|---|
committer | Saul Wold <sgw@linux.intel.com> | 2011-01-24 14:09:12 -0800 |
commit | 1ef70572f9480d14e945aae5197d24d1ce1bdf9c (patch) | |
tree | 068c487f2ec77739be3b52326a2279e164858c4a /meta/recipes-multimedia/musicbrainz/libmusicbrainz-3.0.3 | |
parent | 57392afdbb0daf79a42c9a7a6814145715582289 (diff) | |
download | poky-1ef70572f9480d14e945aae5197d24d1ce1bdf9c.tar.gz |
libmusicbrainz: revert the dso_linking_change patch as the new linker fixes it
The newer binutils recipe of version 2.21 has a fix for ld which avoids an
issue where weak symbols like pthread_cancel were causing linking to fail when
--no-add-as-needed parameter was passed to ld.
See more information here: http://bugs.debian.org/591405
This makes some of the fixes for breakage after gcc dso linking change
unnecessary and this is one of them.
Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
Diffstat (limited to 'meta/recipes-multimedia/musicbrainz/libmusicbrainz-3.0.3')
-rw-r--r-- | meta/recipes-multimedia/musicbrainz/libmusicbrainz-3.0.3/dso_linking_change_build_fix.patch | 29 |
1 files changed, 0 insertions, 29 deletions
diff --git a/meta/recipes-multimedia/musicbrainz/libmusicbrainz-3.0.3/dso_linking_change_build_fix.patch b/meta/recipes-multimedia/musicbrainz/libmusicbrainz-3.0.3/dso_linking_change_build_fix.patch deleted file mode 100644 index 5f0cce2e1e..0000000000 --- a/meta/recipes-multimedia/musicbrainz/libmusicbrainz-3.0.3/dso_linking_change_build_fix.patch +++ /dev/null | |||
@@ -1,29 +0,0 @@ | |||
1 | dso build fix: | ||
2 | With a dso patch for gcc, which prevents automatic linking of unspecified libraries, | ||
3 | this recipe fails to compile with this error: | ||
4 | |||
5 | | Linking CXX executable cdlookup^M | ||
6 | | cd /disk0/pokybuild/build1/tmp/work/i586-poky-linux/libmusicbrainz-3.0.3-r0/libmusicbrainz-3.0.3/examples && /disk0/pokybuild/build1/tmp/sysroots/x86_64-linux/usr/bin/cmake -E cmake_link_script CMakeFiles/cdlookup.dir/link.txt --verbose=1^M | ||
7 | | /disk0/pokybuild/build1/tmp/sysroots/x86_64-linux/usr/bin/i586-poky-linux/i586-poky-linux-g++ -march=i586 --sysroot=/disk0/pokybuild/build1/tmp/sysroots/i586-poky-linux -fpermissive -Wl,-O1 -Wl,--as-needed CMakeFiles/cdlookup.dir/cdlookup.cpp.o -o cdlookup -rdynamic ../src/libmusicbrainz3.so.6.3.0 -lneon -Wl,-rpath,/disk0/pokybuild/build1/tmp/work/i586-poky-linux/libmusicbrainz-3.0.3-r0/libmusicbrainz-3.0.3/src^M | ||
8 | | /disk0/pokybuild/build1/tmp/sysroots/x86_64-linux/usr/libexec/i586-poky-linux/gcc/i586-poky-linux/4.5.1/ld: ~I: invalid DSO for symbol `pthread_cancel@@GLIBC_2.0' definition^M | ||
9 | | /disk0/pokybuild/build1/tmp/sysroots/i586-poky-linux/lib/libpthread.so.0: could not read symbols: Bad value^M | ||
10 | | collect2: ld returned 1 exit status^M | ||
11 | | make[2]: *** [examples/cdlookup] Error 1^M | ||
12 | | make[2]: Leaving directory `/disk0/pokybuild/build1/tmp/work/i586-poky-linux/libmusicbrainz-3.0.3-r0/libmusicbrainz-3.0.3' | ||
13 | |||
14 | fixing the issue by making linking of libpthread explicit. | ||
15 | |||
16 | Nitin A Kamble <nitin.a.kamble@intel.com> | ||
17 | Date: 2011/01/10 | ||
18 | |||
19 | Index: libmusicbrainz-3.0.3/examples/CMakeLists.txt | ||
20 | =================================================================== | ||
21 | --- libmusicbrainz-3.0.3.orig/examples/CMakeLists.txt | ||
22 | +++ libmusicbrainz-3.0.3/examples/CMakeLists.txt | ||
23 | @@ -1,5 +1,5 @@ | ||
24 | INCLUDE_DIRECTORIES(${CMAKE_CURRENT_SOURCE_DIR}/../include) | ||
25 | -LINK_LIBRARIES(musicbrainz3 ${NEON_LIBRARIES}) | ||
26 | +LINK_LIBRARIES(musicbrainz3 ${NEON_LIBRARIES} pthread) | ||
27 | ADD_EXECUTABLE(cdlookup cdlookup.cpp) | ||
28 | ADD_EXECUTABLE(findartist findartist.cpp) | ||
29 | ADD_EXECUTABLE(findtrack findtrack.cpp) | ||