diff options
author | Andre McCurdy <armccurdy@gmail.com> | 2016-02-10 14:05:36 -0800 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2016-02-11 22:33:39 +0000 |
commit | fdd89795e22ca2e1613aee9bfa199f77deef8448 (patch) | |
tree | cb586bbae9a73226d1942f5ba0af9a7faffa9d18 /meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_git.bb | |
parent | a23a50ee01f72b1ae2f30bbb5697c597e02e3e2f (diff) | |
download | poky-fdd89795e22ca2e1613aee9bfa199f77deef8448.tar.gz |
gstreamer1.0-plugins-good_git: fix gst_structure_get() compiler warning
| ../../../gst-plugins-good-1.7.1/ext/taglib/gstid3v2mux.cc: In function 'void add_image_tag(TagLib::ID3v2::Tag*, const GstTagList*, const gchar*, guint, const gchar*)':
| ../../../gst-plugins-good-1.7.1/ext/taglib/gstid3v2mux.cc:468:63: error: missing sentinel in function call [-Werror=format=]
| GST_TYPE_TAG_IMAGE_TYPE, &image_type, NULL)) {
| ^
| cc1plus: all warnings being treated as errors
gst_structure_get() is declared with G_GNUC_NULL_TERMINATED, ie
__attribute__((__sentinel__)), which means gcc will generate a
warning if the last parameter passed to the function is not NULL
(where a valid NULL in this context is defined as zero with any
pointer type).
The C code callers to gst_structure_get() within gst-plugins-good
use the C NULL definition (ie ((void*)0)), which is a valid sentinel.
However gstid3v2mux.cc uses the C++ NULL definition (ie 0L), which
is not a valid sentinel without an explicit cast to a pointer type.
(From OE-Core rev: 91c4b8278da274a8bc1213b7cd51a1a372f218d3)
Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_git.bb')
-rw-r--r-- | meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_git.bb | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_git.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_git.bb index 20dfb8349e..e3a2019b41 100644 --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_git.bb +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_git.bb | |||
@@ -11,6 +11,7 @@ SRC_URI = " \ | |||
11 | git://anongit.freedesktop.org/gstreamer/common;destsuffix=git/common;name=common \ | 11 | git://anongit.freedesktop.org/gstreamer/common;destsuffix=git/common;name=common \ |
12 | file://fix-maybe-uninitialized-warnings-when-compiling-with-Os.patch \ | 12 | file://fix-maybe-uninitialized-warnings-when-compiling-with-Os.patch \ |
13 | file://avoid-including-sys-poll.h-directly.patch \ | 13 | file://avoid-including-sys-poll.h-directly.patch \ |
14 | file://ensure-valid-sentinel-for-gst_structure_get.patch \ | ||
14 | " | 15 | " |
15 | 16 | ||
16 | PV = "1.7.1+git${SRCPV}" | 17 | PV = "1.7.1+git${SRCPV}" |