diff options
author | Ovidiu Panait <ovidiu.panait@windriver.com> | 2019-04-05 14:19:42 +0300 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2019-04-09 13:44:39 +0100 |
commit | a1fb2c59e82fd5ccc1d8ae649af7f1979cee3939 (patch) | |
tree | a9c0eb8e42bb23552f3597e9e01f422fec97b5ea /meta/recipes-graphics | |
parent | e605e2d0488d3923e9b89855e26b07cc55668c62 (diff) | |
download | poky-a1fb2c59e82fd5ccc1d8ae649af7f1979cee3939.tar.gz |
xf86-video-vesa: Refuse to run on UEFI machines
Fix the following Xorg start failure on UEFI machines when using xf86-video-vesa
driver (e.g. in qemu, when anaconda tries to start X):
Xorg -br -logfile /tmp/X.log :1 vt7 -s 1440 -ac -nolisten tcp -dpi 96 -noreset
...
(EE) Cannot run in framebuffer mode. Please specify busIDs for all framebuffer devices
...
Upstream patch:
https://cgit.freedesktop.org/xorg/driver/xf86-video-vesa/commit/?id=2645e0aa9c17c2c966a0533e52ad00510311483e
(From OE-Core rev: 25edd39d752876a2894ddbbe396c3b037519f9f1)
Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/recipes-graphics')
-rw-r--r-- | meta/recipes-graphics/xorg-driver/xf86-video-vesa/0001-Refuse-to-run-on-UEFI-machines.patch | 52 | ||||
-rw-r--r-- | meta/recipes-graphics/xorg-driver/xf86-video-vesa_2.4.0.bb | 4 |
2 files changed, 56 insertions, 0 deletions
diff --git a/meta/recipes-graphics/xorg-driver/xf86-video-vesa/0001-Refuse-to-run-on-UEFI-machines.patch b/meta/recipes-graphics/xorg-driver/xf86-video-vesa/0001-Refuse-to-run-on-UEFI-machines.patch new file mode 100644 index 0000000000..9e01770667 --- /dev/null +++ b/meta/recipes-graphics/xorg-driver/xf86-video-vesa/0001-Refuse-to-run-on-UEFI-machines.patch | |||
@@ -0,0 +1,52 @@ | |||
1 | From 2645e0aa9c17c2c966a0533e52ad00510311483e Mon Sep 17 00:00:00 2001 | ||
2 | From: Adam Jackson <ajax@redhat.com> | ||
3 | Date: Wed, 29 Aug 2018 11:04:23 -0400 | ||
4 | Subject: [PATCH] Refuse to run on UEFI machines | ||
5 | |||
6 | No possible good can come of this. | ||
7 | |||
8 | v2: Check for .../efi-framebuffer.0 ("is there an EFI framebuffer") | ||
9 | instead of /sys/firmware/efi ("is this an EFI machine"). Suggested by | ||
10 | Peter Jones. | ||
11 | |||
12 | Upstream-Status: Backport [https://gitlab.freedesktop.org/xorg/driver/xf86-video-vesa] | ||
13 | |||
14 | Reviewed-by: Peter Jones <pjones@redhat.com> | ||
15 | Signed-off-by: Adam Jackson <ajax@redhat.com> | ||
16 | Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com> | ||
17 | --- | ||
18 | src/vesa.c | 11 +++++++++-- | ||
19 | 1 file changed, 9 insertions(+), 2 deletions(-) | ||
20 | |||
21 | diff --git a/src/vesa.c b/src/vesa.c | ||
22 | index 9b65b9b..af750e2 100644 | ||
23 | --- a/src/vesa.c | ||
24 | +++ b/src/vesa.c | ||
25 | @@ -43,7 +43,7 @@ | ||
26 | #endif | ||
27 | |||
28 | #include <string.h> | ||
29 | - | ||
30 | +#include <unistd.h> | ||
31 | #include "vesa.h" | ||
32 | |||
33 | /* All drivers initialising the SW cursor need this */ | ||
34 | @@ -450,7 +450,14 @@ VESAPciProbe(DriverPtr drv, int entity_num, struct pci_device *dev, | ||
35 | intptr_t match_data) | ||
36 | { | ||
37 | ScrnInfoPtr pScrn; | ||
38 | - | ||
39 | + | ||
40 | +#ifdef __linux__ | ||
41 | + if (access("/sys/devices/platform/efi-framebuffer.0", F_OK) == 0) { | ||
42 | + ErrorF("vesa: Refusing to run on UEFI\n"); | ||
43 | + return FALSE; | ||
44 | + } | ||
45 | +#endif | ||
46 | + | ||
47 | pScrn = xf86ConfigPciEntity(NULL, 0, entity_num, NULL, | ||
48 | NULL, NULL, NULL, NULL, NULL); | ||
49 | if (pScrn != NULL) { | ||
50 | -- | ||
51 | 2.20.1 | ||
52 | |||
diff --git a/meta/recipes-graphics/xorg-driver/xf86-video-vesa_2.4.0.bb b/meta/recipes-graphics/xorg-driver/xf86-video-vesa_2.4.0.bb index 9a110148d8..f6aa54456c 100644 --- a/meta/recipes-graphics/xorg-driver/xf86-video-vesa_2.4.0.bb +++ b/meta/recipes-graphics/xorg-driver/xf86-video-vesa_2.4.0.bb | |||
@@ -17,3 +17,7 @@ RRECOMMENDS_${PN} += "xserver-xorg-module-libint10" | |||
17 | 17 | ||
18 | SRC_URI[md5sum] = "8134201beaf6f77150c7809c3cc802e6" | 18 | SRC_URI[md5sum] = "8134201beaf6f77150c7809c3cc802e6" |
19 | SRC_URI[sha256sum] = "bf443c94d7bf6cd4e248f8a3147f4647be04dc4c80250d9405006263bbdee38c" | 19 | SRC_URI[sha256sum] = "bf443c94d7bf6cd4e248f8a3147f4647be04dc4c80250d9405006263bbdee38c" |
20 | |||
21 | SRC_URI += " \ | ||
22 | file://0001-Refuse-to-run-on-UEFI-machines.patch \ | ||
23 | " | ||