diff options
author | Ross Burton <ross.burton@intel.com> | 2018-03-21 14:47:29 +0000 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2018-03-25 09:40:42 +0100 |
commit | ed2dc5f03aa46013ae05a1802d42a3a5ec10845d (patch) | |
tree | 1ab4d355f65f03db31345633a5f8f06b77f78ad8 /meta/recipes-gnome/gtk-doc/files | |
parent | dea2b8225031f1fa0f136ddac1fb0122ab1d81ba (diff) | |
download | poky-ed2dc5f03aa46013ae05a1802d42a3a5ec10845d.tar.gz |
gtk-doc: don't regenerate gtk-doc in do_install
In out-of-tree builds gtk-doc's setup-build target copies all the content from
$srcdir to $builddir. However, if some of this content is regenerated at
configure time this can happen:
1) configure writes new build/version.xml
2) make compile copies content, including the tarball's src/version.xml
to build/version.xml, and generates gtk-doc.
3) make install notices build/version.xml is older than configure.status,
so regenerates gtk-doc.
gtk-doc generation is a slow process at the best of times, so doing it twice
isn't good.
(From OE-Core rev: 9ea9d61f26a942dbbc90070b40ba0209021a4b46)
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/recipes-gnome/gtk-doc/files')
-rw-r--r-- | meta/recipes-gnome/gtk-doc/files/no-clobber.patch | 27 |
1 files changed, 27 insertions, 0 deletions
diff --git a/meta/recipes-gnome/gtk-doc/files/no-clobber.patch b/meta/recipes-gnome/gtk-doc/files/no-clobber.patch new file mode 100644 index 0000000000..0fa22b2097 --- /dev/null +++ b/meta/recipes-gnome/gtk-doc/files/no-clobber.patch | |||
@@ -0,0 +1,27 @@ | |||
1 | In out-of-tree builds gtk-doc's setup-build target copies all the content from $srcdir to $builddir. | ||
2 | |||
3 | However, if some of this content is regenerated at configure time this can happen: | ||
4 | |||
5 | 1) configure writes new build/version.xml | ||
6 | 2) make compile copies content, including the tarball's src/version.xml | ||
7 | to build/version.xml, and generates gtk-doc. | ||
8 | 3) make install notices build/version.xml is older than configure.status, | ||
9 | so regenerates gtk-doc. | ||
10 | |||
11 | gtk-doc generation is a slow process at the best of times, so doing it twice isn't good. | ||
12 | |||
13 | Solve this by changing cp --force to cp --no-clobber, so setup-build only copies | ||
14 | files which don't already exist. | ||
15 | |||
16 | Upstream-Status: Submitted [https://bugzilla.gnome.org/show_bug.cgi?id=794571] | ||
17 | Signed-off-by: Ross Burton <ross.burton@intel.com> | ||
18 | |||
19 | diff --git a/gtk-doc.make b/gtk-doc.make | ||
20 | index f87eaab..246f3c0 100644 | ||
21 | --- a/gtk-doc.make | ||
22 | +++ b/gtk-doc.make | ||
23 | @@ -113,3 +113,3 @@ setup-build.stamp: | ||
24 | test -f $(abs_srcdir)/$$file && \ | ||
25 | - cp -pf $(abs_srcdir)/$$file $(abs_builddir)/$$file || true; \ | ||
26 | + cp -pn $(abs_srcdir)/$$file $(abs_builddir)/$$file || true; \ | ||
27 | done; \ | ||