summaryrefslogtreecommitdiffstats
path: root/meta/recipes-extended
diff options
context:
space:
mode:
authorAlexander Kanavin <alex.kanavin@gmail.com>2022-08-19 09:26:52 +0200
committerRichard Purdie <richard.purdie@linuxfoundation.org>2022-08-21 22:51:42 +0100
commit304d1c917e61a6827e05333a556650a74b2145ac (patch)
tree09653ecb6aa72af29fd5ecfe446dc5b5d6c8b3d7 /meta/recipes-extended
parent7089bc24b4489663169b86d85bfc67a3332a6c11 (diff)
downloadpoky-304d1c917e61a6827e05333a556650a74b2145ac.tar.gz
xz: update 5.2.5 -> 5.2.6
(From OE-Core rev: 7e3782f4d66973cb7ab922d4bbc6ef6241756ed2) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/recipes-extended')
-rw-r--r--meta/recipes-extended/xz/xz/CVE-2022-1271.patch96
-rw-r--r--meta/recipes-extended/xz/xz_5.2.6.bb (renamed from meta/recipes-extended/xz/xz_5.2.5.bb)7
2 files changed, 2 insertions, 101 deletions
diff --git a/meta/recipes-extended/xz/xz/CVE-2022-1271.patch b/meta/recipes-extended/xz/xz/CVE-2022-1271.patch
deleted file mode 100644
index e43e73cf12..0000000000
--- a/meta/recipes-extended/xz/xz/CVE-2022-1271.patch
+++ /dev/null
@@ -1,96 +0,0 @@
1From dc932a1e9c0d9f1db71be11a9b82496e3a72f112 Mon Sep 17 00:00:00 2001
2From: Lasse Collin <lasse.collin@tukaani.org>
3Date: Tue, 29 Mar 2022 19:19:12 +0300
4Subject: [PATCH] xzgrep: Fix escaping of malicious filenames (ZDI-CAN-16587).
5
6Malicious filenames can make xzgrep to write to arbitrary files
7or (with a GNU sed extension) lead to arbitrary code execution.
8
9xzgrep from XZ Utils versions up to and including 5.2.5 are
10affected. 5.3.1alpha and 5.3.2alpha are affected as well.
11This patch works for all of them.
12
13This bug was inherited from gzip's zgrep. gzip 1.12 includes
14a fix for zgrep.
15
16The issue with the old sed script is that with multiple newlines,
17the N-command will read the second line of input, then the
18s-commands will be skipped because it's not the end of the
19file yet, then a new sed cycle starts and the pattern space
20is printed and emptied. So only the last line or two get escaped.
21
22One way to fix this would be to read all lines into the pattern
23space first. However, the included fix is even simpler: All lines
24except the last line get a backslash appended at the end. To ensure
25that shell command substitution doesn't eat a possible trailing
26newline, a colon is appended to the filename before escaping.
27The colon is later used to separate the filename from the grep
28output so it is fine to add it here instead of a few lines later.
29
30The old code also wasn't POSIX compliant as it used \n in the
31replacement section of the s-command. Using \<newline> is the
32POSIX compatible method.
33
34LC_ALL=C was added to the two critical sed commands. POSIX sed
35manual recommends it when using sed to manipulate pathnames
36because in other locales invalid multibyte sequences might
37cause issues with some sed implementations. In case of GNU sed,
38these particular sed scripts wouldn't have such problems but some
39other scripts could have, see:
40
41 info '(sed)Locale Considerations'
42
43This vulnerability was discovered by:
44cleemy desu wayo working with Trend Micro Zero Day Initiative
45
46Thanks to Jim Meyering and Paul Eggert discussing the different
47ways to fix this and for coordinating the patch release schedule
48with gzip.
49
50Upstream-Status: Backport [https://tukaani.org/xz/xzgrep-ZDI-CAN-16587.patch]
51CVE: CVE-2022-1271
52
53Signed-off-by: Ralph Siemsen <ralph.siemsen@linaro.org>
54---
55 src/scripts/xzgrep.in | 20 ++++++++++++--------
56 1 file changed, 12 insertions(+), 8 deletions(-)
57
58diff --git a/src/scripts/xzgrep.in b/src/scripts/xzgrep.in
59index 9db5c3a..f64dddb 100644
60--- a/src/scripts/xzgrep.in
61+++ b/src/scripts/xzgrep.in
62@@ -179,22 +179,26 @@ for i; do
63 { test $# -eq 1 || test $no_filename -eq 1; }; then
64 eval "$grep"
65 else
66+ # Append a colon so that the last character will never be a newline
67+ # which would otherwise get lost in shell command substitution.
68+ i="$i:"
69+
70+ # Escape & \ | and newlines only if such characters are present
71+ # (speed optimization).
72 case $i in
73 (*'
74 '* | *'&'* | *'\'* | *'|'*)
75- i=$(printf '%s\n' "$i" |
76- sed '
77- $!N
78- $s/[&\|]/\\&/g
79- $s/\n/\\n/g
80- ');;
81+ i=$(printf '%s\n' "$i" | LC_ALL=C sed 's/[&\|]/\\&/g; $!s/$/\\/');;
82 esac
83- sed_script="s|^|$i:|"
84+
85+ # $i already ends with a colon so don't add it here.
86+ sed_script="s|^|$i|"
87
88 # Fail if grep or sed fails.
89 r=$(
90 exec 4>&1
91- (eval "$grep" 4>&-; echo $? >&4) 3>&- | sed "$sed_script" >&3 4>&-
92+ (eval "$grep" 4>&-; echo $? >&4) 3>&- |
93+ LC_ALL=C sed "$sed_script" >&3 4>&-
94 ) || r=2
95 exit $r
96 fi >&3 5>&-
diff --git a/meta/recipes-extended/xz/xz_5.2.5.bb b/meta/recipes-extended/xz/xz_5.2.6.bb
index 720e070f4a..3482622471 100644
--- a/meta/recipes-extended/xz/xz_5.2.5.bb
+++ b/meta/recipes-extended/xz/xz_5.2.6.bb
@@ -24,11 +24,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=97d554a32881fee0aa283d96e47cb24a \
24 file://lib/getopt.c;endline=23;md5=2069b0ee710572c03bb3114e4532cd84 \ 24 file://lib/getopt.c;endline=23;md5=2069b0ee710572c03bb3114e4532cd84 \
25 " 25 "
26 26
27SRC_URI = "https://tukaani.org/xz/xz-${PV}.tar.gz \ 27SRC_URI = "https://tukaani.org/xz/xz-${PV}.tar.gz"
28 file://CVE-2022-1271.patch \ 28SRC_URI[sha256sum] = "a2105abee17bcd2ebd15ced31b4f5eda6e17efd6b10f921a01cda4a44c91b3a0"
29 "
30SRC_URI[md5sum] = "0d270c997aff29708c74d53f599ef717"
31SRC_URI[sha256sum] = "f6f4910fd033078738bd82bfba4f49219d03b17eb0794eb91efbae419f4aba10"
32UPSTREAM_CHECK_REGEX = "xz-(?P<pver>\d+(\.\d+)+)\.tar" 29UPSTREAM_CHECK_REGEX = "xz-(?P<pver>\d+(\.\d+)+)\.tar"
33 30
34CACHED_CONFIGUREVARS += "gl_cv_posix_shell=/bin/sh" 31CACHED_CONFIGUREVARS += "gl_cv_posix_shell=/bin/sh"