diff options
author | Alexander Kanavin <alex.kanavin@gmail.com> | 2020-12-14 10:10:39 +0100 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2020-12-18 22:52:24 +0000 |
commit | c4c6bb89cfd083a294a5f760f9b8542b1d5e6715 (patch) | |
tree | 6fcd06f6505f244b7efdbf2c4a1c23096a27ebdc /meta/recipes-devtools | |
parent | cd8f510a183d9c81f67a56fe0580cd474d189297 (diff) | |
download | poky-c4c6bb89cfd083a294a5f760f9b8542b1d5e6715.tar.gz |
valgrind: exclude bar_bad/bar_bad_xml from ptests
The tests' output is non-deterministic and sometimes
doesn't match the sample output. This has been reported at
https://bugs.kde.org/show_bug.cgi?id=430321
(see also an earlier related bug https://bugs.kde.org/show_bug.cgi?id=358213)
Until upstream figures out how to fix this, let's not run the tests.
(From OE-Core rev: 7f7d2fa18267090891754d976cbc3e628324d3dd)
Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/recipes-devtools')
4 files changed, 14 insertions, 2 deletions
diff --git a/meta/recipes-devtools/valgrind/valgrind/remove-for-aarch64 b/meta/recipes-devtools/valgrind/valgrind/remove-for-aarch64 index a3a0c6e50f..93bfd45a4e 100644 --- a/meta/recipes-devtools/valgrind/valgrind/remove-for-aarch64 +++ b/meta/recipes-devtools/valgrind/valgrind/remove-for-aarch64 | |||
@@ -31,8 +31,6 @@ drd/tests/annotate_static | |||
31 | drd/tests/annotate_trace_memory | 31 | drd/tests/annotate_trace_memory |
32 | drd/tests/annotate_trace_memory_xml | 32 | drd/tests/annotate_trace_memory_xml |
33 | drd/tests/atomic_var | 33 | drd/tests/atomic_var |
34 | drd/tests/bar_bad | ||
35 | drd/tests/bar_bad_xml | ||
36 | drd/tests/bar_trivial | 34 | drd/tests/bar_trivial |
37 | drd/tests/bug-235681 | 35 | drd/tests/bug-235681 |
38 | drd/tests/bug322621 | 36 | drd/tests/bug322621 |
diff --git a/meta/recipes-devtools/valgrind/valgrind/remove-for-all b/meta/recipes-devtools/valgrind/valgrind/remove-for-all new file mode 100644 index 0000000000..d6a85c4735 --- /dev/null +++ b/meta/recipes-devtools/valgrind/valgrind/remove-for-all | |||
@@ -0,0 +1,2 @@ | |||
1 | drd/tests/bar_bad | ||
2 | drd/tests/bar_bad_xml | ||
diff --git a/meta/recipes-devtools/valgrind/valgrind/run-ptest b/meta/recipes-devtools/valgrind/valgrind/run-ptest index 97b0a85dbf..7217dfca5d 100755 --- a/meta/recipes-devtools/valgrind/valgrind/run-ptest +++ b/meta/recipes-devtools/valgrind/valgrind/run-ptest | |||
@@ -17,6 +17,12 @@ EXP_TOOLS="exp-bbv exp-dhat exp-sgcheck" | |||
17 | GDB_BIN=@bindir@/gdb | 17 | GDB_BIN=@bindir@/gdb |
18 | cd ${VALGRIND_LIB}/ptest && ./gdbserver_tests/make_local_links ${GDB_BIN} | 18 | cd ${VALGRIND_LIB}/ptest && ./gdbserver_tests/make_local_links ${GDB_BIN} |
19 | 19 | ||
20 | echo "Hide valgrind tests that are non-deterministic" | ||
21 | echo "Reported at https://bugs.kde.org/show_bug.cgi?id=430321" | ||
22 | for i in `cat remove-for-all`; do | ||
23 | mv $i.vgtest $i.IGNORE; | ||
24 | done | ||
25 | |||
20 | arch=`arch` | 26 | arch=`arch` |
21 | if [ "$arch" = "aarch64" ]; then | 27 | if [ "$arch" = "aarch64" ]; then |
22 | echo "Aarch64: Hide valgrind tests that result in defunct process and then out of memory" | 28 | echo "Aarch64: Hide valgrind tests that result in defunct process and then out of memory" |
@@ -44,6 +50,10 @@ if [ "$arch" = "aarch64" ]; then | |||
44 | done | 50 | done |
45 | fi | 51 | fi |
46 | 52 | ||
53 | echo "Restore valgrind tests that are non-deterministc" | ||
54 | for i in `cat remove-for-all`; do | ||
55 | mv $i.IGNORE $i.vgtest; | ||
56 | done | ||
47 | 57 | ||
48 | passed=`grep PASS: ${LOG}|wc -l` | 58 | passed=`grep PASS: ${LOG}|wc -l` |
49 | failed=`grep FAIL: ${LOG}|wc -l` | 59 | failed=`grep FAIL: ${LOG}|wc -l` |
diff --git a/meta/recipes-devtools/valgrind/valgrind_3.16.1.bb b/meta/recipes-devtools/valgrind/valgrind_3.16.1.bb index 5db181ac14..25fa58249c 100644 --- a/meta/recipes-devtools/valgrind/valgrind_3.16.1.bb +++ b/meta/recipes-devtools/valgrind/valgrind_3.16.1.bb | |||
@@ -16,6 +16,7 @@ SRC_URI = "https://sourceware.org/pub/valgrind/valgrind-${PV}.tar.bz2 \ | |||
16 | file://Added-support-for-PPC-instructions-mfatbu-mfatbl.patch \ | 16 | file://Added-support-for-PPC-instructions-mfatbu-mfatbl.patch \ |
17 | file://run-ptest \ | 17 | file://run-ptest \ |
18 | file://remove-for-aarch64 \ | 18 | file://remove-for-aarch64 \ |
19 | file://remove-for-all \ | ||
19 | file://0004-Fix-out-of-tree-builds.patch \ | 20 | file://0004-Fix-out-of-tree-builds.patch \ |
20 | file://0005-Modify-vg_test-wrapper-to-support-PTEST-formats.patch \ | 21 | file://0005-Modify-vg_test-wrapper-to-support-PTEST-formats.patch \ |
21 | file://0001-Remove-tests-that-fail-to-build-on-some-PPC32-config.patch \ | 22 | file://0001-Remove-tests-that-fail-to-build-on-some-PPC32-config.patch \ |
@@ -186,6 +187,7 @@ do_install_ptest() { | |||
186 | # The scripts reference config.h so add it to the top ptest dir. | 187 | # The scripts reference config.h so add it to the top ptest dir. |
187 | cp ${B}/config.h ${D}${PTEST_PATH} | 188 | cp ${B}/config.h ${D}${PTEST_PATH} |
188 | install -D ${WORKDIR}/remove-for-aarch64 ${D}${PTEST_PATH} | 189 | install -D ${WORKDIR}/remove-for-aarch64 ${D}${PTEST_PATH} |
190 | install -D ${WORKDIR}/remove-for-all ${D}${PTEST_PATH} | ||
189 | 191 | ||
190 | # Add an executable need by none/tests/bigcode | 192 | # Add an executable need by none/tests/bigcode |
191 | mkdir ${D}${PTEST_PATH}/perf | 193 | mkdir ${D}${PTEST_PATH}/perf |