summaryrefslogtreecommitdiffstats
path: root/meta/recipes-devtools/valgrind/valgrind
diff options
context:
space:
mode:
authorRobert Yang <liezhi.yang@windriver.com>2018-12-28 01:01:47 -0800
committerRichard Purdie <richard.purdie@linuxfoundation.org>2019-01-03 12:35:53 +0000
commit0e7c84b69e53b37dc2850e4060e99b805658e374 (patch)
tree9aba7bd73953ef44b3d67bd48610ef1b0faeb38c /meta/recipes-devtools/valgrind/valgrind
parentd7d492af8e0713eb31257135acf2b138ddb4de17 (diff)
downloadpoky-0e7c84b69e53b37dc2850e4060e99b805658e374.tar.gz
valgrind: Fix a race issue for libcoregrind.a
The libnolto_coregrind_a_OBJECTS is in libcoregrind_a_LIBADD, so the objects should be ready before generate libcoregrind.a, otherwise there would be failures: i586-poky-linux-ar: libnolto_coregrind_x86_linux_a-m_libcsetjmp.o: No such file or directory make[3]: *** [libcoregrind-x86-linux.a] Error 1 Add libnolto_coregrind_a_OBJECTS to EXTRA_libcoregrind_DEPENDENCIES to fix the problem. This is a race issue during parallel build. (From OE-Core rev: 713d6978894269e5b463c3731c03da7e83956743) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/recipes-devtools/valgrind/valgrind')
-rw-r--r--meta/recipes-devtools/valgrind/valgrind/0001-Fix-dependencies-between-libcoregrind-.a-and-m_main..patch45
1 files changed, 45 insertions, 0 deletions
diff --git a/meta/recipes-devtools/valgrind/valgrind/0001-Fix-dependencies-between-libcoregrind-.a-and-m_main..patch b/meta/recipes-devtools/valgrind/valgrind/0001-Fix-dependencies-between-libcoregrind-.a-and-m_main..patch
new file mode 100644
index 0000000000..bedf1c1274
--- /dev/null
+++ b/meta/recipes-devtools/valgrind/valgrind/0001-Fix-dependencies-between-libcoregrind-.a-and-m_main..patch
@@ -0,0 +1,45 @@
1From 7820fc268fae4353118b6355f1d4b9e1b7eeebec Mon Sep 17 00:00:00 2001
2From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
3Date: Sun, 28 Oct 2018 18:35:11 +0100
4Subject: [PATCH] Fix dependencies between libcoregrind*.a and
5 *m_main.o/*m_libcsetjmp.o
6
7The primary and secondary coregrind libraries must be updated
8when m_main.c or m_libcsetjmp.c are changed.
9
10A dependency was missing between libcoregrind*.a and libnolto_coregrind*.a,
11and so tools were not relinked when m_main.c or m_libcsetjmp.c were
12changed.
13
14Upstream-Status: Backport[git://sourceware.org/git/valgrind.git 7820fc268fae4353118b6355f1d4b9e1b7eeebec]
15
16Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
17---
18 coregrind/Makefile.am | 4 ++++
19 1 file changed, 4 insertions(+)
20
21diff --git a/coregrind/Makefile.am b/coregrind/Makefile.am
22index 914a270..8de1996 100644
23--- a/coregrind/Makefile.am
24+++ b/coregrind/Makefile.am
25@@ -511,6 +511,8 @@ libcoregrind_@VGCONF_ARCH_PRI@_@VGCONF_OS@_a_CFLAGS += \
26 endif
27 libcoregrind_@VGCONF_ARCH_PRI@_@VGCONF_OS@_a_LIBADD = \
28 $(libnolto_coregrind_@VGCONF_ARCH_PRI@_@VGCONF_OS@_a_OBJECTS)
29+libcoregrind_@VGCONF_ARCH_PRI@_@VGCONF_OS@_a_DEPENDENCIES = \
30+ libnolto_coregrind-@VGCONF_ARCH_PRI@-@VGCONF_OS@.a
31
32 if VGCONF_HAVE_PLATFORM_SEC
33 libcoregrind_@VGCONF_ARCH_SEC@_@VGCONF_OS@_a_SOURCES = \
34@@ -531,6 +533,8 @@ libcoregrind_@VGCONF_ARCH_SEC@_@VGCONF_OS@_a_CFLAGS += \
35 endif
36 libcoregrind_@VGCONF_ARCH_SEC@_@VGCONF_OS@_a_LIBADD = \
37 $(libnolto_coregrind_@VGCONF_ARCH_SEC@_@VGCONF_OS@_a_OBJECTS)
38+libcoregrind_@VGCONF_ARCH_SEC@_@VGCONF_OS@_a_DEPENDENCIES = \
39+ libnolto_coregrind-@VGCONF_ARCH_SEC@-@VGCONF_OS@.a
40 endif
41
42 #----------------------------------------------------------------------------
43--
442.10.2
45