diff options
author | Phil Blundell <philb@gnu.org> | 2012-09-29 13:20:05 +0100 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2012-10-02 11:40:51 +0100 |
commit | 31dec3c6d3862dedeab96b1601bc0f2d7190dd85 (patch) | |
tree | aa9ab6151a73bcb31d400339c6ede00c71cc3d0e /meta/recipes-devtools/opkg | |
parent | 97160f8e92af94640692846997b5f242067fb3bc (diff) | |
download | poky-31dec3c6d3862dedeab96b1601bc0f2d7190dd85.tar.gz |
opkg: Don't call sync() when installing into an offline root
Even when installing onto a live target system, calling sync() during
package installation is of somewhat questionable benefit. But calling
it on the build host during rootfs construction is certainly useless and
can cause I/O to stall for several seconds on even a moderately sized
host which is clearly not desirable.
(From a patch originally by Mike Crowe.)
(From OE-Core rev: f48a68177510e8f2d4fcc3725a6dfc41a9a8e96b)
Signed-off-by: Phil Blundell <philb@gnu.org>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/recipes-devtools/opkg')
-rw-r--r-- | meta/recipes-devtools/opkg/opkg/opkg-no-sync-offline.patch | 18 | ||||
-rw-r--r-- | meta/recipes-devtools/opkg/opkg_svn.bb | 3 |
2 files changed, 20 insertions, 1 deletions
diff --git a/meta/recipes-devtools/opkg/opkg/opkg-no-sync-offline.patch b/meta/recipes-devtools/opkg/opkg/opkg-no-sync-offline.patch new file mode 100644 index 0000000000..b1b3453484 --- /dev/null +++ b/meta/recipes-devtools/opkg/opkg/opkg-no-sync-offline.patch | |||
@@ -0,0 +1,18 @@ | |||
1 | When installing into an offline root, calling sync() is pointless and just | ||
2 | hurts performance. Don't let's do that. | ||
3 | |||
4 | Signed-off-by: Phil Blundell <philb@gnu.org> | ||
5 | Upstream-Status: Pending | ||
6 | |||
7 | --- a/libopkg/opkg_cmd.c 2011-09-08 10:53:07.000000000 +0100 | ||
8 | +++ b/libopkg/opkg_cmd.c 2011-10-04 10:45:22.278615584 +0100 | ||
9 | @@ -64,7 +64,8 @@ write_status_files_if_changed(void) | ||
10 | opkg_msg(INFO, "Writing status file.\n"); | ||
11 | opkg_conf_write_status_files(); | ||
12 | pkg_write_changed_filelists(); | ||
13 | - sync(); | ||
14 | + if (!conf->offline_root) | ||
15 | + sync(); | ||
16 | } else { | ||
17 | opkg_msg(DEBUG, "Nothing to be done.\n"); | ||
18 | } | ||
diff --git a/meta/recipes-devtools/opkg/opkg_svn.bb b/meta/recipes-devtools/opkg/opkg_svn.bb index d89a3f6c66..59bb2d94e2 100644 --- a/meta/recipes-devtools/opkg/opkg_svn.bb +++ b/meta/recipes-devtools/opkg/opkg_svn.bb | |||
@@ -11,6 +11,7 @@ SRC_URI = "svn://opkg.googlecode.com/svn;module=trunk;protocol=http \ | |||
11 | file://0008-select_higher_version.patch \ | 11 | file://0008-select_higher_version.patch \ |
12 | file://0009-pkg_depends-fix-version-constraints.patch \ | 12 | file://0009-pkg_depends-fix-version-constraints.patch \ |
13 | file://0010-pkg_depends-fix-version_constraints_satisfied.patch \ | 13 | file://0010-pkg_depends-fix-version_constraints_satisfied.patch \ |
14 | file://opkg-no-sync-offline.patch \ | ||
14 | " | 15 | " |
15 | 16 | ||
16 | S = "${WORKDIR}/trunk" | 17 | S = "${WORKDIR}/trunk" |
@@ -18,4 +19,4 @@ S = "${WORKDIR}/trunk" | |||
18 | SRCREV = "633" | 19 | SRCREV = "633" |
19 | PV = "0.1.8+svnr${SRCPV}" | 20 | PV = "0.1.8+svnr${SRCPV}" |
20 | 21 | ||
21 | PR = "${INC_PR}.5" | 22 | PR = "${INC_PR}.6" |