summaryrefslogtreecommitdiffstats
path: root/meta/recipes-core/ncurses/files/fix-include-files-race.patch
diff options
context:
space:
mode:
authorJuro Bystricky <juro.bystricky@intel.com>2016-03-14 14:29:11 -0700
committerRichard Purdie <richard.purdie@linuxfoundation.org>2016-03-20 23:12:26 +0000
commit3b8cd1db0d388e50c010899352f641d66e73279c (patch)
treea3d17e652d2847f78c6faa31911da794c4ab045c /meta/recipes-core/ncurses/files/fix-include-files-race.patch
parent9cc65ed0209b756262ae4c73a5d172db4fe01fd6 (diff)
downloadpoky-3b8cd1db0d388e50c010899352f641d66e73279c.tar.gz
ncurses_6: Improve installation
As "install.libs" also installs header files, it is redundant to also call "install.includes". In fact, doing so can lead to a race, as both targets could try to install the header files at the same time if running parallel make. Obviously, with only calling "install.libs", there is no race with "install.includes". If there is no race, then the patch fix-include-files-race.patch is no longer needed. (From OE-Core rev: 8df2060a323acf2a2cc2bc4076623463039c46a6) Signed-off-by: Juro Bystricky <juro.bystricky@intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/recipes-core/ncurses/files/fix-include-files-race.patch')
-rw-r--r--meta/recipes-core/ncurses/files/fix-include-files-race.patch32
1 files changed, 0 insertions, 32 deletions
diff --git a/meta/recipes-core/ncurses/files/fix-include-files-race.patch b/meta/recipes-core/ncurses/files/fix-include-files-race.patch
deleted file mode 100644
index 6f22e98332..0000000000
--- a/meta/recipes-core/ncurses/files/fix-include-files-race.patch
+++ /dev/null
@@ -1,32 +0,0 @@
1There is a race condition when running
2
3 $ make install.libs install.includes
4
5As both targets install identical files. The remedy is to either prevent
6parallel make of install.libs and install.includes, or ensure only one
7target installs the files.
8The second approch will only work if we always install both libs and
9includes (which we do).
10
11
12Upstream-Status: Inappropriate [configuration]
13
14Index: git/mk-hdr.awk
15===================================================================
16--- a/mk-hdr.awk
17+++ b/mk-hdr.awk
18@@ -73,11 +73,13 @@ BEGIN {
19 END {
20 if ( count > 0 )
21 {
22+ print" # patched here: Removed install.libs due the race "
23 print "${INCLUDEDIR} :"
24 print " mkdir -p $@"
25 print ""
26+ print "install.libs :: ;"
27+ print ""
28 print "install \\"
29- print "install.libs \\"
30 print "install.includes :: ${AUTO_SRC} ${INCLUDEDIR} \\"
31
32 for (i = 0; i < count - 1; ++i) {