diff options
author | Martin Jansa <martin.jansa@gmail.com> | 2018-09-30 16:27:37 +0000 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2018-10-04 14:21:41 +0100 |
commit | 50cc48b18066a3dc02d199fdd0ed8930419b13d6 (patch) | |
tree | 0091c48dfc50e0146676974393b75562f78fb737 /meta/recipes-core/glibc/glibc/0033-locale-prevent-maybe-uninitialized-errors-with-Os-BZ.patch | |
parent | bdb49647874e18e7d60374b8973a307551b36a14 (diff) | |
download | poky-50cc48b18066a3dc02d199fdd0ed8930419b13d6.tar.gz |
glibc: bump SRCREV to latest 2.28
* drop one patch already applied in upstream
* this is still only partial fix for issues with -O0 and the bigger
issue might be detected in runtime as described in:
https://sourceware.org/glibc/wiki/FAQ#Why_do_I_get:.60.23error_.22glibc_cannot_be_compiled_without_optimization.22.27.2C_when_trying_to_compile_GNU_libc_with_GNU_CC.3F
https://sourceware.org/bugzilla/show_bug.cgi?id=19444
and tested in glibc build:
https://sourceware.org/git/?p=glibc.git;a=blob;f=include/libc-symbols.h;h=8b9273c13a19f2658105c7997267d9086adae716;hb=HEAD#l74
* restore the anonymous python to trigger fatal error when -O0 is
used (but don't restore the notes for -O, -O1, -Os
* git log --oneline 3c03baca37fdcb52c3881e653ca392bba7a99c2b..044c96f0d5595aeb0bb4e79355081c5a7f4faca5 | tee
044c96f0d5 Fix misreported errno on preadv2/pwritev2 (BZ#23579)
3a67c72c15 Fix stack overflow in tst-setcontext9 (bug 23717)
2339d6a55e i386: Use ENTRY and END in start.S [BZ #23606]
0ef2f4400c Fix strstr bug with huge needles (bug 23637)
a55e109709 Fix tst-setcontext9 for optimized small stacks.
307d04334d misc: New test misc/tst-gethostid
e7d22db29c Linux gethostid: Check for NULL value from gethostbyname_r [BZ #23679]
1fe2b9ca8a Fix segfault in maybe_script_execute.
0b79004569 regex: Add test tst-regcomp-truncated [BZ #23578]
58559f1443 regex: fix uninitialized memory access
aa8a3e4cde pthread_cond_broadcast: Fix waiters-after-spinning case [BZ #23538]
c87b5bab24 Improve ChangeLog message.
66fdfd57fe Regen RISC-V rvd ULPs
b0aa03dfff RISC-V: Fix rounding save/restore bug.
2f498f3d14 nss_files: Fix file stream leak in aliases lookup [BZ #23521]
bfcfa22589 nscd: Deallocate existing user names in file parser
d05b05d157 error, error_at_line: Add missing va_end calls
4b25485f03 Linux: Rewrite __old_getdents64 [BZ #23497]
726e1554ce hurd: Avoid PLTs for __pthread_get/setspecific
7f11842e74 hurd: Add missing symbols for proper libc_get/setspecific
* update 0031-sysdeps-ieee754-prevent-maybe-uninitialized-errors-w.patch
based on review comments in upstream and extend it to cover PPC based
on:
http://lists.openembedded.org/pipermail/openembedded-core/2018-September/156258.html
* update 0032-sysdeps-ieee754-soft-fp-ignore-maybe-uninitialized-w.patch
based on review comments in upstream
* add 0033-locale-prevent-maybe-uninitialized-errors-with-Os-BZ.patch
with a fix for aarch64 build with -Os
* build tested with qemuarm, qemuarm64, qemux86, qemux86-64, qemuppc,
qemumips, qemumips64 with -O, -O1, -Os.
(From OE-Core rev: f1f38df91975f9b53933c2d2fbdca291d1872d5f)
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/recipes-core/glibc/glibc/0033-locale-prevent-maybe-uninitialized-errors-with-Os-BZ.patch')
-rw-r--r-- | meta/recipes-core/glibc/glibc/0033-locale-prevent-maybe-uninitialized-errors-with-Os-BZ.patch | 68 |
1 files changed, 68 insertions, 0 deletions
diff --git a/meta/recipes-core/glibc/glibc/0033-locale-prevent-maybe-uninitialized-errors-with-Os-BZ.patch b/meta/recipes-core/glibc/glibc/0033-locale-prevent-maybe-uninitialized-errors-with-Os-BZ.patch new file mode 100644 index 0000000000..31058ca91a --- /dev/null +++ b/meta/recipes-core/glibc/glibc/0033-locale-prevent-maybe-uninitialized-errors-with-Os-BZ.patch | |||
@@ -0,0 +1,68 @@ | |||
1 | From cbada1a1b218c1ef61d0eb4363fad7598e6509d6 Mon Sep 17 00:00:00 2001 | ||
2 | From: Martin Jansa <Martin.Jansa@gmail.com> | ||
3 | Date: Sun, 30 Sep 2018 09:16:48 +0000 | ||
4 | Subject: [PATCH] locale: prevent maybe-uninitialized errors with -Os [BZ | ||
5 | #19444] | ||
6 | |||
7 | Fixes following error when building for aarch64 with -Os: | ||
8 | | In file included from strcoll_l.c:43: | ||
9 | | strcoll_l.c: In function '__strcoll_l': | ||
10 | | ../locale/weight.h:31:26: error: 'seq2.back_us' may be used uninitialized in this function [-Werror=maybe-uninitialized] | ||
11 | | int_fast32_t i = table[*(*cpp)++]; | ||
12 | | ^~~~~~~~~ | ||
13 | | strcoll_l.c:304:18: note: 'seq2.back_us' was declared here | ||
14 | | coll_seq seq1, seq2; | ||
15 | | ^~~~ | ||
16 | | In file included from strcoll_l.c:43: | ||
17 | | ../locale/weight.h:31:26: error: 'seq1.back_us' may be used uninitialized in this function [-Werror=maybe-uninitialized] | ||
18 | | int_fast32_t i = table[*(*cpp)++]; | ||
19 | | ^~~~~~~~~ | ||
20 | | strcoll_l.c:304:12: note: 'seq1.back_us' was declared here | ||
21 | | coll_seq seq1, seq2; | ||
22 | | ^~~~ | ||
23 | |||
24 | Partial fix for [BZ #23716] | ||
25 | * locale/weight.h: Fix build with -Os. | ||
26 | |||
27 | Work around the issue instead of removing -O like we do with | ||
28 | SELECTED_OPTIMIZATION | ||
29 | |||
30 | Upstream-Status: Submitted [https://www.sourceware.org/ml/libc-alpha/2018-09/msg00539.html] | ||
31 | |||
32 | Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> | ||
33 | --- | ||
34 | ChangeLog | 4 ++++ | ||
35 | locale/weight.h | 7 +++++++ | ||
36 | 2 files changed, 11 insertions(+) | ||
37 | |||
38 | diff --git a/ChangeLog b/ChangeLog | ||
39 | index 216336edc9..84fbbf47ed 100644 | ||
40 | --- a/ChangeLog | ||
41 | +++ b/ChangeLog | ||
42 | @@ -1,3 +1,7 @@ | ||
43 | +2018-09-30 Martin Jansa <Martin.Jansa@gmail.com> | ||
44 | + Partial fix for [BZ #23716] | ||
45 | + * locale/weight.h: Fix build with -Os. | ||
46 | + | ||
47 | 2018-09-30 Martin Jansa <Martin.Jansa@gmail.com> | ||
48 | Partial fix for [BZ #23716] | ||
49 | * sysdeps/ieee754/soft-fp/s_fdiv.c: Fix build with -O. | ||
50 | diff --git a/locale/weight.h b/locale/weight.h | ||
51 | index 6028d3595e..10bcea25e5 100644 | ||
52 | --- a/locale/weight.h | ||
53 | +++ b/locale/weight.h | ||
54 | @@ -28,7 +28,14 @@ findidx (const int32_t *table, | ||
55 | const unsigned char *extra, | ||
56 | const unsigned char **cpp, size_t len) | ||
57 | { | ||
58 | + /* With GCC 8 when compiling with -Os the compiler warns that | ||
59 | + seq1.back_us and seq2.back_us might be used uninitialized. | ||
60 | + This uninitialized use is impossible for the same reason | ||
61 | + as described in comments in locale/weightwc.h. */ | ||
62 | + DIAG_PUSH_NEEDS_COMMENT; | ||
63 | + DIAG_IGNORE_Os_NEEDS_COMMENT (8, "-Wmaybe-uninitialized"); | ||
64 | int_fast32_t i = table[*(*cpp)++]; | ||
65 | + DIAG_POP_NEEDS_COMMENT; | ||
66 | const unsigned char *cp; | ||
67 | const unsigned char *usrc; | ||
68 | |||