diff options
author | Marta Rybczynska <rybczynska@gmail.com> | 2022-02-18 11:05:51 +0100 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2022-03-02 00:21:37 +0000 |
commit | 9b69e6916039a75c3abee9dabfeb5421c49f1ae2 (patch) | |
tree | 3e49cb5b541283771557a4b33acca6bfaa7b5826 /meta/recipes-bsp | |
parent | 6360727bb14e05d316aaf575137c5c821f441e5f (diff) | |
download | poky-9b69e6916039a75c3abee9dabfeb5421c49f1ae2.tar.gz |
grub: fix incorrect use of a negative value
This patch adds a fix for an incorrect use of a negative value in grub's
util/glue-efi. It is a part of a security series [1].
[1] https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00007.html
(From OE-Core rev: de1fe600212ff6d460bdc672d7ca0e13afbe7514)
Signed-off-by: Marta Rybczynska <marta.rybczynska@huawei.com>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/recipes-bsp')
-rw-r--r-- | meta/recipes-bsp/grub/files/0043-util-glue-efi-Fix-incorrect-use-of-a-possibly-negati.patch | 50 | ||||
-rw-r--r-- | meta/recipes-bsp/grub/grub2.inc | 1 |
2 files changed, 51 insertions, 0 deletions
diff --git a/meta/recipes-bsp/grub/files/0043-util-glue-efi-Fix-incorrect-use-of-a-possibly-negati.patch b/meta/recipes-bsp/grub/files/0043-util-glue-efi-Fix-incorrect-use-of-a-possibly-negati.patch new file mode 100644 index 0000000000..66d7c0aa42 --- /dev/null +++ b/meta/recipes-bsp/grub/files/0043-util-glue-efi-Fix-incorrect-use-of-a-possibly-negati.patch | |||
@@ -0,0 +1,50 @@ | |||
1 | From e301a0f38a2130eb80f346c31e43bf5089af583c Mon Sep 17 00:00:00 2001 | ||
2 | From: Darren Kenny <darren.kenny@oracle.com> | ||
3 | Date: Fri, 4 Dec 2020 15:04:28 +0000 | ||
4 | Subject: [PATCH] util/glue-efi: Fix incorrect use of a possibly negative value | ||
5 | |||
6 | It is possible for the ftell() function to return a negative value, | ||
7 | although it is fairly unlikely here, we should be checking for | ||
8 | a negative value before we assign it to an unsigned value. | ||
9 | |||
10 | Fixes: CID 73744 | ||
11 | |||
12 | Signed-off-by: Darren Kenny <darren.kenny@oracle.com> | ||
13 | Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com> | ||
14 | |||
15 | Upstream-Status: Backport [https://git.savannah.gnu.org/cgit/grub.git/commit/?id=1641d74e16f9d1ca35ba1a87ee4a0bf3afa48e72] | ||
16 | Signed-off-by: Marta Rybczynska <marta.rybczynska@huawei.com> | ||
17 | --- | ||
18 | util/glue-efi.c | 14 ++++++++++++-- | ||
19 | 1 file changed, 12 insertions(+), 2 deletions(-) | ||
20 | |||
21 | diff --git a/util/glue-efi.c b/util/glue-efi.c | ||
22 | index 68f5316..de0fa6d 100644 | ||
23 | --- a/util/glue-efi.c | ||
24 | +++ b/util/glue-efi.c | ||
25 | @@ -39,13 +39,23 @@ write_fat (FILE *in32, FILE *in64, FILE *out, const char *out_filename, | ||
26 | struct grub_macho_fat_header head; | ||
27 | struct grub_macho_fat_arch arch32, arch64; | ||
28 | grub_uint32_t size32, size64; | ||
29 | + long size; | ||
30 | char *buf; | ||
31 | |||
32 | fseek (in32, 0, SEEK_END); | ||
33 | - size32 = ftell (in32); | ||
34 | + size = ftell (in32); | ||
35 | + if (size < 0) | ||
36 | + grub_util_error ("cannot get end of input file '%s': %s", | ||
37 | + name32, strerror (errno)); | ||
38 | + size32 = (grub_uint32_t) size; | ||
39 | fseek (in32, 0, SEEK_SET); | ||
40 | + | ||
41 | fseek (in64, 0, SEEK_END); | ||
42 | - size64 = ftell (in64); | ||
43 | + size = ftell (in64); | ||
44 | + if (size < 0) | ||
45 | + grub_util_error ("cannot get end of input file '%s': %s", | ||
46 | + name64, strerror (errno)); | ||
47 | + size64 = (grub_uint64_t) size; | ||
48 | fseek (in64, 0, SEEK_SET); | ||
49 | |||
50 | head.magic = grub_cpu_to_le32_compile_time (GRUB_MACHO_FAT_EFI_MAGIC); | ||
diff --git a/meta/recipes-bsp/grub/grub2.inc b/meta/recipes-bsp/grub/grub2.inc index a1fbc5e644..2f230065b2 100644 --- a/meta/recipes-bsp/grub/grub2.inc +++ b/meta/recipes-bsp/grub/grub2.inc | |||
@@ -89,6 +89,7 @@ SRC_URI = "${GNU_MIRROR}/grub/grub-${PV}.tar.gz \ | |||
89 | file://0040-loader-xnu-Check-if-pointer-is-NULL-before-using-it.patch \ | 89 | file://0040-loader-xnu-Check-if-pointer-is-NULL-before-using-it.patch \ |
90 | file://0041-util-grub-install-Fix-NULL-pointer-dereferences.patch \ | 90 | file://0041-util-grub-install-Fix-NULL-pointer-dereferences.patch \ |
91 | file://0042-util-grub-editenv-Fix-incorrect-casting-of-a-signed-.patch \ | 91 | file://0042-util-grub-editenv-Fix-incorrect-casting-of-a-signed-.patch \ |
92 | file://0043-util-glue-efi-Fix-incorrect-use-of-a-possibly-negati.patch \ | ||
92 | " | 93 | " |
93 | SRC_URI[md5sum] = "5ce674ca6b2612d8939b9e6abed32934" | 94 | SRC_URI[md5sum] = "5ce674ca6b2612d8939b9e6abed32934" |
94 | SRC_URI[sha256sum] = "f10c85ae3e204dbaec39ae22fa3c5e99f0665417e91c2cb49b7e5031658ba6ea" | 95 | SRC_URI[sha256sum] = "f10c85ae3e204dbaec39ae22fa3c5e99f0665417e91c2cb49b7e5031658ba6ea" |