diff options
author | Marta Rybczynska <rybczynska@gmail.com> | 2022-02-18 11:05:23 +0100 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2022-03-02 00:21:36 +0000 |
commit | 90b1d407c6636acdfcfcadb8c99986aab5416a98 (patch) | |
tree | cc3d11b112ef957bf185905da1605dab25f41a4a /meta/recipes-bsp | |
parent | 495bf963be2eef7688994692b283adf77fa25380 (diff) | |
download | poky-90b1d407c6636acdfcfcadb8c99986aab5416a98.tar.gz |
grub: add a missing NULL check
This fix adds a missing check for NULL pointer from an external source
in grub's kern/partition. It is a part of a security series [1].
[1] https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00007.html
(From OE-Core rev: c443bd15c975d05ca7afc44e81bda1e974833e36)
Signed-off-by: Marta Rybczynska <marta.rybczynska@huawei.com>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/recipes-bsp')
-rw-r--r-- | meta/recipes-bsp/grub/files/0015-kern-partition-Check-for-NULL-before-dereferencing-i.patch | 43 | ||||
-rw-r--r-- | meta/recipes-bsp/grub/grub2.inc | 1 |
2 files changed, 44 insertions, 0 deletions
diff --git a/meta/recipes-bsp/grub/files/0015-kern-partition-Check-for-NULL-before-dereferencing-i.patch b/meta/recipes-bsp/grub/files/0015-kern-partition-Check-for-NULL-before-dereferencing-i.patch new file mode 100644 index 0000000000..af9fcd45cc --- /dev/null +++ b/meta/recipes-bsp/grub/files/0015-kern-partition-Check-for-NULL-before-dereferencing-i.patch | |||
@@ -0,0 +1,43 @@ | |||
1 | From 0da8ef2e03a8591586b53a29af92d2ace76a04e3 Mon Sep 17 00:00:00 2001 | ||
2 | From: Darren Kenny <darren.kenny@oracle.com> | ||
3 | Date: Fri, 23 Oct 2020 09:49:59 +0000 | ||
4 | Subject: [PATCH] kern/partition: Check for NULL before dereferencing input | ||
5 | string | ||
6 | |||
7 | There is the possibility that the value of str comes from an external | ||
8 | source and continuing to use it before ever checking its validity is | ||
9 | wrong. So, needs fixing. | ||
10 | |||
11 | Additionally, drop unneeded part initialization. | ||
12 | |||
13 | Fixes: CID 292444 | ||
14 | |||
15 | Signed-off-by: Darren Kenny <darren.kenny@oracle.com> | ||
16 | Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com> | ||
17 | |||
18 | Upstream-Status: Backport [https://git.savannah.gnu.org/cgit/grub.git/commit/?id=bc9c468a2ce84bc767234eec888b71f1bc744fff] | ||
19 | Signed-off-by: Marta Rybczynska <marta.rybczynska@huawei.com> | ||
20 | --- | ||
21 | grub-core/kern/partition.c | 5 ++++- | ||
22 | 1 file changed, 4 insertions(+), 1 deletion(-) | ||
23 | |||
24 | diff --git a/grub-core/kern/partition.c b/grub-core/kern/partition.c | ||
25 | index e499147..b10a184 100644 | ||
26 | --- a/grub-core/kern/partition.c | ||
27 | +++ b/grub-core/kern/partition.c | ||
28 | @@ -109,11 +109,14 @@ grub_partition_map_probe (const grub_partition_map_t partmap, | ||
29 | grub_partition_t | ||
30 | grub_partition_probe (struct grub_disk *disk, const char *str) | ||
31 | { | ||
32 | - grub_partition_t part = 0; | ||
33 | + grub_partition_t part; | ||
34 | grub_partition_t curpart = 0; | ||
35 | grub_partition_t tail; | ||
36 | const char *ptr; | ||
37 | |||
38 | + if (str == NULL) | ||
39 | + return 0; | ||
40 | + | ||
41 | part = tail = disk->partition; | ||
42 | |||
43 | for (ptr = str; *ptr;) | ||
diff --git a/meta/recipes-bsp/grub/grub2.inc b/meta/recipes-bsp/grub/grub2.inc index 7cf4d64149..94b89aa643 100644 --- a/meta/recipes-bsp/grub/grub2.inc +++ b/meta/recipes-bsp/grub/grub2.inc | |||
@@ -61,6 +61,7 @@ SRC_URI = "${GNU_MIRROR}/grub/grub-${PV}.tar.gz \ | |||
61 | file://0012-gnulib-regcomp-Fix-uninitialized-re_token.patch \ | 61 | file://0012-gnulib-regcomp-Fix-uninitialized-re_token.patch \ |
62 | file://0013-io-lzopio-Resolve-unnecessary-self-assignment-errors.patch \ | 62 | file://0013-io-lzopio-Resolve-unnecessary-self-assignment-errors.patch \ |
63 | file://0014-zstd-Initialize-seq_t-structure-fully.patch \ | 63 | file://0014-zstd-Initialize-seq_t-structure-fully.patch \ |
64 | file://0015-kern-partition-Check-for-NULL-before-dereferencing-i.patch \ | ||
64 | " | 65 | " |
65 | SRC_URI[md5sum] = "5ce674ca6b2612d8939b9e6abed32934" | 66 | SRC_URI[md5sum] = "5ce674ca6b2612d8939b9e6abed32934" |
66 | SRC_URI[sha256sum] = "f10c85ae3e204dbaec39ae22fa3c5e99f0665417e91c2cb49b7e5031658ba6ea" | 67 | SRC_URI[sha256sum] = "f10c85ae3e204dbaec39ae22fa3c5e99f0665417e91c2cb49b7e5031658ba6ea" |