diff options
author | Richard Purdie <richard.purdie@linuxfoundation.org> | 2013-09-06 14:14:34 +0000 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2013-09-06 23:04:51 +0100 |
commit | 9b84fc7cc2a9100685e78a5fe051b3a7be5a540a (patch) | |
tree | 4923b71c669051fb0b23c858bcfe3508b6d09977 /meta/lib | |
parent | 457e584e3218d88bd2083a9628237b2a1cdae346 (diff) | |
download | poky-9b84fc7cc2a9100685e78a5fe051b3a7be5a540a.tar.gz |
lib/oeqa/qemurunner: Use a timeout in select() call
A 0 value to select.select() immediately returns with no timeout. This was
pegging the cpu at 100% for the python process which was bad and may be
contributing to some of the timeout problems.
Profile from -P of a core-image-minimal before:
97526792 function calls (97525652 primitive calls) in 45.189 seconds
and after:
50204 function calls (49064 primitive calls) in 17.318 seconds
Saving 97.5 million function calls has to be good :)
(From OE-Core rev: c0551436974d179df23418567f18a082830380f6)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/lib')
-rw-r--r-- | meta/lib/oeqa/utils/qemurunner.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/meta/lib/oeqa/utils/qemurunner.py b/meta/lib/oeqa/utils/qemurunner.py index e7bd8b147b..b5c757a927 100644 --- a/meta/lib/oeqa/utils/qemurunner.py +++ b/meta/lib/oeqa/utils/qemurunner.py | |||
@@ -101,7 +101,7 @@ class QemuRunner: | |||
101 | reachedlogin = False | 101 | reachedlogin = False |
102 | stopread = False | 102 | stopread = False |
103 | while time.time() < endtime and not stopread: | 103 | while time.time() < endtime and not stopread: |
104 | sread, swrite, serror = select.select(socklist, [], [], 0) | 104 | sread, swrite, serror = select.select(socklist, [], [], 5) |
105 | for sock in sread: | 105 | for sock in sread: |
106 | if sock is self.server_socket: | 106 | if sock is self.server_socket: |
107 | self.qemusock, addr = self.server_socket.accept() | 107 | self.qemusock, addr = self.server_socket.accept() |