summaryrefslogtreecommitdiffstats
path: root/meta/lib/oeqa/sdk/cases/gcc.py
diff options
context:
space:
mode:
authorChen Qi <Qi.Chen@windriver.com>2018-08-29 10:56:31 +0800
committerRichard Purdie <richard.purdie@linuxfoundation.org>2018-09-04 11:03:55 +0100
commit227cc78b3f461164310de33194cc9e0d006fbfef (patch)
tree7c18c789958811bc5f3e57b03f0363c890bbfecf /meta/lib/oeqa/sdk/cases/gcc.py
parent20cba32f2d9caab1202295424bd85c26b8c4192a (diff)
downloadpoky-227cc78b3f461164310de33194cc9e0d006fbfef.tar.gz
oeqa/sdk: fixes related to hasPackage semantics
The current _hasPackage does a regex match when checking for the existence of packages. This will sometimes result in unexpected result. For example, the condition hasTargetPackage('gcc') is likely to be always true as it matches libgcc1. For most of the time, we should do exact match instead of regex match. So change _hasPackage function to do that. For the current sdk test cases, the only place that needs regex match is '^gcc-'. This is because there's no easy way to get multilib tune arch (e.g. i686) from testdata.json file. Besides, packagegroup-cross-canadian-xxx and gcc-xxx should be check in host manifest instead of the target one. So fix to use hasHostPackage. Also, as we are doing exact match, there's no need to use r'gtk\+3', just 'gtk+3' is enough. (From OE-Core rev: 595e9922cdbacf84cf35cc83f0d03cace042e302) Signed-off-by: Chen Qi <Qi.Chen@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/lib/oeqa/sdk/cases/gcc.py')
-rw-r--r--meta/lib/oeqa/sdk/cases/gcc.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/meta/lib/oeqa/sdk/cases/gcc.py b/meta/lib/oeqa/sdk/cases/gcc.py
index d11f4b63fb..b32b01fc24 100644
--- a/meta/lib/oeqa/sdk/cases/gcc.py
+++ b/meta/lib/oeqa/sdk/cases/gcc.py
@@ -18,8 +18,8 @@ class GccCompileTest(OESDKTestCase):
18 18
19 def setUp(self): 19 def setUp(self):
20 machine = self.td.get("MACHINE") 20 machine = self.td.get("MACHINE")
21 if not (self.tc.hasTargetPackage("packagegroup-cross-canadian-%s" % machine) or 21 if not (self.tc.hasHostPackage("packagegroup-cross-canadian-%s" % machine) or
22 self.tc.hasTargetPackage("gcc")): 22 self.tc.hasHostPackage("^gcc-", regex=True)):
23 raise unittest.SkipTest("GccCompileTest class: SDK doesn't contain a cross-canadian toolchain") 23 raise unittest.SkipTest("GccCompileTest class: SDK doesn't contain a cross-canadian toolchain")
24 24
25 def test_gcc_compile(self): 25 def test_gcc_compile(self):