summaryrefslogtreecommitdiffstats
path: root/meta/lib/oe/rootfs.py
diff options
context:
space:
mode:
authorRichard Purdie <richard.purdie@linuxfoundation.org>2017-01-23 17:43:40 +0000
committerRichard Purdie <richard.purdie@linuxfoundation.org>2017-01-23 23:30:57 +0000
commit6ab4c5033af72f102e7935de62e600b7ce247f34 (patch)
treedfc83f0cff8d54ce632b34be2e0c2257760ff226 /meta/lib/oe/rootfs.py
parent0a30ae5e18cd1c1576da80c3b9d31e8d64cfcc01 (diff)
downloadpoky-6ab4c5033af72f102e7935de62e600b7ce247f34.tar.gz
classes/oeqa: Replace subprocess.check_call() with check_output()
If you use subprocess.check_output() the traceback will contain the output when the command fails which is very useful for debugging. There is no good reason not to use this everywhere. (From OE-Core rev: ad750dd1cc9d789abe723daddd098ce41d8547f5) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/lib/oe/rootfs.py')
-rw-r--r--meta/lib/oe/rootfs.py6
1 files changed, 3 insertions, 3 deletions
diff --git a/meta/lib/oe/rootfs.py b/meta/lib/oe/rootfs.py
index 5b842ba46a..9c8a0ebb7e 100644
--- a/meta/lib/oe/rootfs.py
+++ b/meta/lib/oe/rootfs.py
@@ -303,10 +303,10 @@ class Rootfs(object, metaclass=ABCMeta):
303 bb.note("> Executing %s intercept ..." % script) 303 bb.note("> Executing %s intercept ..." % script)
304 304
305 try: 305 try:
306 subprocess.check_call(script_full) 306 subprocess.check_output(script_full)
307 except subprocess.CalledProcessError as e: 307 except subprocess.CalledProcessError as e:
308 bb.warn("The postinstall intercept hook '%s' failed (exit code: %d)! See log for details!" % 308 bb.warn("The postinstall intercept hook '%s' failed (exit code: %d)! See log for details! (Output: %s)" %
309 (script, e.returncode)) 309 (script, e.returncode, e.output))
310 310
311 with open(script_full) as intercept: 311 with open(script_full) as intercept:
312 registered_pkgs = None 312 registered_pkgs = None