summaryrefslogtreecommitdiffstats
path: root/meta/files
diff options
context:
space:
mode:
authorTrevor Gamblin <trevor.gamblin@windriver.com>2019-12-05 11:55:19 -0500
committerRichard Purdie <richard.purdie@linuxfoundation.org>2020-02-20 13:00:28 +0000
commit0f54a2fd69c9513cb857a3a0436bd8b75332f4e9 (patch)
tree21f0ce1dbf1ff1e070e2b1b304a4c36c960ab194 /meta/files
parent9b312bca47e22cc3a93df356dcae73a8ee4a6787 (diff)
downloadpoky-0f54a2fd69c9513cb857a3a0436bd8b75332f4e9.tar.gz
oescripts.py: use unittest.SkipUnless for class skip
Yocto Bug: https://bugzilla.yoctoproject.org/show_bug.cgi?id=13663 Prior to this fix, the try/except block in OEScriptTests' setUpClass did both the import and the raise unittest.SkipTest for the subsequent OEPybootchartguyTests. The consequence of the this meant that, when cairo was not available on the test host, the raise was counted only once as a class setup issue, instead of once for each of the tests to be run, resulting in incorrect skip counts in the test results. Instead of raising unittest.SkipTest in setUpClass, the more proper method is to use the unittest.skipUnless method along with importlib.util.find_spec to check for the presence of the python3-cairo module. This allows the entire class to be skipped if cairo is not present, while also correctly passing along the skip state for each of the class's tests, and avoiding the UNKNOWN results to appear in cases where the -j option was provided to oe-selftest, but the tests were still skipped. (From OE-Core rev: 10c2216cb6fb61c74babd8bd17cb3481754b7475) Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/files')
0 files changed, 0 insertions, 0 deletions