diff options
author | Mike Crowe <mac@mcrowe.com> | 2019-06-25 14:16:25 +0100 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2019-06-27 12:20:36 +0100 |
commit | a478ad4c2d062e8b50fb7dc1fc88a728fc26ace6 (patch) | |
tree | ca0a3c42e1dee72186e1ef901f963683461aba56 /meta/conf | |
parent | bb75a124251a407daa765fa47b961e733042c33d (diff) | |
download | poky-a478ad4c2d062e8b50fb7dc1fc88a728fc26ace6.tar.gz |
bitbake.conf: Stop exporting TARGET_ flags variables
Way back in
http://lists.openembedded.org/pipermail/openembedded-core/2014-April/210138.html
a few of us discussed not exporting TARGET_LDFLAGS. There seemed to be
support for this idea, and I modified our tree to not do so. I then seem to
have dropped the ball. :( We've been running like that for over five years,
and not observed any problems.
It seems sensible to stop exporting TARGET_CPPFLAGS, TARGET_CFLAGS and
TARGET_CXXFLAGS too.
I've successfully compile-tested core-image-minimal and core-image-sato for
x86_64 and qemuarm64 with these changes.
(From OE-Core rev: 1b1ab93408c3ba72f855b2f4a028f1a917e9b551)
Signed-off-by: Mike Crowe <mac@mcrowe.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/conf')
-rw-r--r-- | meta/conf/bitbake.conf | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf index 4b907d6820..5e93f5c223 100644 --- a/meta/conf/bitbake.conf +++ b/meta/conf/bitbake.conf | |||
@@ -569,17 +569,17 @@ PATCHRESOLVE = "noop" | |||
569 | export BUILD_CPPFLAGS = "-isystem${STAGING_INCDIR_NATIVE}" | 569 | export BUILD_CPPFLAGS = "-isystem${STAGING_INCDIR_NATIVE}" |
570 | BUILDSDK_CPPFLAGS = "" | 570 | BUILDSDK_CPPFLAGS = "" |
571 | export CPPFLAGS = "${TARGET_CPPFLAGS}" | 571 | export CPPFLAGS = "${TARGET_CPPFLAGS}" |
572 | export TARGET_CPPFLAGS = "" | 572 | TARGET_CPPFLAGS = "" |
573 | 573 | ||
574 | export BUILD_CFLAGS = "${BUILD_CPPFLAGS} ${BUILD_OPTIMIZATION}" | 574 | export BUILD_CFLAGS = "${BUILD_CPPFLAGS} ${BUILD_OPTIMIZATION}" |
575 | BUILDSDK_CFLAGS = "${BUILDSDK_CPPFLAGS} ${BUILD_OPTIMIZATION} ${DEBUG_PREFIX_MAP}" | 575 | BUILDSDK_CFLAGS = "${BUILDSDK_CPPFLAGS} ${BUILD_OPTIMIZATION} ${DEBUG_PREFIX_MAP}" |
576 | export CFLAGS = "${TARGET_CFLAGS}" | 576 | export CFLAGS = "${TARGET_CFLAGS}" |
577 | export TARGET_CFLAGS = "${TARGET_CPPFLAGS} ${SELECTED_OPTIMIZATION}" | 577 | TARGET_CFLAGS = "${TARGET_CPPFLAGS} ${SELECTED_OPTIMIZATION}" |
578 | 578 | ||
579 | export BUILD_CXXFLAGS = "${BUILD_CFLAGS}" | 579 | export BUILD_CXXFLAGS = "${BUILD_CFLAGS}" |
580 | BUILDSDK_CXXFLAGS = "${BUILDSDK_CFLAGS}" | 580 | BUILDSDK_CXXFLAGS = "${BUILDSDK_CFLAGS}" |
581 | export CXXFLAGS = "${TARGET_CXXFLAGS}" | 581 | export CXXFLAGS = "${TARGET_CXXFLAGS}" |
582 | export TARGET_CXXFLAGS = "${TARGET_CFLAGS}" | 582 | TARGET_CXXFLAGS = "${TARGET_CFLAGS}" |
583 | 583 | ||
584 | export BUILD_LDFLAGS = "-L${STAGING_LIBDIR_NATIVE} \ | 584 | export BUILD_LDFLAGS = "-L${STAGING_LIBDIR_NATIVE} \ |
585 | -L${STAGING_BASE_LIBDIR_NATIVE} \ | 585 | -L${STAGING_BASE_LIBDIR_NATIVE} \ |
@@ -601,7 +601,7 @@ TARGET_LINK_HASH_STYLE ?= "${@['-Wl,--hash-style=gnu',''][d.getVar('LINKER_HASH_ | |||
601 | ASNEEDED ?= "-Wl,--as-needed" | 601 | ASNEEDED ?= "-Wl,--as-needed" |
602 | 602 | ||
603 | export LDFLAGS = "${TARGET_LDFLAGS}" | 603 | export LDFLAGS = "${TARGET_LDFLAGS}" |
604 | export TARGET_LDFLAGS = "-Wl,-O1 ${TARGET_LINK_HASH_STYLE} ${ASNEEDED}" | 604 | TARGET_LDFLAGS = "-Wl,-O1 ${TARGET_LINK_HASH_STYLE} ${ASNEEDED}" |
605 | 605 | ||
606 | # Pass parallel make options to the compile task | 606 | # Pass parallel make options to the compile task |
607 | EXTRA_OEMAKE_prepend_task-compile = "${PARALLEL_MAKE} " | 607 | EXTRA_OEMAKE_prepend_task-compile = "${PARALLEL_MAKE} " |