diff options
author | Ross Burton <ross.burton@intel.com> | 2016-07-21 20:29:27 +0100 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2016-07-26 08:56:29 +0100 |
commit | 7d04a4dbfdcc2cadaf453b07e30ef9ced3031f88 (patch) | |
tree | ba9a35f3d1959dd8a0f26c4813d58086d70934e9 /meta/classes | |
parent | 2eec44ee23e52e439a66fd5296acbf866ca575fe (diff) | |
download | poky-7d04a4dbfdcc2cadaf453b07e30ef9ced3031f88.tar.gz |
insane: only check ${S} exists if we had sources to fetch
Only check that ${S} actually exists if there was something in ${SRC_URI} to
fetch, the argument being that if SRC_URI is empty the the recipe won't be using
${S} at all.
In general recipes that have no sources can remove the unpack task, but
expecting all recipes to do this relatively advanced operation isn't realistic.
(From OE-Core rev: 8cba511ab6ea557fab9f7838dfe1fc8284bbdd68)
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/classes')
-rw-r--r-- | meta/classes/insane.bbclass | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass index 98381c20ee..2cb8cc0abf 100644 --- a/meta/classes/insane.bbclass +++ b/meta/classes/insane.bbclass | |||
@@ -1256,10 +1256,9 @@ Missing inherit gettext?""" % (gt, config)) | |||
1256 | } | 1256 | } |
1257 | 1257 | ||
1258 | python do_qa_unpack() { | 1258 | python do_qa_unpack() { |
1259 | bb.note("Checking has ${S} been created") | 1259 | src_uri = d.getVar('SRC_URI', True) |
1260 | |||
1261 | s_dir = d.getVar('S', True) | 1260 | s_dir = d.getVar('S', True) |
1262 | if not os.path.exists(s_dir): | 1261 | if src_uri and not os.path.exists(s_dir): |
1263 | bb.warn('%s: the directory %s (%s) pointed to by the S variable doesn\'t exist - please set S within the recipe to point to where the source has been unpacked to' % (d.getVar('PN', True), d.getVar('S', False), s_dir)) | 1262 | bb.warn('%s: the directory %s (%s) pointed to by the S variable doesn\'t exist - please set S within the recipe to point to where the source has been unpacked to' % (d.getVar('PN', True), d.getVar('S', False), s_dir)) |
1264 | } | 1263 | } |
1265 | 1264 | ||